February 2018 - Koha-bugs - lists.koha-community.org

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Rebased for move of javascript to footer. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71093|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71918&action=ed… Bug 20100: Disallow access to superlibrarian privileges at client side This last patch activates the check at client side. If the pref ProtectSuperlibPrivs is enabled, non-superlibs should not be able to change superlibrarian privileges via the interface. Test plan: [1] Enable the pref. [2] Login as superlib and add/remove superlib privs to a staff user. [3] Login as another user (no superlib, but having borrowers, permissions and staff_access). Verify that you cannot add or remove superlib privs. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3777] Field Sizes Inconsistent
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3777 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jon Knight from comment #12) > I'm just trawling through old REOPENed cases and I see that the current > (17.05) borrower schema still has the inconsistencies in the addresses. As > this was reopened because it was proving to be an issue for some addresses > longer than 100 characters, is it worth just attacking just those fields to > make them all match the address versions? > > In other words make these field changes in the borrowers table schema: > > B_address mediumtext NOT NULL, > B_address2 text, > B_city mediumtext NOT NULL, > > and > > altcontactaddress1 mediumtext NOT NULL, > altcontactaddress2 text, > altcontactaddress3 mediumtext NOT NULL, I once tried to start a clean-up, but ended very confused. In your eample I think there is probably no reason that ...address2 should not be mediumtext not null too? One thing I encountered back then was that some types can't be using not null (iirc). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|can't place holds on 'on |Can't place holds on 'on |order' items with |order' items with |AllowOnShelfHolds off |AllowOnShelfHolds off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen(a)joensuu.fi --- Comment #60 from paxed <pasi.kallinen(a)joensuu.fi> --- (In reply to Jesse Weaver from comment #57) > Created attachment 70974 [details] [review] > Bug 15395: Example usage of I18N Template::Toolkit plugin > > Moved this patch for example usage to teh end of patch set > and resolved minor conflict while applyin > Signed-off-by: Marc Véron <veron(a)veron.ch> I'm confused by this example. How does the msgid look like in the po-file? msgid "item" msgid_plural "items" Like that? If so, then that's a bad example, as it's basically the same as concatenating number + "item" The number placeholder should be included in the translatable string, so the msgid looks like this: msgid "one item" msgid_plural "%s items" Because the translator can then actually make it sound natural in their own language - perhaps the language needs an article before the number, or a suffix to the number, both of which would be impossible to do with the original example. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15510] New professional cataloguing editor shows OPAC favicon
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15510 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #5 from David Cook <dcook(a)prosentient.com.au> --- I had some interesting favicon experiences on Bug 20173. Maybe it's related? I think sometimes the browser tries to be too smart for its own good... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18760 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19360 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #184 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 70524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70524 Bug 11897: Add bulk of Stockrotation module. Review of attachment 70524: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=118…) ----------------------------------------------------------------- ::: api/v1/swagger/paths.json @@ +26,5 @@ > "/illrequests": { > "$ref": "paths/illrequests.json#/~1illrequests" > + }, > + "/rotas/{rota_id}/stages/{stage_id}/position": { > + "$ref": "paths/rotas.json#/~1rotas~1{rota_id}~1stages~1{stage_id}~1position" 8) Not commenting on the API specifically, but I think this will need more work as there has been a lot of changes since this part was written. ::: installer/data/mysql/userflags.sql @@ +19,4 @@ > (19, 'plugins', 'Koha plugins', '0'), > (20, 'lists', 'Lists', 0), > (21, 'clubs', 'Patron clubs', '0'), > +(22,'ill','The Interlibrary Loans Module',0), 9) Not related to these patches - maybe a leftover from a rebase/merge? ::: koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc @@ +40,4 @@ > [% IF ( issuehistoryview ) %]<li class="active">[% ELSE %]<li>[% END %] > <a href="/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=[% biblio_object_id | url %]" >Checkout history</a></li> > [% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=[% biblio_object_id | url %]">Modification log</a> </li>[% END %] > +[% IF ( CAN_user_stockrotation_can_add_items_rotas && Koha.Preference('StockRotation') ) %][% IF ( stockrotationview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/catalogue/stockrotation.pl?biblionumber=[% biblio_object_id %]">Rota</a> </li>[% END %] 9) Here user_stockrotation_can_add_items_rotas is asked, but stockrotation.pl asks for catalogue => 1 ? ::: koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc @@ +110,5 @@ > [%- CASE 'edit_templates' -%]<span>Create and edit club templates</span> > [%- CASE 'enroll' -%]<span>Enroll patrons in clubs</span> > [%- CASE 'edi_manage' -%]<span>Manage EDIFACT transmissions</span> > + [%- CASE 'can_add_items_rotas' -%]<span>Add and remove items from rotas</span> > + [%- CASE 'can_edit_rotas' -%]<span>Create, edit and delete rotas</span> 10) Ha! Fixes 5) ::: koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc @@ +4,5 @@ > + $(document).ready(function() { > + var path = location.pathname.substring(1); > + if (path.indexOf("labels") >= 0 && path.indexOf("spine") < 0 ) { > + $('#navmenulist a[href$="/cgi-bin/koha/labels/label-home.pl"]').css('font-weight','bold'); > + } else if (path.indexOf("patroncards") >= 0 ) { 11) This JavaScript block appears unrelated to the stock rotation feature? ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ +868,4 @@ > yes: Enable > no: Disable > - "housebound module" > + Stock Rotation module: 12) Capitalization: Stock rotation ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt @@ +4,5 @@ > +<title>Koha &rsaquo; Catalog &rsaquo; Stock rotation details for [% biblio.title %]</title> > +[% INCLUDE 'doc-head-close.inc' %] > +[% INCLUDE 'browser-strings.inc' %] > +<!--[if lt IE 9]> > +<script type="text/javascript" src="[% interface %]/lib/shims/json2.min.js"></script> 13) All .js files referenced need version variable added (see bug 12904) @@ +37,5 @@ > + <table class="items_table dataTable no-footer" role="grid"> > + <thead> > + <tr> > + <th>Barcode</th> > + <th>Shelfmark</th> 14) Shelfmark is not a term used in Koha, should be callnumber. @@ +58,5 @@ > + [% IF item.rota %] > + [% IF !item.rota.active %] > + <span class="highlighted-row"> > + [% END %] > + [% item.rota.active ? 'Active' : 'Inactive' %] 15) Please check if this construct is translatable! ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt @@ +3,5 @@ > +[% USE KohaDates %] > +[% INCLUDE 'doc-head-open.inc' %] > +<title>Koha &rsaquo; Stock rotation</title> > +[% INCLUDE 'doc-head-close.inc' %] > +<link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> 16) Same as for JavaScript files - needs version added (see bug 12904) @@ +247,5 @@ > + <form id="stage_form" method="post" enctype="multipart/form-data" class="validated"> > + <fieldset class="rows"> > + <ol> > + <li> > + <label class="required" for="branch">Branch:</label> 17) Please always prefer 'library' to 'branch' (see terminology page on the wiki) @@ +349,5 @@ > + <thead> > + <th>Barcode</th> > + <th>Title</th> > + <th>Author</th> > + <th>Shelfmark</th> 18) See above - use callnumber instead. ::: misc/cronjobs/stockrotation.pl @@ +217,5 @@ > + my $header = ""; > + my $body = ""; > + # Summary > + $header .= sprintf " > +STOCKROTATION REPORT 19) This hardcoded report is not translatable- appears to apply to the email as well? Please consider moving this into a proper notice template. ::: tools/stockrotation.pl @@ +50,5 @@ > + { > + template_name => 'tools/stockrotation.tt', > + query => $input, > + type => 'intranet', > + authnotrequired => 0 20) No permission checks? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new JavaScript and CSS files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Force browser to load new |Force browser to load new |javascript files after |JavaScript and CSS files |upgrade |after upgrade -- You are receiving this mail because: You are watching all bug changes.

1 0