February 2018 - Koha-bugs - lists.koha-community.org

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen(a)joensuu.fi --- Comment #60 from paxed <pasi.kallinen(a)joensuu.fi> --- (In reply to Jesse Weaver from comment #57) > Created attachment 70974 [details] [review] > Bug 15395: Example usage of I18N Template::Toolkit plugin > > Moved this patch for example usage to teh end of patch set > and resolved minor conflict while applyin > Signed-off-by: Marc Véron <veron(a)veron.ch> I'm confused by this example. How does the msgid look like in the po-file? msgid "item" msgid_plural "items" Like that? If so, then that's a bad example, as it's basically the same as concatenating number + "item" The number placeholder should be included in the translatable string, so the msgid looks like this: msgid "one item" msgid_plural "%s items" Because the translator can then actually make it sound natural in their own language - perhaps the language needs an article before the number, or a suffix to the number, both of which would be impossible to do with the original example. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15510] New professional cataloguing editor shows OPAC favicon
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15510 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #5 from David Cook <dcook(a)prosentient.com.au> --- I had some interesting favicon experiences on Bug 20173. Maybe it's related? I think sometimes the browser tries to be too smart for its own good... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18760 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19360 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #184 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 70524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70524 Bug 11897: Add bulk of Stockrotation module. Review of attachment 70524: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=118…) ----------------------------------------------------------------- ::: api/v1/swagger/paths.json @@ +26,5 @@ > "/illrequests": { > "$ref": "paths/illrequests.json#/~1illrequests" > + }, > + "/rotas/{rota_id}/stages/{stage_id}/position": { > + "$ref": "paths/rotas.json#/~1rotas~1{rota_id}~1stages~1{stage_id}~1position" 8) Not commenting on the API specifically, but I think this will need more work as there has been a lot of changes since this part was written. ::: installer/data/mysql/userflags.sql @@ +19,4 @@ > (19, 'plugins', 'Koha plugins', '0'), > (20, 'lists', 'Lists', 0), > (21, 'clubs', 'Patron clubs', '0'), > +(22,'ill','The Interlibrary Loans Module',0), 9) Not related to these patches - maybe a leftover from a rebase/merge? ::: koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc @@ +40,4 @@ > [% IF ( issuehistoryview ) %]<li class="active">[% ELSE %]<li>[% END %] > <a href="/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=[% biblio_object_id | url %]" >Checkout history</a></li> > [% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=[% biblio_object_id | url %]">Modification log</a> </li>[% END %] > +[% IF ( CAN_user_stockrotation_can_add_items_rotas && Koha.Preference('StockRotation') ) %][% IF ( stockrotationview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/catalogue/stockrotation.pl?biblionumber=[% biblio_object_id %]">Rota</a> </li>[% END %] 9) Here user_stockrotation_can_add_items_rotas is asked, but stockrotation.pl asks for catalogue => 1 ? ::: koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc @@ +110,5 @@ > [%- CASE 'edit_templates' -%]<span>Create and edit club templates</span> > [%- CASE 'enroll' -%]<span>Enroll patrons in clubs</span> > [%- CASE 'edi_manage' -%]<span>Manage EDIFACT transmissions</span> > + [%- CASE 'can_add_items_rotas' -%]<span>Add and remove items from rotas</span> > + [%- CASE 'can_edit_rotas' -%]<span>Create, edit and delete rotas</span> 10) Ha! Fixes 5) ::: koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc @@ +4,5 @@ > + $(document).ready(function() { > + var path = location.pathname.substring(1); > + if (path.indexOf("labels") >= 0 && path.indexOf("spine") < 0 ) { > + $('#navmenulist a[href$="/cgi-bin/koha/labels/label-home.pl"]').css('font-weight','bold'); > + } else if (path.indexOf("patroncards") >= 0 ) { 11) This JavaScript block appears unrelated to the stock rotation feature? ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ +868,4 @@ > yes: Enable > no: Disable > - "housebound module" > + Stock Rotation module: 12) Capitalization: Stock rotation ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt @@ +4,5 @@ > +<title>Koha &rsaquo; Catalog &rsaquo; Stock rotation details for [% biblio.title %]</title> > +[% INCLUDE 'doc-head-close.inc' %] > +[% INCLUDE 'browser-strings.inc' %] > +<!--[if lt IE 9]> > +<script type="text/javascript" src="[% interface %]/lib/shims/json2.min.js"></script> 13) All .js files referenced need version variable added (see bug 12904) @@ +37,5 @@ > + <table class="items_table dataTable no-footer" role="grid"> > + <thead> > + <tr> > + <th>Barcode</th> > + <th>Shelfmark</th> 14) Shelfmark is not a term used in Koha, should be callnumber. @@ +58,5 @@ > + [% IF item.rota %] > + [% IF !item.rota.active %] > + <span class="highlighted-row"> > + [% END %] > + [% item.rota.active ? 'Active' : 'Inactive' %] 15) Please check if this construct is translatable! ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt @@ +3,5 @@ > +[% USE KohaDates %] > +[% INCLUDE 'doc-head-open.inc' %] > +<title>Koha &rsaquo; Stock rotation</title> > +[% INCLUDE 'doc-head-close.inc' %] > +<link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> 16) Same as for JavaScript files - needs version added (see bug 12904) @@ +247,5 @@ > + <form id="stage_form" method="post" enctype="multipart/form-data" class="validated"> > + <fieldset class="rows"> > + <ol> > + <li> > + <label class="required" for="branch">Branch:</label> 17) Please always prefer 'library' to 'branch' (see terminology page on the wiki) @@ +349,5 @@ > + <thead> > + <th>Barcode</th> > + <th>Title</th> > + <th>Author</th> > + <th>Shelfmark</th> 18) See above - use callnumber instead. ::: misc/cronjobs/stockrotation.pl @@ +217,5 @@ > + my $header = ""; > + my $body = ""; > + # Summary > + $header .= sprintf " > +STOCKROTATION REPORT 19) This hardcoded report is not translatable- appears to apply to the email as well? Please consider moving this into a proper notice template. ::: tools/stockrotation.pl @@ +50,5 @@ > + { > + template_name => 'tools/stockrotation.tt', > + query => $input, > + type => 'intranet', > + authnotrequired => 0 20) No permission checks? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new JavaScript and CSS files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Force browser to load new |Force browser to load new |javascript files after |JavaScript and CSS files |upgrade |after upgrade -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20222] New: The bread crumb for cleanborrowers.pl does not match the link text in tools-home.pl
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20222 Bug ID: 20222 Summary: The bread crumb for cleanborrowers.pl does not match the link text in tools-home.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In Home › Tools (tools/tools-home.pl), the link to the patron batch deletion tool is Batch patron deletion/anonymization When you click into the page, the breadcrumb says Home › Tools › Clean Patron Records The breadcrumb should match the link text. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #183 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 70521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70521 Bug 11897: Add Stock Rotation atomic update schema. Review of attachment 70521: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=118…) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/stockrot_tables.sql @@ +6,5 @@ > + description text NOT NULL default '', -- Description for this rota > + cyclical tinyint(1) NOT NULL default 0, -- Should items on this rota keep cycling? > + active tinyint(1) NOT NULL default 0, -- Is this rota currently active? > + PRIMARY KEY (`rota_id`) > +) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; 2) Should now be: ... ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; (see bug 18336) ::: installer/data/mysql/kohastructure.sql @@ +4156,5 @@ > + description text NOT NULL default '', -- Description for this rota > + cyclical tinyint(1) NOT NULL default 0, -- Should items on this rota keep cycling? > + active tinyint(1) NOT NULL default 0, -- Is this rota currently active? > + PRIMARY KEY (`rota_id`) > +) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; 3) Same here as above: ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; ::: installer/data/mysql/sysprefs.sql @@ +601,5 @@ > ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'), > ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'), > +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'), > +('StockRotation','0',NULL,'If ON, enables the stock rotation module','YesNo'), > +('RotationPreventTransfers','0',NULL,'If ON, prevent any transfers for items on stock rotation rotas, except for stock rotation transfers','YesNo') 4) Preferences in this file are sorted alphabetically, please move into the right spot. ::: koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc @@ +21,4 @@ > [%- CASE 'lists' -%]<span>Lists</span> > [%- CASE 'clubs' -%]<span>Patron clubs</span> > [%- CASE 'ill' -%]<span>Create and modify Interlibrary loan requests</span> > + [%- CASE 'stockrotation' -%]<span>Manage stockrotation operations</span> 5) Descriptions for the sub-permissions appear to be missing? ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ +879,5 @@ > + - pref: RotationPreventTransfers > + choices: > + yes: Enable > + no: Disable > + - "Prevent branchtransfers on items in stockrotation rotas" 6) These preferences don't form sentences and are not nicely formatted. Please avoid use of 'branch' in favor of 'library'. Also, should it be stock rotation or stockrotation? Both are used here. It should probably be something like: - yes: Enable - no: Disable - "library transfers on items in stockrotation rotas." -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #182 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I've tried to get these patches to apply, but I'd like a proper rebase. 1) Database update doesn't work DEV atomic update: stockrot_tables.sql C4::Installer::load_sql returned the following errors while attempting to load /home/vagrant/kohaclone/installer/data/mysql/atomicupdate/stockrot_tables.sql: Will continue comments using splinter. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20237] New: Don't allow adding same user multiple times to be notified on receive
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20237 Bug ID: 20237 Summary: Don't allow adding same user multiple times to be notified on receive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org To test: - create a basket - add an order line - try to add the same user to be notified on receive multiple times Probably same fix as for bug 20148 can be implemented here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2