February 2018 - Koha-bugs - lists.koha-community.org

[Bug 9290] Restricting patron category for online purchase suggestion
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 Amit Gupta <amitddng135(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #103 from Charles Farmer <charles.farmer(a)inlibro.com> --- Much tighter patches this time, thanks to Mark's comments. I'll review the changes one by one: 1) members/moremember.pl was adapted to reduce the diff's length. In previous iterations, many additional variables were passed to the templates -- borrowernumber, othernames, etc. -- but these are not necessary anymore, thanks to the patron objects. The template moremember-brief.tt was adapted to reflect these changes. 2) borrowers_primary_contact_method.sql is now adding columns at the very end of the table, in order to keep the existing columns in the same order. 3) `lastseen` had no reason whatsoever to be here. Kept the field the way it already was in the tables where we added primary_contact_method. 4) whitespace changes were rolled back, according to the minimum diff policy(TM) 5) I'm definitely responsible for the moremember.tt screwup code duplication; it appeared in patch #69028 when I must've rebased. It's now removed from this patch. 6) Indentation was corrected in opac-memberentry.pl This code should also pass qa -c 4. Needs signoff. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new JavaScript and CSS files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #113 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Could anyone explain (again) why we choose to append the version to the filename and not in parameter? So basically why: /my/file_[% KOHA_VERSION %].js and not: /my/file.js?version=[% KOHA_VERSION %] Kyle and Martin talked about the two approaches earlier in comments (from comment 4) but I do not understand. Please clarify. It could avoid the rewrite rules. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #102 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 71958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71958&action=ed… Bug 11879: Follow-up - code review -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69050|0 |1 is obsolete| | --- Comment #101 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 71957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71957&action=ed… Bug 11879: Follow-up - Streamline markup and make label corrections This patch makes minor markup corrections to the patron detail page template: - Simplify the SWITCH markup - Add "primary" to primary phone label - Correct case on label - Add IF statement to hide label if there is no primary contact method -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69029|0 |1 is obsolete| | --- Comment #100 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 71956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71956&action=ed… Bug 11879: Changes to Koha's schemas -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69028|0 |1 is obsolete| | --- Comment #99 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 71955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71955&action=ed… Bug 11879: Add the "Main contact method" field in borrower informations. This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Following Nicolas' fix, removed a $branch variable from patch, since it has been suppressed in Bug 17284. Test case : * Edit a borrower's informations. The "Main Contact Method" selectbox should appear in the form and its value should be saved correctly. Sponsored-by: CCSR <http://www.ccsr.qc.ca> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #74 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71952&action=ed… Bug 15395: Fix for libintl-perl >= 1.25 Since 1.25, LANGUAGE environment variable is ignored unless LANG is set to a valid locale. This patch sets LANG to a valid locale and calls setlocale. If no valid locale can be found, a warning message is written in logs. See https://rt.cpan.org/Public/Bug/Display.html?id=81315 and also https://github.com/gflohr/libintl-perl/commit/5910980b6e -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #73 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71951&action=ed… Bug 15395: Improve TT plugin example Include the number in the translatable string -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70976|0 |1 is obsolete| | --- Comment #72 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71950&action=ed… Bug 15395: Remove the use of Locale::Util's set_locale -- You are receiving this mail because: You are watching all bug changes.

1 0