March 2018 - Koha-bugs - lists.koha-community.org

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #48 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- There is something wrong with commit d6e8e88249914531d8b01f35200de6a8a4692b89 Bug 15492: Make existing code aware of new self_check* permissions % prove t/db_dependent/Search/History.t t/db_dependent/Search/History.t .. 12/27 A context appears to have been destroyed without first calling release(). Based on $@ it does not look like an exception was thrown (this is not always a reliable test) This is a problem because the global error variables ($!, $@, and $?) will not be restored. In addition some release callbacks will not work properly from inside a DESTROY method. Here are the context creation details, just in case a tool forgot to call release(): File: t/db_dependent/Search/History.t Line: 478 Tool: Test::More::subtest Cleaning up the CONTEXT stack... # Test ended with extra hubs on the stack! # Looks like you planned 27 tests but ran 26. t/db_dependent/Search/History.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/27 subtests Test Summary Report ------------------- t/db_dependent/Search/History.t (Wstat: 65280 Tests: 26 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 27 tests but ran 26. Files=1, Tests=26, 2 wallclock secs ( 0.02 usr 0.01 sys + 1.09 cusr 0.82 csys = 1.94 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #47 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I have added a fix for koha-misc4dev: commit 4fd7e11bab2da7bc4601f3c5591141366acbef30 Fix insert_data.pl for self_checkout permission -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20459] New: Correct message for cancelling an article request
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20459 Bug ID: 20459 Summary: Correct message for cancelling an article request Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Cancel this hold was just copied/pasted with a TODO ;) -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 20438] New: Allow uninstalling plugins not implementing the 'uninstall' method
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20438 Bug ID: 20438 Summary: Allow uninstalling plugins not implementing the 'uninstall' method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The plugins handling code expects plugins implementing an 'uninstall' method for cleanup purposes. It executes this method, and then moves on with removing the configuration entries in the storage, and the plugin itself. But the 'plugins-home.tt' template makes the tool display the 'Uninstall' link in the dropdown ONLY when the plugin has the 'uninstall' method. This is incorrect! To reproduce: - Install the KitchenSink plugin [1] => SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option - Edit the code for the plugin: $ sudo vim /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm - Remove the uninstall sub - Restart everything: $ restart_all - Reload the browser => FAIL: There's no 'Uninstall' option in the actions dropdown. [1] https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 20433] New: Remove unused Mozilla Persona image file
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20433 Bug ID: 20433 Summary: Remove unused Mozilla Persona image file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org When Mozilla Persona was removed in Bug 17486, an image file was left behind: sign_in_green.png. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 20422] New: Working title
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 Bug ID: 20422 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 20345] New: Put saved report keyword search form on reports home
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345 Bug ID: 20345 Summary: Put saved report keyword search form on reports home Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Reports Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org We have a quick search form for system preferences on the administration page. I think we should have the same on the reports home page for saved reports. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 20111] New: Patron card creator - some strings are not translatable
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Bug ID: 20111 Summary: Patron card creator - some strings are not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor.grousset(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Hopefully at least 80% of the fixes and 70% of the test plan of bug 19522 will be reusable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 20085] New: Better translatability of smart-rules.tt
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085 Bug ID: 20085 Summary: Better translatability of smart-rules.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Template smart-rules.tt in administration contains some if/elsif/else with translatable strings. For example : [% IF rule.onshelfholds == 1 %] Yes [% ELSIF rule.onshelfholds == 2 %] If all unavailable [% ELSE %] If any unavailable [% END %] Adding span to translatable strings will allow to have the same translation than : <select name="onshelfholds" id="onshelfholds"> <option value="1">Yes</option> <option value="0">If any unavailable</option> <option value="2">If all unavailable</option> </select> This is important to allow editing an existing circulation and fine rule. Actually for example in french some strings are translated differently : msgid "%s Yes %s If all unavailable %s If any unavailable %s" msgstr "%s Oui %s Si tous indisponibles %s Si aucun indisponible %s" msgid "If any unavailable" msgstr "Si au moins un exemplaire est indisponible" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 19961] New: Move template JavaScript to the footer: Patron card creator
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19961 Bug ID: 19961 Summary: Move template JavaScript to the footer: Patron card creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for patron card creator templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 7