March 2018 - Koha-bugs - lists.koha-community.org

[Bug 19646] New: value_builder marc21_linking_section template is broken
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646 Bug ID: 19646 Summary: value_builder marc21_linking_section template is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When using marc21_linking_section cataloging plugin, you get the error : Template process failed: undef error - The method selected is not covered by tests! at /home/koha/src/C4/Templates.pm line 122. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com Status|Needs Signoff |Failed QA --- Comment #35 from Josef Moravec <josef.moravec(a)gmail.com> --- I can't even add an item without collection code after last patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20328] New: White margin at the top of the home page of the staff client
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20328 Bug ID: 20328 Summary: White margin at the top of the home page of the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: alexbuckley(a)catalyst.net.nz Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com There is a 13px high white margin at the top of the home page of the Koha staff client. After doing a git bisect I found that this bug was introduced in the patch for bug 19981 with the following addition to staff-global.css: .main { margin-top: 1em; } -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #55 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Josef Moravec from comment #54) > Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Great. Thx Josef -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #54 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72404&action=ed… Bug 14769: (Follow-up) Let blinddetail look at indicator values If the indicators are not controlled, blinddetail should not overwrite what the user already entered. Very strictly seen, we could say that it is outside the scope. But it is strongly related. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested with 100 and 600 in the cataloging editor. For 100 the second indicator should not be overwritten. For 600 it should. Also tested "ind2:" which should blank ind2. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #53 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72403&action=ed… Bug 14769: (Follow-up) Reduce number of preference parses In sub merge the Koha::Authority object was already created, so it was kind of silly to recreate it each time with new. In Koha::Authority, the ControlledIndicators object can be saved in the object too for reuse during its life time. Similarly, we prevent repeated lookups for the reporting tag (via authority type). Test plan: [1] Run t/db_dependent/Authority/Merge.t [2] Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Limited benchmarking shows me a reduction of 11% on Merge.t and a reduction of 4% on Authorities.t when comparing with and without this last patch. The larger impact on Merge.t could be expected. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #52 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72402&action=ed… Bug 14769: Put ControlledIndicators to work This patch does: [1] Adds Koha::Authority->controlled_indicators (with a test). [2] Adds a call to controlled_indicators in AuthoritiesMarc::merge. Unit test Merge.t is extended too. [3] Simplifies the code in authorities/blinddetail-biblio-search.pl by calling controlled_indicators. Test plan: [1] Run t/db_dependent/Koha/Authorities.t [2] Run t/db_dependent/Authority/Merge.t [3] Steps 3 to 7 for MARC21: Create a PERSO_NAME authority with 008/11=r and ind1=3 [4] Edit a biblio and add a 600 linked to the new authority. [5] Verify that the biblio has ind1==3 and ind2==7 and $2==aat. (If $2 is not visible, check the metadata in biblio_metadata.) [6] Edit the PERSO_NAME authority and change 008/11 to '|' (bar). [7] Verify that merge updated your biblio record: $ind2==4 and $2 gone. [8] UNIMARC: Follow the pattern from steps 3 to 7. Create authority, link it in a biblio, check indicators (they should be copied both). Edit authority, change indicators and verify the merge results in the biblio record. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested PERSO_NAME and UNIF_TITLE. For UNIF_TITLE the second authority indicator is copied to ind1 or ind2, depending on the biblio tag involved. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #51 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72401&action=ed… Bug 14769: Add preference AuthorityControlledIndicators Including: [1] Atomic update to add pref for existing installs [2] Add new pref to sysprefs.sql for new installs [3] Add description to authorities preference file. Test plan: [1] Run new install or upgrade to add pref. [2] Check value of pref via System preferences in staff interface. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #50 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72400&action=ed… Bug 14769: Add tests for _thesaurus_info in ControlledIndicators.t Apart from adding tests for this sub, we make the following change too and support it with a test. The fallback to $code in the construction $thes_mapping{ $code } // $code // '4' is removed by this patch. When $code is not in $thes_mapping, we cannot assume that it is a valid code for a biblio indicator. In this case it is more safe to mark it as 4 (Source not specified). Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #49 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72399&action=ed… Bug 14769: Biblio indicators based on authority's thesaurus code Original patch from Janusz Kaczmarek on November 24, 2017. Amended by Marcel de Rooy on February 6, 2018. Code moved from AuthoritiesMarc.pm to ControlledIndicators.pm. Special attention has been paid to the proper application of 008/11 while controlling 6XX in MARC 21, specially if 008/11 =~ /[rsz]/ (and if it is 'z' and 040 $f is defined). Test plan: See next patch. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> The construction $thes_mapping{ $code } // $code // '4' will still get some attention on a follow-up. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0