April 2018 - Koha-bugs - lists.koha-community.org

[Bug 20259] New: Shorter JS and CSS rewrite rule
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '18

18 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Bug ID: 20259 Summary: Shorter JS and CSS rewrite rule Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Bug 20187 has changed the JS and CSS rewrite rules to : RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L] RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css [L] This can be written more short with one rule and [0-9]{N}. And the dot in extension needs to be escaped : \.js \.css -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 20325] New: C4::Accounts::purge_zero_balance_fees does not check account_offsets.
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '18

18 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Bug ID: 20325 Summary: C4::Accounts::purge_zero_balance_fees does not check account_offsets. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org purge_zero_balance_fees is used in cleanup_database.pl to determine which fees can be cleaned up. It uses a simple SQL query to determine which rows in accountlines need to be removed: 463 my $sth = $dbh->prepare( 464 q{ 465 DELETE FROM accountlines 466 WHERE date < date_sub(curdate(), INTERVAL ? DAY) 467 AND ( amountoutstanding = 0 or amountoutstanding IS NULL ); 468 } The function comes with the following warning: 451 B<Warning:> Because fines and payments are not linked in accountlines, it is 452 possible for a fine to be deleted without the accompanying payment, 453 or vise versa. This won't affect the account balance, but might be 454 confusing to staff. This was a reasonable solution prior to the addition of account_offsets in 17.11. The problem now is that rows in accountlines which are linked as credits in accountlines will *always* have amountoutstanding marked as 0. These are linked to debits via account_offsets. purge_zero_balance_fees will delete credits and leave rows in account_offsets which link to deleted credits. Sites using the --fees option cleanup_database.pl which upgrade to 17.11 may have all of their credits removed without warning. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 20240] New: Remove space before : when searching for a vendor in serials (Vendor name :)
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '18

18 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20240 Bug ID: 20240 Summary: Remove space before : when searching for a vendor in serials (Vendor name :) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When creating a new subscription and searching for a vendor, the search field is labelled "Vendor name :". Fix tiny inconsistency by removing the space after before :. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 20556] New: Marking ILL request as complete results in "Internal server error"
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '18

18 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20556 Bug ID: 20556 Summary: Marking ILL request as complete results in "Internal server error" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com Moving an ILL request through the workflow to the point of marking it complete results in an error. This bug manifests itself in different ways depending on whether the Koha instance is running Plack or not. Upon marking a request as complete, Plack installations see an "Internal server error" in the browser, whereas non-Plack installations see no error and everything seems to work fine. In both cases, however, the following error appears in the error log: ill-requests.pl: Template process failed: file error - : not found at /usr/share/koha/C4/Templates.pm line 122.: /usr/share/koha/ill/ill-requests.pl, referer: http://myserver.com/cgi-bin/koha/ill/ill-requests.pl?method=illview&illrequ… -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 20001] New: ILL: Adding a 'new request' from OPAC is not possible
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '18

18 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Bug ID: 20001 Summary: ILL: Adding a 'new request' from OPAC is not possible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de The button to add a 'new request' from the OPAC doesn't work, it doesn't matter if there is one or multiple backends installed: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?method=create&backen… Internal server error Can't locate Koha/Illbackends/ARRAY(0xb154640)/Base.pm in @INC (you may need to install the Koha::Illbackends::ARRAY(0xb154640)::Base module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer /home/vagrant/kohaclone/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at /home/vagrant/kohaclone/Koha/Illrequest.pm line 153. When there are mulitple backends installed the button is a menu on the staff side that lets you pick, what you want to do. I think the same should probably happen on the OPAC. Marking critical for ILL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 37

[Bug 19773] New: Illrequests.t raises a warning
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '18

18 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19773 Bug ID: 19773 Summary: Illrequests.t raises a warning Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 7317 Use of uninitialized value $backend_dir in join or string at /kohadevbox/koha/Koha/Illrequest.pm line 664. [13:35:38] t/db_dependent/Illrequests.t ................................... ok 3376 ms Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 20612] New: Make OAuth2 use patron's client_id/secret pairs
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '18

18 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 Bug ID: 20612 Summary: Make OAuth2 use patron's client_id/secret pairs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Bug 20568 implements a way to define client_id/secret API keys for patrons. We should use those instead of the hardcoded ones in koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 48

[Bug 19541] New: Remove notifiactiondate and reminderdate from reserves/ old_reserves tables
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '18

18 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19541 Bug ID: 19541 Summary: Remove notifiactiondate and reminderdate from reserves/old_reserves tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We do not use these two columns for anything... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 20539] New: Warnings in catalogue/search.pl need to be removed
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '18

18 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Bug ID: 20539 Summary: Warnings in catalogue/search.pl need to be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 19995 Use of uninitialized value $template_type in string eq at /home/vagrant/kohaclone/catalogue/search.pl line 273. Use of uninitialized value $limit_cgi in split at /home/vagrant/kohaclone/catalogue/search.pl line 496. Use of uninitialized value $total in addition (+) at /home/vagrant/kohaclone/catalogue/search.pl line 541. Use of uninitialized value $limit_cgi_not_availablity in substitution (s///) at /home/vagrant/kohaclone/catalogue/search.pl line 590. Use of uninitialized value $gotonumber in string eq at /home/vagrant/kohaclone/catalogue/search.pl line 706. Use of uninitialized value $gotonumber in string eq at /home/vagrant/kohaclone/catalogue/search.pl line 706. Use of uninitialized value $gotopage in pattern match (m//) at /home/vagrant/kohaclone/catalogue/search.pl line 711. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 [Bug 19995] use Modern::Perl in Catalogue perl scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 19234] New: Add query parameters handling helpers
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '18

18 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Bug ID: 19234 Summary: Add query parameters handling helpers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org In order to ease endpoint writing, we need a common (and fully tested) way of dealing with two things: - Extract pagination controlling params from the query params and create the right pagination setup for Koha::Objects - Generate the right DBIC query for the passed params -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 49