April 2018 - Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #61 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 72883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72883 Bug 12446 - Enable an adult to have a guarantor Review of attachment 72883: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=124…) ----------------------------------------------------------------- Hi Roch, I've done some initial review, but I am not quite happy with this as is. The biggest problem I see is that it does much more than the bug title advertises. The flag on patron categories and the new preference to decide which patron fields to copy should have been at least 2 bugs. There is also changes to the display like displaying the account balance (which should probably use Price TT?). Please consider splitting the bug when working on it again. 1) QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/guarantor_search.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 20) 2) Spinter review: ::: installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql @@ +6,5 @@ > + > +-- ********* -- > +-- STRUCTURE -- > +-- ********* -- > +ALTER TABLE categories ADD COLUMN `canbeguarantee` tinyint(1) NOT NULL default '0'; Please use AFTER to declare where the column should be added to match with the kohastructure statement. Because depending on when this is pushed, it might lead to a different database structure between new and old installations otherwise. ::: installer/data/mysql/kohastructure.sql @@ +303,4 @@ > `hidelostitems` tinyint(1) NOT NULL default '0', -- are lost items shown to this category (1 for yes, 0 for no) > `category_type` varchar(1) NOT NULL default 'A', -- type of Koha patron (Adult, Child, Professional, Organizational, Statistical, Staff) > `BlockExpiredPatronOpacActions` tinyint(1) NOT NULL default '-1', -- wheither or not a patron of this category can renew books or place holds once their card has expired. 0 means they can, 1 means they cannot, -1 means use syspref BlockExpiredPatronOpacActions > + `default_privacy` ENUM( 'default', 'never', 'forever' ) NOT NULL DEFAULT 'default', -- Default privacy setting for this patron category, This change is not necessary, no comma needed after the comment. ::: installer/data/mysql/sysprefs.sql @@ +6,5 @@ > ('AcquisitionDetails', '1', '', 'Hide/Show acquisition details on the biblio detail page.', 'YesNo'), > ('AcqViewBaskets','user','user|branch|all','Define which baskets a user is allowed to view: his own only, any within his branch or all','Choice'), > ('AcqWarnOnDuplicateInvoice','0','','Warn librarians when they try to create a duplicate invoice','YesNo'), > +('AdditionalGuarantorField','',NULL,'Additional fields name to be transfer from guarantor to guarantee.','free'), > +('AddPatronLists','categorycode','categorycode|category_type','Allow user to choose what list to pick up from when adding patrons','Choice'), Change to AddPatronLists seems misplaced here. ::: koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc @@ +8,4 @@ > <label for="streetnumber"> > [% END %] > Street number: </label> > + <input type="text" id="streetnumber" name="streetnumber" size="5" value="[% streetnumber %]" /> Why only changes to the ...style-us and not the other templates? ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ +154,3 @@ > [% IF logged_in_user.can_see_patron_infos( guarantee ) %] > + <td><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% guarantee.borrowernumber %]">[% guarantee.firstname | html %] [% guarantee.surname | html %]</a></td> > + <td style='text-align:right'>[% guarantee.account.balance %]</td> What has this to do with making it possible for adults to be guarantors? ;) ::: members/moremember.pl @@ +209,5 @@ > + } > + $template->param( guarantees => @guarantees); > + $template->param( amounttot => sprintf("%.2f",$totalmount)); > +} > +( $template->param( adultborrower => 1 ) ) if ( $category_type eq 'A' || $category_type eq 'I' ); If we set it on the patron category, why check here for I and A? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #204 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Please rebase and check for changed needed! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #97 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch doesn't apply, please rebase and check for changes needed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11674] Configuration for MARC field doc URLs
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73594|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 74196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74196&action=ed… Bug 11674: Configuration for MARC field doc URLs Add a new system preference MarcFieldDocURL. Setting it to some URL will make all the MARC documentation links point to that in the MARC edit UI. Leaving the value empty will use the old defaults (http://loc.gov for MARC21 and http://archive.ifla.org for UNIMARC). There are some possible substitutions usable in the URL: - {MARC} is replaced with either "MARC21" or "UNIMARC" - {FIELD} is replaced by the MARC field number, eg. "000", "048", ... - {LANG} is replaced by the UI language, eg. "en", or "fi-FI" To test: 1) Go to Cataloguing > New record 2) Clicking on the question mark links in the MARC edit will open a window to either loc.gov or archive.ifla.org 3) Install patch, run updatedatabase, etc 4) Redo parts 1, and 2. 5) Set the value of MarcFieldDocURL to http://example.com/?field={FIELD}&marc={MARC}&lang={LANG} 6) Redo parts 1 and 2 7) Clicking on the question mark links in the MARC edit will open a window to example.com, with the proper substitutions in the URL for the field, marc flavour and language Signed-off-by: Pasi Kallinen <pasi.kallinen(a)joensuu.fi> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11674] Configuration for MARC field doc URLs
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18202 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #69 from David Cook <dcook(a)prosentient.com.au> --- I was just thinking about https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18202 and how it really relates to this... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add important constraint to |Add important constraint to |marc tags and subfields |MARC tags and subfields -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8484] Add ability to choose if lost items are removed from a borrowers record.
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19974 -- You are receiving this mail because: You are watching all bug changes.

1 0