April 2018 - Koha-bugs - lists.koha-community.org

[Bug 11674] Configuration for MARC field doc URLs
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73594|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 74196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74196&action=ed… Bug 11674: Configuration for MARC field doc URLs Add a new system preference MarcFieldDocURL. Setting it to some URL will make all the MARC documentation links point to that in the MARC edit UI. Leaving the value empty will use the old defaults (http://loc.gov for MARC21 and http://archive.ifla.org for UNIMARC). There are some possible substitutions usable in the URL: - {MARC} is replaced with either "MARC21" or "UNIMARC" - {FIELD} is replaced by the MARC field number, eg. "000", "048", ... - {LANG} is replaced by the UI language, eg. "en", or "fi-FI" To test: 1) Go to Cataloguing > New record 2) Clicking on the question mark links in the MARC edit will open a window to either loc.gov or archive.ifla.org 3) Install patch, run updatedatabase, etc 4) Redo parts 1, and 2. 5) Set the value of MarcFieldDocURL to http://example.com/?field={FIELD}&marc={MARC}&lang={LANG} 6) Redo parts 1 and 2 7) Clicking on the question mark links in the MARC edit will open a window to example.com, with the proper substitutions in the URL for the field, marc flavour and language Signed-off-by: Pasi Kallinen <pasi.kallinen(a)joensuu.fi> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11674] Configuration for MARC field doc URLs
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18202 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #69 from David Cook <dcook(a)prosentient.com.au> --- I was just thinking about https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18202 and how it really relates to this... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add important constraint to |Add important constraint to |marc tags and subfields |MARC tags and subfields -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8484] Add ability to choose if lost items are removed from a borrowers record.
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19974 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opac-detail.pl -- Series |Correctly URI-encode URLs |link fails when series |in XSLT result lists and |title ends with semicolon |detail pages |preceded by space | Status|Needs Signoff |Failed QA --- Comment #36 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Ere, you tend to create quite big patch sets - often it's better to split things up a bit to ease testing. That will make it easier for sign-offers. For example you could have one patch for MARC21 and one for UNIMARC here. NORMARC might not be necessary, as of bug 18984. >From testing (MARC21): 1) URLs to external sources are broken at least in intranet result an detail page: Example: http://localhost:8081/cgi-bin/koha/catalogue/http%3A%2F%2Fwww.loc.gov%2Fcat… 2) Shoudl the comma behind publisher not be encoded? http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=Provider:%22Vintag… Record is from the sample data: Opus posthumous / by Wallace Stevens. Can you please check? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #68 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 73583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73583 Bug 14570 - Make it possible to add multiple guarantors to a record Review of attachment 73583: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=145…) ----------------------------------------------------------------- Hi Kyle, this is a huge patch with several consequences. Lots to test. Not nearly done yet. 1) Release notes Should state consequences to: - patron import (no change, but can only import with one guarantor?) - LDAP and SIP (lines where changed, but only in POD?) - patron REST API (guarantor information can't be changed or asked for) - Reports using borrowers.guarantorid have to be changed/rewritten ... 2) QA script FAIL opac/opac-user.pl FAIL valid "my" variable $patron masks earlier declaration in same scope FAIL Koha/Patron/Relationships.pm FAIL pod Spurious =cut command *** ERROR: in file Koha/Patron/Relationships.pm FAIL pod coverage POD is missing for 'object_class' FAIL Koha/Patron.pm FAIL pod coverage POD is missing for 'has_permission' 3) New unit tests pass. 4) Tests in GUI Testing this, something doesn't seem to be quite right. a) I tried adding a guarantor from a Teacher (Professional) and from a Kid (Child) account. Both don't offer the form to me. b) Using the 'add child' from an existing patron (Adult), a new form opens for an adult patron category, the guarantor information is empty. 5) Code review (splinter): ::: Koha/Patron.pm @@ +119,5 @@ > > return scalar Koha::Patron::Images->find( $self->borrowernumber ); > } > > +=head3 library Please add a description here too, not just an empty entry. QA tools will be happy with this, but the missing POD never fixed. @@ +135,5 @@ > > +Returns the set of relationships for the patrons that are guarantors for this patron. > + > +This is returned instead of a Koha::Patron object because the guarantor > +may not exist as a patron in Koha. If this is true, the guarantors name This is quite a change - is it really implemented in this patch set? What's the use case? Just a name is not a lot to locate the person if needed. ::: koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc @@ -17,5 @@ > [% IF CAN_user_borrowers_edit_borrowers %] > [% IF patron.is_adult AND Koha.Preference("borrowerRelationship") %] > <a id="addchild" class="btn btn-default btn-sm" href="/cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=[% patron.borrowernumber %]"><i class="fa fa-plus"></i> Add child</a> > [% END %] > - [% IF CAN_user_borrowers_edit_borrowers %] This change doesn't look like it was intentional/related. Please check. -- You are receiving this mail because: You are watching all bug changes.

1 0