April 2018 - Koha-bugs - lists.koha-community.org

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #122 from Charles Farmer <charles.farmer(a)inlibro.com> --- Digging a bit further, the problem stemmed from patch ordering, and what looks like patch duplication after signoff. Changing the patch titles to adhere to the new naming convention must have confused git-bz attach. If you're unsure, you can diff the previous patch 1 against patch 5, idem for patch 2 and 6. I've submitted a new set of four patches, keeping those with the newest naming convention for clarity's sake, all the while making sure no changes were dropped. Should work exactly as before. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12123] HTML notices can break the notice viewer
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #35 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- The example Kyle suggested in comment26 is sufficient to demonstrate that this patch makes a difference. I recommend to restore PQA status and move the html check to a new report. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73988|0 |1 is obsolete| | --- Comment #121 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 74126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74126&action=ed… Bug 11879: Schema updates Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72635|0 |1 is obsolete| | Attachment #73990|0 |1 is obsolete| | --- Comment #120 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 74125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74125&action=ed… Bug 11879: (QA follow-up) Fix problems found in code review Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72634|0 |1 is obsolete| | Attachment #73989|0 |1 is obsolete| | --- Comment #119 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 74124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74124&action=ed… Bug 11879: (follow-up) Streamline markup and make label corrections This patch makes minor markup corrections to the patron detail page template: - Simplify the SWITCH markup - Add "primary" to primary phone label - Correct case on label - Add IF statement to hide label if there is no primary contact method Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73987|0 |1 is obsolete| | --- Comment #118 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 74123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74123&action=ed… Bug 11879: Add the "Main contact method" field in borrower informations. This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Following Nicolas' fix, removed a $branch variable from patch, since it has been suppressed in Bug 17284. Test case : * Edit a borrower's informations. The "Main Contact Method" selectbox should appear in the form and its value should be saved correctly. Sponsored-by: CCSR <http://www.ccsr.qc.ca> Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12123] HTML notices can break the notice viewer
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #34 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #32) > I'd like your opinions on this alternative patch. Can we add that test to saving the letter in tools/letter.pl ? I would rather test once if we saved valid HTML and not check every message in the queue. (In the assumption that we do not add invalid constructs during processing.) To be safe, we present it here in an iframe. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2711] No Holds on Lost Items
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2711 Hugh Rundle <hughr(a)brimbank.vic.gov.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hughr(a)brimbank.vic.gov.au --- Comment #3 from Hugh Rundle <hughr(a)brimbank.vic.gov.au> --- I think this is reasonably well answered here: >From the OPAC if hidelostitems is ON you cannot place a hold - but I guess >there are libraries that are displaying their lost items. Katrin's right that it should be a toggle, but effectively it already is. If you want people to see lost items then you probably want them to be able to place holds on records where all items are lost. And if you don't want them to do that, then you can just hide lost items. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '18

12 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #117 from Charles Farmer <charles.farmer(a)inlibro.com> --- It's unfortunate, but I'll just reapply an obsoleted set of patches to make this work. Changes coming in the next few hours. Really at lost about what happened here. -- You are receiving this mail because: You are watching all bug changes.

1 0