April 2018 - Koha-bugs - lists.koha-community.org

[Bug 12123] HTML notices can break the notice viewer
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #41 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 74169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74169&action=ed… Bug 12123 - Make iframe large enough to remove scroll bars -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20579] New: bulkmarcimport.pl fails with UNIMARC authorities but works with XML
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20579 Bug ID: 20579 Summary: bulkmarcimport.pl fails with UNIMARC authorities but works with XML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: nicolas.legrand(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Created attachment 74164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74164&action=ed… A unimarc authorities that doesn't work The .mrc file should be importable with Koha tools, but not with kohabulkmarc.pl. The .xml file is nicely imported with kohabulkmarc.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 12123] HTML notices can break the notice viewer
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- We are going to use iframe with a weird display (scrollbars) to catch possible malformed notices. I still do not like the solution. Something else to suggest? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12123] HTML notices can break the notice viewer
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12123] HTML notices can break the notice viewer
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74113|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12123] HTML notices can break the notice viewer
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #39 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #35) > The example Kyle suggested in comment26 is sufficient to demonstrate that > this patch makes a difference. I recommend to restore PQA status and move > the html check to a new report. Agreed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12123] HTML notices can break the notice viewer
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #38 from Kyle M Hall <kyle(a)bywatersolutions.com> --- It seems like the consensus is that the new alternative patch is not acceptable. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12123] HTML notices can break the notice viewer
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #37 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Katrin Fischer from comment #36) > Be careful with the check - HTML5 is not valid XML. Unclosed <p> tags are > perfectly valid. Often browsers are forgiving and probably mail clients too. > We don't want to break display in more cases than now, that will annoy the > libraries. Good call. In PHP, I used to use http://php.net/manual/en/book.tidy.php but that was pre-HTML5 I think. Might be worth looking for a HTML specific module? Also, I'm pretty sure XML::Simple is a bad choice of XML modules. The author of it even discourages its use. No one should ever use it again I reckon. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12123] HTML notices can break the notice viewer
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #36 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Be careful with the check - HTML5 is not valid XML. Unclosed <p> tags are perfectly valid. Often browsers are forgiving and probably mail clients too. We don't want to break display in more cases than now, that will annoy the libraries. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '18

13 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #123 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry, that was my fault then, didn't spot it! -- You are receiving this mail because: You are watching all bug changes.

1 0