April 2018 - Koha-bugs - lists.koha-community.org

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opac-detail.pl -- Series |Correctly URI-encode URLs |link fails when series |in XSLT result lists and |title ends with semicolon |detail pages |preceded by space | Status|Needs Signoff |Failed QA --- Comment #36 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Ere, you tend to create quite big patch sets - often it's better to split things up a bit to ease testing. That will make it easier for sign-offers. For example you could have one patch for MARC21 and one for UNIMARC here. NORMARC might not be necessary, as of bug 18984. >From testing (MARC21): 1) URLs to external sources are broken at least in intranet result an detail page: Example: http://localhost:8081/cgi-bin/koha/catalogue/http%3A%2F%2Fwww.loc.gov%2Fcat… 2) Shoudl the comma behind publisher not be encoded? http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=Provider:%22Vintag… Record is from the sample data: Opus posthumous / by Wallace Stevens. Can you please check? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #68 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 73583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73583 Bug 14570 - Make it possible to add multiple guarantors to a record Review of attachment 73583: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=145…) ----------------------------------------------------------------- Hi Kyle, this is a huge patch with several consequences. Lots to test. Not nearly done yet. 1) Release notes Should state consequences to: - patron import (no change, but can only import with one guarantor?) - LDAP and SIP (lines where changed, but only in POD?) - patron REST API (guarantor information can't be changed or asked for) - Reports using borrowers.guarantorid have to be changed/rewritten ... 2) QA script FAIL opac/opac-user.pl FAIL valid "my" variable $patron masks earlier declaration in same scope FAIL Koha/Patron/Relationships.pm FAIL pod Spurious =cut command *** ERROR: in file Koha/Patron/Relationships.pm FAIL pod coverage POD is missing for 'object_class' FAIL Koha/Patron.pm FAIL pod coverage POD is missing for 'has_permission' 3) New unit tests pass. 4) Tests in GUI Testing this, something doesn't seem to be quite right. a) I tried adding a guarantor from a Teacher (Professional) and from a Kid (Child) account. Both don't offer the form to me. b) Using the 'add child' from an existing patron (Adult), a new form opens for an adult patron category, the guarantor information is empty. 5) Code review (splinter): ::: Koha/Patron.pm @@ +119,5 @@ > > return scalar Koha::Patron::Images->find( $self->borrowernumber ); > } > > +=head3 library Please add a description here too, not just an empty entry. QA tools will be happy with this, but the missing POD never fixed. @@ +135,5 @@ > > +Returns the set of relationships for the patrons that are guarantors for this patron. > + > +This is returned instead of a Koha::Patron object because the guarantor > +may not exist as a patron in Koha. If this is true, the guarantors name This is quite a change - is it really implemented in this patch set? What's the use case? Just a name is not a lot to locate the person if needed. ::: koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc @@ -17,5 @@ > [% IF CAN_user_borrowers_edit_borrowers %] > [% IF patron.is_adult AND Koha.Preference("borrowerRelationship") %] > <a id="addchild" class="btn btn-default btn-sm" href="/cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=[% patron.borrowernumber %]"><i class="fa fa-plus"></i> Add child</a> > [% END %] > - [% IF CAN_user_borrowers_edit_borrowers %] This change doesn't look like it was intentional/related. Please check. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13655] Can't save organisation type patron without entering userid/password
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|indradg(a)l2c2.co.in |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Appears to works well, marking signed off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13655] Can't save organisation type patron without entering userid/password
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74114|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 74192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74192&action=ed… Bug 13655: Allow creation of organisations without entering userid See comment 1 of the bug report for defails of the issue. Test plan: Good luck (you will need to test all combinations (category type eq and ne 'I'), then quick edition and partial edit) Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13655] Can't save organisation type patron without entering userid/password
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13655] Can't save organisation type patron without entering userid/password
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Using QueryAutoTruncate breaks relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Truncation disables |Using QueryAutoTruncate |relevance ranking |breaks relevance ranking -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Truncation disables |Truncation disables |relevance ranking when not |relevance ranking |using QueryParser | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Truncation disables relevance ranking when not using QueryParser
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '18

15 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical CC| |katrin.fischer(a)bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I am upping severity here since a lot of people use QueryAutoTruncate unaware of it breaking Relevance and falsely assuming Koha can't do better. If we can't fix it, we should add a warning to the system preference description of QueryAutoTruncate. Old patch doesn't apply any longer. -- You are receiving this mail because: You are watching all bug changes.

1 0