April 2018 - Koha-bugs - lists.koha-community.org

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73664|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #36 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 73668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73668&action=ed… Bug 9302: (QA follow-up) Consistency follow-up This patch moves the Koha::Patrons->merge method into Koha::Patron->merge_with in the line of the discussed implementation for bug 15336. I agree with that implementation so I provide this follow-up. Tests are adjusted, the controller script is adapted too. The behaviour remains. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #35 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 73664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73664&action=ed… Bug 9302: (QA follow-up) reverse try/catch block Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73649|0 |1 is obsolete| | --- Comment #34 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 73663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73663&action=ed… Bug 9302: (QA follow-up) Dumper plugin isn't used Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73648|0 |1 is obsolete| | --- Comment #33 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 73662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73662&action=ed… Bug 9302: (QA follow-up) Merge should be a transaction Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73646|0 |1 is obsolete| | --- Comment #32 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 73661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73661&action=ed… Bug 9302: (QA follow-up) Copy merged patrons to deletedborrowers table Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Ed Veal <eveal(a)mckinneytexas.org> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73645|0 |1 is obsolete| | --- Comment #31 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 73660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73660&action=ed… Bug 9302: Add ability to merge patron records It would be great if there were a merge patrons feature. If you accidentally end up with one patron with two cards it would be nice to merge their records together so that you don't lose their history or holds or anything. This patch adds a basic patron merge feature. It attempts to relink all patron related tables from the patron(s) to be merged. It does not attempt to relink librarian account related tables at this time. This feature does not attempt to automatically resolve issues such as duplicate holds. Such a feature could build upon this one though. Test Plan: 1) Apply this patch 2) Find two or more patrons 3) Perform a patron search that will bring them up on the same page of results, or add them all to a list of patrons. 4) Use the 'merge' button to begin the merging process 5) Choose a patron to keep 6) Verify the deleted patrons data ( checkouts, holds, etc ) are now linked to the kept patron Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Ed Veal <eveal(a)mckinneytexas.org> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20083] Information disclosure when (mis)using the MARC Preview feature
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73546|0 |1 is obsolete| | --- Comment #57 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 73657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73657&action=ed… Bug 12310 : Decimal separator issues: some fixes in fines The main goal is to prevent - x100 or /100 of the amounts - decimal part truncation Fixes Bug 19521 - Partial fine payment is not working with comma decimal separator Bonuses: - Gets rid of the spaces, currency symbols, names (EUR) There is nothing specific about currency symbols is this patch. It just removes everything that is not a digit a minus or a separator. It handles: - by default comma and dot as decimal separators on the same instance - dot or comma as thousands separators if choose to use only one of them as decimal separator. See DigitSeparator syspref. - minuses, doesn't remove them == Test plan == 1. Use a translation of the staff interface if possible. 2. When you pay an existing fine (more details in the next steps if needed). Check that you can't enter any string except like "XX.XX" (examples in Annex 1) without having an issue after validation. (x100, truncation, etc) 3. Apply this patch 4. run ~/src/installer/data/mysql/updatedatabase.pl 5. In the manual invoice (cgi-bin/koha/members/maninvoice.pl) 6. Apply the annex 1 to the "Amount" field 7. When paying a fine (cgi-bin/koha/members/paycollect.pl) 8. Click on "Pay amount" to go to the page to pay all fines 9. Apply the annex 1 to the "Collect from patron" field 10. Click on "Pay" to go to the page to pay fine 11. Apply the annex 1 to the "Collect from patron" field 12. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl) 13. Apply the annex 1 to the "Amount" field 14. If you have ideas of stuff to try to find *regressions* from the previous versions, then try. You might spare librarian tears by finding something before it's released. (and prevent me from having bounty on my head) 15. Express your happiness. This is important, otherwise the sign off spell won't work! The details of expressing your happiness depend on your culture and habits. === Annex 1: Subpart for each concerned page === 1. Set DecimalSeparators syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not switching to another page. 4. The value should have been converted to 12.34 5. What follows is just a list of examples. They don't have to be tried on each field. 6. Do the same with "12,34 EUR" and ensure that it's converted to "12,34" 7. Same with "EUR 12.34" -> "12.34" 8. "EUR 12.34€hi lyonthree" -> "12.34" 9. "123 456,7" -> "123456.7" 10. "2" -> "2" 11. "2,0" -> "2.0" 12. "-1'345.95" -> "-1345.95" 13. ",1234" -> ".1234" 14. Set DecimalSeparators syspref to "," 15. Reload the page with the form 16. "1.000" -> "1000" 17. "1.000.000,10" -> "1000000.10" 18. Set DecimalSeparators syspref to "." 19. Reload the page with the form 20. "1,000" -> "1000" 21. "1,000,000.10" -> "1000000.10" 22. Validate the form and check that the final value with the dot was well handled. 23. Think about Koalas and smile. 🐨🐨🐨 -- You are receiving this mail because: You are watching all bug changes.

1 0