April 2018 - Koha-bugs - lists.koha-community.org

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73647|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 73648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73648&action=ed… Bug 9302 [QA Followup]: Merge should be a transaction -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- But couldn't they change the home library in their records too? I think in general we got a problem there, that you can get around the limits, maybe the logged-in library is more helpful? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #28 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 73647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73647&action=ed… Bug 9302 [QA Followup]: Merge should be a transaction -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #27 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 73646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73646&action=ed… Bug 9302 [QA Followup]: Copy merged patrons to deletedborrowers table Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Ed Veal <eveal(a)mckinneytexas.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72082|0 |1 is obsolete| | Attachment #72083|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 73645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73645&action=ed… Bug 9302: Add ability to merge patron records It would be great if there were a merge patrons feature. If you accidentally end up with one patron with two cards it would be nice to merge their records together so that you don't lose their history or holds or anything. This patch adds a basic patron merge feature. It attempts to relink all patron related tables from the patron(s) to be merged. It does not attempt to relink librarian account related tables at this time. This feature does not attempt to automatically resolve issues such as duplicate holds. Such a feature could build upon this one though. Test Plan: 1) Apply this patch 2) Find two or more patrons 3) Perform a patron search that will bring them up on the same page of results, or add them all to a list of patrons. 4) Use the 'merge' button to begin the merging process 5) Choose a patron to keep 6) Verify the deleted patrons data ( checkouts, holds, etc ) are now linked to the kept patron Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Ed Veal <eveal(a)mckinneytexas.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11870] Add more informations to histsearch.pl results
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Needs rebase on master. Especially method C4::Koha::GetAuthValCodeFromField has been removed by Bug 17249 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #25 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- I tested the patches and they work as expected. Great job! Some remarks: Major: I'd say the ->merge method should execute code wrapped by a transaction. There are risky operations taking place in there. Minor: To my taste, I'd prefer ->merge to be a Koha::Patron method. i.e. no 'keeper' param, as you want to merge the patron list with $self. Also, I'm not sure about borrowernumbers, they could just be Koha::Patron objects passed, and simplify the logic in ->merge. Tests could be placed in t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9474] filter overdues with fines
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9474 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9474] filter overdues with fines
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9474 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila@collect | |o.ca | -- You are receiving this mail because: You are watching all bug changes.

1 0