April 2018 - Koha-bugs - lists.koha-community.org

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #10 from Josef Moravec <josef.moravec(a)gmail.com> --- Comment on attachment 72240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72240 Bug 15520: Add permission to restrict circ rules editing to own library Review of attachment 72240: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- ::: admin/smart-rules.pl @@ +63,5 @@ > + > +my $uid = Koha::Patrons->find( $loggedinuser )->userid; > +my $restricted_to_own_library = $uid && haspermission( $uid, { parameters => 'manage_circ_rules_restricted' }, { no_inherit => 1 } ); > +$template->param( restricted_to_own_library => $restricted_to_own_library ); > +$branch = C4::Context::mybranch() if $restricted_to_own_library; This is not the logged in user's home library, it is the library where the user is logged in now - so when user change library, he/she could change another's library rules! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8962] Restore Any index behavior and add Anywhere index
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #64 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- (In reply to Charles Farmer from comment #61) > Unless I'm mistaken, this patch doesn't apply anymore: > > > CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc Indeed. Easy rebase. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8962] Restore Any index behavior and add Anywhere index
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70127|0 |1 is obsolete| | --- Comment #63 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Created attachment 73618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73618&action=ed… Bug 8962: Restore Any index behavior and add Anywhere index The "Any" index/register should contains all the data contained in all the other indexes/registers (e.g. Title, Author, Subject, etc). The "Anywhere" index/register should contain the entire record including fields/subfields that aren't indexed anywhere else. In GRS1 indexing the Any index was indeed only on fields defined as indexed. This has changed in DOM where all data in MARC is indexed with Any. This generates a lot of results when no index is defined in search. This patch changes the DOM xsl config generation to add Any to each indexed data and add Anywhere to keep a way of searching on all data. Test plan : - Add a data on a field that is not indexed : for example "toto" in 998$z - Add same data as the title of another record - Index the records - Search on toto without index (uses Any) => you get the 2 records - Search on toto with title index => you get the record with "toto" as title - Apply patch - Update DOM xsl config files - Reindex - Search on toto without index (uses Any) => you get the record with "toto" as title - Search on toto with title index => you get the record with "toto" as title - Search on toto with Anywhere index => you get the 2 records -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8962] Restore Any index behavior and add Anywhere index
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #62 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Created attachment 73617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73617&action=ed… Bug 8962: Changes to CCL.properties, bib1 for authorities, and templates This patch adds a new index Anywhere in ccl.properties in bib1 for authorities, and add "any word" option in intranet search for using this index. Default OPAC and intranet search in still using CCL "Any" index. Testing plan : In a Marc21 GRS-1 Koha : 1/ make some biblio searches without selecting any index (Koha will use "any" index) and note the results. Ex : search "fre", "eng", "book", "history", "history book" 2/ apply the 3 patches 3/ copy the 4 new record.abs files (Marc21 auth, Marc21 bib, Unimarc auth, Unimarc bib) from your sources to the directory used by Zebra configuration in your Koha instance 4/ launch rebuild_zebra.pl -b -r -x -v 5/ check that a new choice "Any word (all indexes)" is visible in advanced search. 6/ make the same searches as 1/ : you should see less results (detailed test plan in patchs 2 and 3) 7/ in Staff interface adavanced search, select "Any word (all indexes)" and make the same searches as 1/ : you should see the same results (maybe with a slight differences, because more notes fields are indexed in Marc21) In a UNIMARC GRS-1 Koha : same test Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala <ere.maijala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall(a)gmail.com |ere.maijala(a)helsinki.fi --- Comment #35 from Ere Maijala <ere.maijala(a)helsinki.fi> --- The bug Paxed noted has been fixed and the patch has been extended to cover all xsl files where I found search links (something with "q=") including UNIMARC and NORMARC. I did my best to test them too. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala <ere.maijala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73598|0 |1 is obsolete| | --- Comment #34 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Created attachment 73605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73605&action=ed… Bug 14716: URI-encode URLs in xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14176 Test plan: 1. Catalog a record with series name "Series & more" 2. Find the record 3. Make sure clicking the "Series & more" link works and the ampersand is properly encoded in the URL. 4. Also try the attached test records and make sure their links work. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala <ere.maijala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '18

04 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #46 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Katrin Fischer from comment #45) > > > > Let [1,2,3,4] be the framework structure > > Let [1,4,2] be the saved record > > > > Currently we load on the framework structure order, giving us > > 1, 2, 3 (empty), 4 > > This does not respect the saved record order. But if we load according do > > the saved record order, where should the empty tag (3) go? Should we place > > it before the saved record's fields or after? Or do some weird half-sorted > > behavior? > > > > before : [3 (empty), 1, 4, 2] > > after : [1, 4, 2, 3 (empty)] > > weird : [1, 3 (empty), 4, 2] > > I'd put the empty ones at the bottom of the list, in alphabetic sequence. +1 -- You are receiving this mail because: You are watching all bug changes.

1 0