August 2018 - Koha-bugs - lists.koha-community.org

[Bug 15894] New: Unify all account fine payment functions
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '19

22 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 Bug ID: 15894 Summary: Unify all account fine payment functions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Right now, Koha has four different functions for making payments: recordpayment, makepayment, recordpayment_sellectaccts and makepartialpayment. We should replace these four functions with a single all-singing all-dancing method in the Koha::Namespace. This would help to reduce regressions and make future additions much simpler ( such as my planned re-implementation of account offsets ) and add consistency for logging and whatnot. -- You are receiving this mail because: You are watching all bug changes.

1 34

[Bug 20978] New: Add Koha::Account::add_credit
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '19

22 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Bug ID: 20978 Summary: Add Koha::Account::add_credit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org There's code spread in several controller scripts that directly inserts account lines on the DB, with hardcoded values that only exist on the forms data comes from (mancredit.pl, maninvoice, etc). There should be a high-level function to deal with credits with a simple set of valid values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 49

[Bug 17045] New: Write API to Allow instant use of reports library
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '19

21 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17045 Bug ID: 17045 Summary: Write API to Allow instant use of reports library Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt(a)gmail.com Reporter: lisetteslatah(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Write an API that would allow us to select and run reports directly from the Koha Community Reports Library, as discussed at Koha US Conference 2016 during the reports Round table. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 21205] New: C4::Acquisition - Remove GetOrderFromItemnumber
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '19

21 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Bug ID: 21205 Summary: C4::Acquisition - Remove GetOrderFromItemnumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org This is done to ease the move of C4::Items (bug 18252) to Koha::Items my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber}); will become my @itemnumbers = $order_object->items->get_column('itemnumbers'); -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 19936] New: Move Check_userid and Generate_Userid to Koha::Patron
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '19

21 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 Bug ID: 19936 Summary: Move Check_userid and Generate_Userid to Koha::Patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 103

[Bug 21040] New: Funds from inactive budgets appear in 'Funds' dropdown on suggestion.pl
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21040 Bug ID: 21040 Summary: Funds from inactive budgets appear in 'Funds' dropdown on suggestion.pl Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org This is similar to Bug 14850- when assigning a purchase suggestion to a specific fund, all funds appear from both Inactive and Active budgets. It would be nice to have the ability to have the option to only see Active budgets or the ability to toggle between both. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 18383] New: items.onloan schema comment seems to be incorrect.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '19

19 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Bug ID: 18383 Summary: items.onloan schema comment seems to be incorrect. Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcharlt(a)gmail.com Reporter: pongtawat(a)punsarn.asia QA Contact: testopia(a)bugs.koha-community.org Currently the items.onloan schema comment (in SQL and hence on schema.koha-community.org too) is like this: defines if item is checked out (NULL for not checked out, and checkout date for checked out) However, on my installation (16.11.06), the date that Koha put into items.onloan column seems to be due date. So, probably the comment should be changed to: defines if item is checked out (NULL for not checked out, and due date for checked out) -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 19731] New: Notify when you add new item with reservations
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '19

19 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19731 Bug ID: 19731 Summary: Notify when you add new item with reservations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: patrick.robitaille(a)collecto.ca QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Hi, It would be nice in Koha when you add a new item to have a notification or a pop-uo when all the items for this record are on loan and there are reservations for this record. That could be usefull to have this notification for the person who has added the new item to be niticed that it should be put on hold to satisfy reservations and not shelved with available status. Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 16714] New: Unexpected logout with "IP address change"
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16714 Bug ID: 16714 Summary: Unexpected logout with "IP address change" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org I get a new issue (not sure since when) under Plack: I am logged out with "IP address change" just after the first login. To reproduce: - logout - restart plack - login - click somewhere => You will be logged out I have tried to debug: diff --git a/C4/Auth.pm b/C4/Auth.pm index 985bd39..a494ddf 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -818,6 +818,9 @@ sub checkauth { $userid = $s_userid; $sessiontype = $session->param('sessiontype') || ''; } + + warn $ip; + warn $ENV{REMOTE_ADDR}; if ( ( $query->param('koha_login_context') && ( $q_userid ne $s_userid ) ) || ( $cas && $query->param('ticket') && !C4::Context->userenv->{'id'} ) || ( $shib && $shib_login && !$logout && !C4::Context->userenv->{'id'} ) I get: After the login: $ip=undef, $ENV{REMOTE_ADDR}=192.168.254.1 After the click producing the logout: $ip=192.168.254.1, $ENV{REMOTE_ADDR}=127.0.0.1 After the second login: $ip=127.0.0.1, $ENV{REMOTE_ADDR}=127.0.0.1 -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 20461] New: New subscription form: "Item type" and "item type for older issues" are ignored
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20461 Bug ID: 20461 Summary: New subscription form: "Item type" and "item type for older issues" are ignored Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor.grousset(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Impacts also 16.11.x == Cause == In subscription-add.pl, the two params aren't passed to NewSubscription() but they are to ModSubscription() == Workaround == Modify the newly created subscription to set these two values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25