August 2018 - Koha-bugs - lists.koha-community.org

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78280&action=ed… Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78074|0 |1 is obsolete| | Attachment #78075|0 |1 is obsolete| | Attachment #78076|0 |1 is obsolete| | Attachment #78077|0 |1 is obsolete| | Attachment #78078|0 |1 is obsolete| | Attachment #78277|0 |1 is obsolete| | Attachment #78278|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78279&action=ed… Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #29) > QA scripts complain about missing POD: > FAIL pod coverage > POD is missing for add_user > POD is missing for duplicate_to > POD is missing for items > POD is missing for users Added in the last follow-up. > This looks a little odd: > + <label for="fund">Fund: </label> > + <select name="budget" id="fund"> Moved from acqui/histsearch.tt, existed before this patch. > Wondering about missing |html filters, especially in > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt. Added missing filters in a separate patch. (In reply to Katrin Fischer from comment #30) > Also, can you please explain the last patch? > > Bug 15184: Add users ? > > We certainly do not want this patch. What about users that are notified > on receiving? When an order is duplicated, do we want to duplicate the user list who were notified on receiving? I.e. they will be notified on receiving items for the duplicated order. I was not sure if it was wanted or not, so I put that code on a separate patch and waited for a feedback. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #33 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78278&action=ed… Bug 15184: add missing filters -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #32 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78277&action=ed… Bug 15184: Add POD -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver(a)bywatersolutions.co |jonathan.druart(a)bugs.koha-c |m |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78276&action=ed… Bug 15520: Rename permission to manage_circ_rules_from_any_libraries -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77219|0 |1 is obsolete| | Attachment #77220|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78275&action=ed… Bug 15520: Add permission to restrict circ rules editing to own library Test plan: 1) Ensure that you have four users: a) A superlibrarian b) A user with all `parameters` permissions (the toplevel `parameters` box is checked). c) A user with the `manage_circ_rules` permission (and, of course, `catalogue`). d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted` and `catalogue` permissions. 2) As all four users, load the "Circulation and fine rules" administration page (admin/smart-rules.pl). 3) The page should be unchanged for the first three users. It should be possible to view and edit the circ rules for all libraries. 4) The last (restricted) user should only be able to view and edit the circ rules for their own library. Amended by JD: In a second version of this patch manage_circ_rules_restricted has been replaced by manage_circ_rules_from_any_libraries and 'no_inherit' related code has been removed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0