August 2018 - Koha-bugs - lists.koha-community.org

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78270|0 |1 is obsolete| | --- Comment #99 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 78271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78271&action=ed… Bug 12747: Add extra column in Z3950 search This patch makes it possible to add an extra column to Z3950 search results. The system preference AdditionalFieldsInZ3950ResultSearch decides which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch 1) Create a new basket or use an existing one 2) In -Add order to basket-, click "From an external source" 3) Select some search targets and enter a subject heading ex. house 4) Click Search bouton 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) Shares same syspref as above 1) Go to cataloguing, click New from z3950 2) Fill to result in a successful search 3) Validate column Addition Fields prove t/db_dependent/Breeding.t Sponsored-by: CCSR (https://ccsr.qc.ca) Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77729|0 |1 is obsolete| | --- Comment #98 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 78270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78270&action=ed… Bug 12747: Add extra column in Z3950 search This patch makes it possible to add an extra column to Z3950 search results. The system preference AdditionalFieldsInZ3950ResultSearch decides which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch 1) Create a new basket or use an existing one 2) In -Add order to basket-, click "From an external source" 3) Select some search targets and enter a subject heading ex. house 4) Click Search bouton 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) Shares same syspref as above 1) Go to cataloguing, click New from z3950 2) Fill to result in a successful search 3) Validate column Addition Fields prove t/db_dependent/Breeding.t Sponsored-by: CCSR (https://ccsr.qc.ca) Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #90 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78266&action=ed… Bug 15565: Changed the retrieval of selected hold pickup branch in opac-reserve.pl Previously the selected branch dropdown value was not being successfully retrieved in opac-reserve.pl, this resulted in opac holds being placed with no pickup branch being set. Consequently as no branch was associated with the hold an Ajax error was thrown when viewing the holds-table in the patron page in the staff client. This commit successfully retrieves the selected branch value and so fixing the Ajax error. Test plan: 1. Apply all patches on bug report 15565 except this commit 2. Place a hold(s) from opac-reserve.pl. 3. Go to your opac patron summary page (opac-user.pl) and notice although the holds are successfully displayed they have no 'Pickup location' value 4. Go to the patron page in the staff client and click on the 'Hold(s)' tab and notice a popup explaining the datatable Ajax error is loaded 5. Apply this patch 6. Repeat step 3 noticing this time in the opac-user.pl a 'Pickup location' is displayed for the hold you just created. 6. Repeat step 4 and notice the hold datatable is successfully loaded and populated without an Ajax error popup being loaded. Sponsored-By: Brimbank Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76859|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76853|0 |1 is obsolete| | --- Comment #56 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 78264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78264&action=ed… Bug 8630: [FOLLOW-UP] Make Adlibris cover show on OPAC overdues tab and fix alignment of cover on Staff detail page. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76852|0 |1 is obsolete| | --- Comment #55 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 78263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78263&action=ed… Bug 8630 - Adlibris covers (OPAC less changes) This patch adds two new CSS classes specific to Adlibris covers. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76851|0 |1 is obsolete| | --- Comment #54 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 78262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78262&action=ed… Bug 8630 - Adlibris covers (OPAC templates) Changes to OPAC templates. Depends on new CSS clases defined in separate patch. Test plan: To test this particular patch (intranet templates) you need: * The syspref patch applied * The intranet CSS patch applied To test: * Apply this patch * Enable covers (if not done already) * Go to staff interface, log in as a priviliged user. * Select "More" -> "Administration" -> "Global system preferences" -> "Enhanced content". * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris". * Save changes * Add a book with a known cover/ISBN (if none exists) * Set MARC field 020 a, "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935 * Set MARC field 245 a, "Title" to: 1984 * Save changes * Test opac-results.tt * Search library catalog from OPAC for "1984". * You should be sent to: http://127.0.1.1/cgi-bin/koha/opac-search.pl?idx=&q=1984 * Cover image should be shown to the right of each title with CSS class: "adlibris-cover" * Test opac-detail.tt (continued from previous test's location) * Click on the title with cover (1984, ISBN: 9780451524935) * Cover should be displayed to the left in full size. * If clicked, should link to the full-size image. Test opac-results-grouped.tt * This template is only used if an external "grouping" server is setup and the syspref "OPACGroupResults" is set to "Use". * Personally I did not test this, b/c: terminally lazy * Test opac-showreviews.tt * Could not find any links to this location, manually enter it: http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl * Image should be shown to the right in full size. * If clicked it should take you to the detail view with the comments tab opened. * Test opac-showreviews-rss.tt * Click on the RSS icon from previous test's start location. URL should be: http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl?format=rss * An image tag linking to the full-size image without any styling class should be present. * Test opac-user.tt * Click on your username to open: http://127.0.1.1/cgi-bin/koha/opac-user.pl * Covers should be shown for checked out items with CSS class: adlibris-cover * When clicked the destination should be the same as clicking the title column entry: opac-details.pl * Test opac-opensearch.tt * Click on "Advanced search" and enter "1984" then press "Search" * This search screen uses a different template. * Cover image should be shown to the right of each title with CSS class: "adlibris-cover" * If clicked, should link to the OPAC detail view. * Test opac-readingrecord.tt * Click on your logged-in name to go to your personal page. * Click on "Your reading history" tab on the left. http://127.0.1.1/cgi-bin/koha/opac-readingrecord.pl * Covers should be shown in leftmost column with CSS class: adlibris-cover * If clicked, should link to the same as the 'Title' link. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76850|0 |1 is obsolete| | --- Comment #53 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 78261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78261&action=ed… Bug 8630 - Adlibris covers (intranet CSS) This defined two new CSS classes for use by the intranet templates. Apply this patch before doing the testing of "intranet templates". Sponsored-By: Halland County Library Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76849|0 |1 is obsolete| | --- Comment #52 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 78260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78260&action=ed… Bug 8630 - Adlibris covers (intranet templates) Changes to staff interface (intranet) templates. Depends on new CSS clases defined in separate patch. Test plan: To test this particular patch (intranet templates) you need: * The syspref patch applied * The intranet CSS patch applied To test: * Apply this patch * Enable covers (if not done already) * Go to staff interface, log in as a priviliged user. * Select "More" -> "Administration" -> "Global system preferences" -> "Enhanced content". * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris". * Save changes * Add a book with a known cover/ISBN (if none exists) * Set MARC field 020 a, "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935 * Set MARC field 245 a, "Title" to: 1984 * Save changes * Test results.tt * From the main intranet page, select "Search the catalog" and enter the title we added, "1984" and press "Search". * You should end up with the url: http://127.0.1.1:8080/cgi-bin/koha/catalogue/search.pl?q=1984 * The cover image should be shown in the leftmost column. * If cover is clicked, the full cover image should be shown. * Test detail.tt (continue from the search results used in prev. test) * Click on the title text, you should be sent to: http://127.0.1.1:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=2 * The cover image should be shown on the right. * If clicked, the full cover should be shown. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76848|0 |1 is obsolete| | --- Comment #51 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 78259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78259&action=ed… Bug 8630 - Adlibris covers (syspref files) This patch adds a system preference for cover images from Swedish book retailer Adlibris. Images are retrieved via http or https from an external web server. This might leak OPAC and Staff interface data to third parties and should thus be used with caution. Sponsored-By: Halland County Library Test plan: Test 1: Test upgrade procedure for clean installation. Start by removing existing sysprefs, if present: $ mysql -u kohaadmin -p -D koha > DELETE FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; * Apply this patch which will add a pref file, update the 'syspref' structure and add an atomic upgrade file. * Install the update: Koha$ perl installer/data/mysql/updatedatabase.pl * Once upgraded and logged in, Select 'More', 'Administration', 'Global Preferences' and finally 'Enhanced content'. There should be a new option called 'Adlibris'. The first option should default to "Don't show", if not the patch is broken. The second options should show the default URL: http://www.adlibris.com/se/organisationer/showimagesafe.aspx If not, the patch is broken. Test 2: Changing sysprefs * In the control panel, change the first value from "Don't show" to "Show" and save the changes. Use MySQL client to inspect changes: $ mysql -u kohaadmin -p -D koha > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; The column 'value' should now have the value '1', if not the patch is broken. Test 3: Apply update to existing data * Re-execute the installer now that the database has the data already: Koha$ perl installer/data/mysql/updatedatabase.pl If any errors occur the patch is broken. Examine the database contents: $ mysql -u kohaadmin -p -D koha > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; If the values were overwritten by the installer the patch is broken. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0