August 2018 - Koha-bugs - lists.koha-community.org

[Bug 9514] 'and' in subject searches causes a problem
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9514 --- Comment #4 from Jon Knight <J.P.Knight(a)lboro.ac.uk> --- (In reply to Owen Leonard from comment #3) > Jon, the "importance" setting has no effect on how bug fixes are > prioritized. If a bug isn't moving there are a few things you can do: It might be a good idea to hide it from the Bugzilla UI in that case. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hm, waiting for the last comment to be answered before more testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #30 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Also, can you please explain the last patch? Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #29 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- QA scripts complain about missing POD: FAIL pod coverage POD is missing for add_user POD is missing for duplicate_to POD is missing for items POD is missing for users This looks a little odd: + <label for="fund">Fund: </label> + <select name="budget" id="fund"> Wondering about missing |html filters, especially in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt. Will continue testing - leaving some first notes as I'll have to come back to this later. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |katrin.fischer(a)bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer(a)bsz-bw.de | --- Comment #97 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Note: signed off this one, so won't be able to QA - unless someone else gives it another sign-off then. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #96 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Can you please take a look at comment#94? Sorry for leaving this unfinished, will try to return asap when fixed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #89 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78248&action=ed… Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC This commit fixes two bugs: 1. C4::Reserves->CanItemBeReserved() returns an output in a hash in the format: status => 'output' However opac-reserve.pl is not accessing th output of this function correctly consequently no item is ever reservable. And so after a patron submits the reservation form on opac-reserve.pl it looks like the item-level reservation has successfully been placed however it has not and no error message is displayed to them. This commit stores the output of the aforementioned function in a hash and then checks the value of the status key. As a result opac-reserve.pl now correctly accesses the value returned and item level holds are successfully placed from the OPAC. 2. If a biblio has previously been reserved then the opac-reserve.pl page shows the 'Next available item' and 'A specific item' radio buttons to be disabled to ensure patrons cannot place a reservation of a different type on the biblio. With both of these radio buttons being disabled it results in item level holds placed in the OPAC on a previously reserved item not being stored in the database. This is very confusing for users. I have implemented a conditional which checks what the forced_hold_type of the previous hold was. If it was 'item' then the $reqtype = 'Specific' and if it was 'record' then $reqtype is 'Any'. This means there will always be a value for $reqtype, and this variable is checked if it is equal to 'Specific' and if it is then an item level hold is placed. Test plan: 1. Ensure in your circulation rules that 'Item level holds' is enabled 2. Apply all patches on this bug report except this commit 3. In the OPAC try placing a item level hold (and notice you can submit the opac-reserve.pl page and no error messages are displayed. However the hold(s) are not being placed. 4. Place an item level hold(s) on the biblio from staff client interface and then return to the opac-reserve.pl page for the biblio in the OPAC and notice both the 'Next available' and 'A specific item' radio buttons are disabled. 5. Again try placing an item level hold in the OPAC and notice dispite no error/warning message being displayed the hold is not being placed. 6. Apply this patch 7. Restart memcached, and plack 8. In the staff client remove the reservation you placed from the staff client. 9. Repeat step 3 and notice when you go to your opac summary (opac-user.pl) page the holds are displayed. .i.e. You can now successfully place item level holds in the OPAC. 10. Return to the opac-reserve.pl page for the biblio and notice that because you have already placed a hold on this biblio the 'Next available item' and 'A specific item' radiobuttons are disabled. 11. Select several of the items checkboxes to place more item level holds and press the 'Confirm hold' button. 12. Go to your opac summary (opac-user.pl) page again and notice the holds you placed in step 11 are shown there. i.e. you can place item level holds from the OPAC on biblios which have previously had reserves placed on them. Sponsored-By: Brimbank Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #88 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78247&action=ed… Bug 15565: Remove use of GetBiblionumberFromItemnumber Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)deichman.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #87 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78246&action=ed… Bug 15565: Alert librarian that maximum holds per record is reached Signed-off-by: Dani Elder <dani(a)bywatersolutions.com> Signed-off-by: Danielle Elder <danielle(a)bywatersolution.com> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)deichman.no> -- You are receiving this mail because: You are watching all bug changes.

1 0