November 2019 - Koha-bugs - lists.koha-community.org

[Bug 23108] New: staffaccess permission can be easily circumvented
by bugzilla-daemon＠bugs.koha-community.org 04 May '20

04 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23108 Bug ID: 23108 Summary: staffaccess permission can be easily circumvented Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- A user without the staffaccess permission cannot change the permissions or password for another user belonging to a patron category that is not type Staff. This works as intended. BUT: A user without the staffaccess permission can simply change a Staff user to a new non-staff patron category and then make changes to permissions and/or password. To test: - create patron category STAFF with type Staff - create patron A and patron B in category STAFF - create patron category ADULT with type Adult - give patron A catalogue and borrowers permissions (but NOT staffaccess) - log in as patron A - verify that you cannot change permissions for patron B - verify that you cannot change password for patron B - change patron B to category ADULT - change patron B's permission - change patron B's password -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 19799] New: [16.11] Changing language on OPAC redirects back to homepage
by bugzilla-daemon＠bugs.koha-community.org 04 May '20

04 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799 Bug ID: 19799 Summary: [16.11] Changing language on OPAC redirects back to homepage Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: claire_gravely(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org Whilst looking at an item detail page on the OPAC (opac-detail.pl) you are redirected back to the OPAC homepage instead of staying on opac-detail. The language is successfully changed. This is not an issue on master. We have tested it on 16.11, am not sure if it is an issue anywhere inbetween. -- You are receiving this mail because: You are watching all bug changes.

1 29

[Bug 19623] New: Move admin templates JavaScript to the footer: Cataloging
by bugzilla-daemon＠bugs.koha-community.org 03 May '20

03 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Bug ID: 19623 Summary: Move admin templates JavaScript to the footer: Cataloging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: jonathan.druart(a)bugs.koha-community.org, nick(a)bywatersolutions.com, simon.pouchol(a)biblibre.com, testopia(a)bugs.koha-community.org Depends on: 19608 Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for some cataloging templates: addbooks.tt, linkitem.tt, merge.tt, z3950_auth_search.tt, z3950_search.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 [Bug 19608] Move admin templates JavaScript to the footer: The rest -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 15850] New: Correct JSHint errors in cataloging.js
by bugzilla-daemon＠bugs.koha-community.org 02 May '20

02 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 Bug ID: 15850 Summary: Correct JSHint errors in cataloging.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: koha-bugs(a)lists.koha-community.org, m.de.rooy(a)rijksmuseum.nl, testopia(a)bugs.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in cataloging.js koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 43, col 31, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 49, col 72, Use '!==' to compare with ''. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 99, col 13, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 116, col 17, 'id_input' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 182, col 37, 'olddiv' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 183, col 37, 'oldcontrol' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 108, col 18, 'j' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 108, col 26, 'j' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 108, col 46, 'j' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 109, col 27, 'j' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 109, col 59, 'j' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 110, col 28, 'j' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 220, col 21, 'inputs' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 226, col 25, 'anchors' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 227, col 30, 'j' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 176, col 21, 'CloneButtonPlus' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 280, col 13, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 280, col 17, 'len' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 287, col 13, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 287, col 17, 'len' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 296, col 13, 'oldcontrol' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 315, col 21, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 409, col 15, 'line' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 425, col 34, 'line' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 465, col 13, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 465, col 17, 'len' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 471, col 13, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 471, col 17, 'len' is already defined. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.

1 13

[Bug 15794] New: Allow the use of emojis as tags on records
by bugzilla-daemon＠bugs.koha-community.org 02 May '20

02 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Bug ID: 15794 Summary: Allow the use of emojis as tags on records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org A library requested the ability to add emojis in the tag field on the opac. Entering an emoji now seems to scrub it clear and leave no value in the db but still enter a new tag. Subsequent attempts warn of repeated tags. -- You are receiving this mail because: You are watching all bug changes.

1 41

[Bug 20436] New: Add ability to specify itemtypes for longoverdue.pl
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '20

30 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 Bug ID: 20436 Summary: Add ability to specify itemtypes for longoverdue.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz It would be nice if we could filter long overdues based on itemtype the same way we can already filter based on borrower category code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 31

[Bug 24013] New: Transferring a checked out item gives a software error
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '20

30 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Bug ID: 24013 Summary: Transferring a checked out item gives a software error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To reproduce: 1. check out an item 2. Go to circulation -> transfer and put in the barcode of the item you just checked out 3. error: Can't call method "borrowernumber" on unblessed reference at /home/vagrant/kohaclone/C4/Circulation.pm line 350 This occurs in the C4::Circulation::transferbook subroutine. It happens because Bug 18276 accidentally reintroduces an old subroutine (GetOpenIssue) that returns an unblessed reference. This line should use Koha Objects instead. Code causing an error: my $issue = GetOpenIssue($itemnumber); # check if it is still issued to someone, return it... if ( $issue ) { AddReturn( $barcode, $fbr ); $messages->{'WasReturned'} = $issue->borrowernumber; } Suggested fix: my $issue = Koha::Checkouts->find({ itemnumber => $itemnumber }); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 19652] New: Debug-level logging for response JSON
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '20

29 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652 Bug ID: 19652 Summary: Debug-level logging for response JSON Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)jns.fi Log response JSON in REST API log. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 23577] New: OPAC - patron e-mail notification of new login location
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '20

28 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23577 Bug ID: 23577 Summary: OPAC - patron e-mail notification of new login location Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org Would like to see e-mails sent to patrons alerting them of IP addresses or new machines the account was logged in from. The e-mail could include IP addresses, OS information, and browser information, as well as a time stamp. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 21761] New: Koha::Object supports passing through 'update' which means we can side step 'set' + 'store'
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '20

28 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Bug ID: 21761 Summary: Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org If we're adding triggers at the code level all over the place by overloading the store method we need to never ever let dbic handle it.. by allowing the 'update' method through we are exposing ourselves to places in the codebase skipping the store triggers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 45