December 2019 - Koha-bugs - lists.koha-community.org

[Bug 14654] Add desk filter in Holds awaiting pickup list
by bugzilla-daemon＠bugs.koha-community.org 10 Dec '19

10 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 Nicolas Legrand <nicolas.legrand(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 [Bug 24201] Attach desk to intranet session -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13881] Add desk management
by bugzilla-daemon＠bugs.koha-community.org 10 Dec '19

10 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand <nicolas.legrand(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Hold requests |Circulation CC| |kyle.m.hall(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 10 Dec '19

10 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I have adjusted the test plan and updated the patch (remote branch is still up-to-date). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 10 Dec '19

10 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96150&action=ed… Bug 8132: Adding message when deleting from the UI -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 10 Dec '19

10 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96149&action=ed… Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 10 Dec '19

10 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96148&action=ed… Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 10 Dec '19

10 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95936|0 |1 is obsolete| | Attachment #95937|0 |1 is obsolete| | Attachment #95938|0 |1 is obsolete| | Attachment #95939|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96147&action=ed… Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 10 Dec '19

10 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 10 Dec '19

10 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #33 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Kelly McElligott from comment #29) > I did not see the message that is indicated in step 2. " Nothing happened > and you get a message saying that one of the 2 items > from B2 is blocking the whole deletion process" . > > This would be an extremely helpful message. I received a message that 2 > items were deleted. Yes, they were the correct items to be deleted and left > the item with the hold along. I am not sure with this test plan, if this > message that you note in step 2 should be see. > > See my screenshot. > > Kelly There is something wrong indeed, working on it! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 10 Dec '19

10 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #32 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Update test plan: > 0/ Setup > Create Biblio B1 with 1 item > Create Biblio B2 with 2 items > Create Biblio B3 with 1+ item > Create Biblio B4 with 1+ item > Place a biblio-level hold on B1 and B2 > Place an item-level hold on B3 > Confirm the holds (to mark them waiting) Read: Confirm the item-level hold, the one placed on B3 only. > 1/ Use the 5 items and delete them in a batch. > => delete of item from B1 is blocked on first screen > => delete of items from B2 is *not* blocked on first screen > => delete of item from B3 is blocked on first screen > => delete of item from B4 is *not* blocked > > Note that you can only select items from B2 and B4 > > 2/ Select them and confirm the deletion > => Nothing happened and you get a message saying that one of the 2 items > from B2 is blocking the whole deletion process > > 3/ Remove the biblio-level hold > 4/ Repeat 1 > => The deletion has been effective! -- You are receiving this mail because: You are watching all bug changes.

1 0