December 2019 - Koha-bugs - lists.koha-community.org

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #102 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96086&action=ed… Bug 15326: (follow-up) utf8 to utf8mb4 Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #101 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96085&action=ed… Bug 15326: (follow-up) Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland Bug 15326: [FOLLOW-UP] Many fixes This patch: - moves action buttons into a dropdown, adds a delete button to dropdown - fixes the tests (they should now all pass) - fixes qa tool problems - removes the Koha::CmsPages->remove() method (unnecessary) - makes changes to the Koha::CmsPages->add() method (now simpler, easier to test) This is now ready to test. Sponsored-by: Catalyst IT Bug 15326: [FOLLOW-UP] More fixes This patch removes the t/Pages.t file because it isn't required, and other unused methods. This patch is ready to test. The appropriate tests are in t/db_dependent/Pages.t Bug 15326: [FOLLOW-UP] adding and editing fixes Sorry, did not see the second half of your comment. This patch should fix the adding and editing issues in Comment 16. Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing Fixes issues from Comment 19, please test Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87494|0 |1 is obsolete| | Attachment #87495|0 |1 is obsolete| | Attachment #87496|0 |1 is obsolete| | Attachment #87497|0 |1 is obsolete| | Attachment #87498|0 |1 is obsolete| | Attachment #87499|0 |1 is obsolete| | Attachment #87500|0 |1 is obsolete| | Attachment #87501|0 |1 is obsolete| | Attachment #87502|0 |1 is obsolete| | Attachment #87503|0 |1 is obsolete| | Attachment #87608|0 |1 is obsolete| | Attachment #87609|0 |1 is obsolete| | Attachment #87617|0 |1 is obsolete| | --- Comment #100 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96084&action=ed… Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6154] Default sorting by title doesn't work
by bugzilla-daemon＠bugs.koha-community.org 08 Dec '19

08 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6154 KohaGeekWien <team(a)gelinger.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|CLOSED |REOPENED --- Comment #4 from KohaGeekWien <team(a)gelinger.at> --- I have a very latest Koha , and the sorting via Title is not working http://bp.reserveabooklibrary.com/cgi-bin/koha/catalogue/search.pl?idx=kw&q… Here you can see After B comes T Then C ... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6154] Default sorting by title doesn't work
by bugzilla-daemon＠bugs.koha-community.org 08 Dec '19

08 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6154 KohaGeekWien <team(a)gelinger.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |team(a)gelinger.at -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '19

07 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24162 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10263] Add ability to limit which library can edit a bibliographic record
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '19

07 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to limit which |Add ability to limit which |branch can edit a |library can edit a |bibliographic record |bibliographic record -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8937] Translation process removes CDATA in RSS XML
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '19

07 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- > > Change the contents of 'test.po' to > It's 'test.tt', sorry. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8937] Translation process removes CDATA in RSS XML
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '19

07 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel(a)gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #5) > From what I understand, it turns out that regardless of 15395, the main > translation system will still process the file and remove the CDATA. > > So I don't know what would be a decent way to fix this. If one takes a look at the translated file, not all CDATA entries are removed. In EN 'opac-opensearch.tt' for example there are two lines near the begining, $ egrep -n CDATA opac-opensearch.tt 25: <title><![CDATA[.(removed).]]></title> 28: <description><![CDATA[.(removed).]]></description> In the translated version of the same file we have 25: <title><![CDATA[[.(removed).]]></title> 28: <description>.(removed).</description> CDATA is removed but in 'description', not in 'title'! Why one and not the other? Because of C4::TTParser, based on HTML::Parser. treats some tags differently (script, style, xmp, iframe, title, textarea and plaintext), see https://metacpan.org/pod/HTML::Parser Anyway, the important thing is that ANY text inside CDATA block is IGNORED by the translation process, whichever the tag, and I was not aware of this. To verify this: go to misc/translator, edit a new file 'test.tt' and put inside the lines <title><![CDATA[ Title ]]></title> <description><![CDATA[ Description ]]></description> then create a translation file form it ./tmpl_process3.pl create -i ./ -f test.tt -s test.po 'test.po' will have nothing to translate! Change the contents of 'test.po' to <title> Title </title> <description> Description </description> and repeat, rm test.po; ./tmpl_process3.pl create -i ./ -f test.tt -s test.po 'test.po' has now strings to translate. Other rss files, 'opac-news-rss.tt' for example, do not use CDATA at all. Question: Can we remove CDATA blocks from this files? It's the only 'fix' that I can think of. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 23029] New: OPAC Authorities Search. Internal Server Error. Free-floating subdivisions imported from LOC
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '19

07 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23029 Bug ID: 23029 Summary: OPAC Authorities Search. Internal Server Error. Free-floating subdivisions imported from LOC Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbutosi(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Koha 18.11 on Ubuntu 16.04 (MariaDb) with Plack. ================================================ I recently discovered that the Library of Congress released their 2014 authorities as a free, open-access dataset in Marc8, xml, and Utf8 formats. This is great! (https://www.loc.gov/cds/products/MDSConnect-subject_authorities.html) I have completed batch uploading the file successfully into Koha (about 320,000 records) and reindexed Zebra. Part of the authority file includes free-floating subdivisions, identified by the presence of a MARC21 authority tag 180. I discovered an "Internal Server Error" page if I attempted to click on the Details button of any of these sub-divisions' records in the OPAC authority browse results page. My Plack error log reported the following error each time I attempted to access the authorities details page from the OPAC: "Can't call method "authtypetext" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-authoritiesdetail.pl line 89." I corrected this error by creating a new Authority Type using the pre-populated value found in field 942 within these free-floating subdivision records (i.e., "GEN_SUBDIV") and assigning tag 180 as the "authority field to copy" Once created, I was able to access the OPAC details page, as expected, and all free-floating subdivisions were re-indexed as free-floating subdivisions. They also became selectable as an authority type from the drop-down menu in the Authority Search. For a detailed explanation of the above, see: http://craigbutosi.ca/2019/05/31/plack-error-authority-file-free-floating-s… The Authority Type GEN_SUBDIV should be defined in order to prevent the Plack error from occurring. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8