December 2019 - Koha-bugs - lists.koha-community.org

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #112 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96096&action=ed… Bug 15326: Schema changes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #111 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96095&action=ed… Bug 15326: (follow-up) Remove obsolete LESS file, add TT filters Previous versions of this patch set adds a LESS file to the OPAC, which is now obsolete. It should be removed. In addition, the change made to opac.less contained CSS which didn't apply to any existing markup, so it need not be added to opac.scss. The patch also adds missing Template Toolkit filters to template files. None of these changes should be visible in testing. OPAC CMS pages should function as usual. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #110 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96094&action=ed… Bug 15326: (follow-up) Corrections to staff client templates This patch makes some corrections to the staff client's CMS-related templates: - Add missing Template Toolkit filters. - Remove JavaScript from tools-menu.inc. This must have crept in during a rebase. - Add navigation link highlighting to tools-menu.js instead. - Convert tools/cmspages.tt to Bootstrap grid. - Correct toolbar button class. - Move some column sorting configuration out of JS and into table markup. - Move "Select all" / "Clear all" links to the top of the table to match similar interfaces. - Change the Action menu's "Intranet" and "OPAC" links to be "View" and "View in OPAC." The OPAC view now opens a new window. To test, apply the patches and test the Pages feature in the staff client: Adding, editing, deleting, viewing. For each view, test that the page layout adjusts to various browser widths. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #109 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96093&action=ed… Bug 15326: (follow-up) Redindent new CMS page templates This patch is an opinionated reindent of new and changed templates related to the CMS feature. I think it would be nice for these templates to start out with good indentation. To test, apply the patch and test the CMS feature. There should be no visible change to the way it looks or the way it works. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #108 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96092&action=ed… Bug 15326: (follow-up) Pages navigation fixes This is the best I've managed to do with the navigation. Would be happy for someone else to give it a go because I'm aware that some parent links repeat. Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #107 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96091&action=ed… Bug 15326: (follow-up) Interface fixes This patch addresses the following: a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #106 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96090&action=ed… Bug 15326: (follow-up) Code review fixes Addresses the following issues: b) In opac-cmspages there is: + flagsrequired => { borrow => 1 }, The borrow permission has been removed since. (blocker) c) Comment was removed unnecessarily, just needs to be moved into its right spot below again: -# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens d) One file uses qw( -utf-8) but another does not: +use CGI; +use CGI qw( -utf8 ); (blocker) Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #105 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96089&action=ed… Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #104 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96088&action=ed… Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '19

09 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #103 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96087&action=ed… Bug 15326: (follow-up) Move js to footer, use Asset plugin Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0