March 2019 - Koha-bugs - lists.koha-community.org

[Bug 22551] New: Stray "//" appears at bottom of opac-detail.tt
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551 Bug ID: 22551 Summary: Stray "//" appears at bottom of opac-detail.tt Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: ephetteplace(a)cca.edu QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 86822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86822&action=ed… screenshot of stray characters In the "SocialNetworks" JavaScript area of the OPAC display, there's this code (currently lines 1390-1393 of opac-detail.tt): //<![CDATA[ {lang: '[% lang | html %]'} //]]> </script> It seems like an opening <script> tag is missing (the closing one is orphaned) which results in the "//" characters displaying on the page towards the very bottom (see screenshot). It's not 100% clear to me what this code was intended to do but I think it was meant to be part of the old Google+ (removed from Koha earlier this year) script tag like this: <script src="https://apis.google.com/js/plusone.js" type="text/javascript"> //<![CDATA[ {"lang":"en-US"} //]]> </script> However, right now it's only effect is the stray "//"—the JS code is commented out and even if it wasn't I don't think declaring {"lang": "en-US"} as an object literal unassigned to any variable has any effect. I can make a patch for this shortly. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 20837] New: CanItemBeReserved should follow ReservesControlBranch and not CircControl
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Bug ID: 20837 Summary: CanItemBeReserved should follow ReservesControlBranch and not CircControl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com According to the pref descriptions CircControl shouldn't affect reserves, we should check the other pref. Also, the important note 'Default holds policy by item type' admin/smart-rules.pl is misleading: "Important: The policies are based on the patron's home library, not the library where the hold is being placed." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 37

[Bug 22418] New: Authority link magnifying glass icon doesn't appear for 655 subject tags
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22418 Bug ID: 22418 Summary: Authority link magnifying glass icon doesn't appear for 655 subject tags Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- For authority-linked 650 tags, the catalog shows a magnifying glass icon that links to the authority record. It does not do the same for authority-linked 655 tags. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 21784] New: Clean up js_includes
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Bug ID: 21784 Summary: Clean up js_includes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Script type attributes should be removed from js_includes. CDATA markers can also be removed. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 22564] New: accounttype 'Rep' is still referred to but is never set
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Bug ID: 22564 Summary: accounttype 'Rep' is still referred to but is never set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- The 'Rep' accounttype has not been set in Koha for some time and it should now be safe to remove all references to it. History: 'Rep' used to mean 'Replaced' and at some point may have been used to denote when a lost book had been replaced. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 54

[Bug 21783] New: Reindent admin/columns_settings.tt
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Bug ID: 21783 Summary: Reindent admin/columns_settings.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org admin/columns_settings.tt was created with two-space indentation, but coding guidelines require 4. This patch will reindent the template. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 22174] New: Add specific help link to /cgi-bin/koha/members/apikeys.pl
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22174 Bug ID: 22174 Summary: Add specific help link to /cgi-bin/koha/members/apikeys.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- The API keys page in staff has no specific help, the help link on the top directs to the start page of the manual. It would be nice if this lead to a more helpful one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 21307] New: Switch two-column templates to Bootstrap grid: Cataloging
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Bug ID: 21307 Summary: Switch two-column templates to Bootstrap grid: Cataloging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 20044 There are two two-column cataloging templates which can be updated to use the Bootstrap grid. - cataloguing\editor.tt - cataloguing\additem.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 22584] New: Add YAML support for Codemirror
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Bug ID: 22584 Summary: Add YAML support for Codemirror Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- It would be great if YAML syntax support was available as we use it in a couple places, specially in plugin configurations. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 21942] New: Clean up cataloging merge template
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Bug ID: 21942 Summary: Clean up cataloging merge template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org There are a few minor markup issues with the cataloging merge template. -- You are receiving this mail because: You are watching all bug changes.

1 10