March 2019 - Koha-bugs - lists.koha-community.org

[Bug 19225] New: Warn on About page regarding sysprefs autoMemberNum and BorrowerMandatoryField
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19225 Bug ID: 19225 Summary: Warn on About page regarding sysprefs autoMemberNum and BorrowerMandatoryField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Display a warning on the About page if system preference automembernum is on and BorrowerMandatoryFields contains cardnumber. See Bug 18636 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636#c8 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 20937] New: PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937 Bug ID: 20937 Summary: PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The logic in the script is: if ( ( scalar(@emails_to_use) == 0 || $nomail ) && $PrintNoticesMaxLines && $j >= $PrintNoticesMaxLines ) So if we don't pass 'nomail' and the patron has an email, the items don't get kicked out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 22595] New: Items search is mixing inputs
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Bug ID: 22595 Summary: Items search is mixing inputs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Items search is using inputs and selects from search form to create an Ajax call. In this call selects are parsed before inputs. But a custom search field can be used with authorised values and used after a regular search field. In this case the "q" param is not ordered like the "name" param. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 22295] New: Elasticsearch - Advanced search should group terms entered in a single input
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22295 Bug ID: 22295 Summary: Elasticsearch - Advanced search should group terms entered in a single input Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com Target Milestone: --- This seems to be a difference in how Zebra and ES operate In Zebra a search like: ti:cats dogs will search for records with both 'cats' and 'dogs' in the title In ES the same search is treated as ti:cats _all:dogs because spaces end an index To perform the same search as Zebra, ES expects: ti:(cats dogs) For searching from the simple search bar this seems to be an issue of learning syntax. When using the advanced search, however, I would expect that two terms entered into a single box would both apply to the selected dropdown To recreate: 1 - Find two records - in the first add the words kangaroo and bucket to the title - in the second add kangaroo to title and bucket to publisher name 2 - in the search box try: - ti:kangaroo bucket - both titles returned - ti:bucket kangaroo - only first is returned - ti:(kangaroo bucket) - only first is returned - ti:(bucket kangaroo) - only first is returned 3 - From advanced search set an input dropdown to 'title' - bucket kangaroo - returns only the first - kangaroo bucket - returns both - (bucket kangaroo) - returns only the first - (kangaroo bucket) - returns only the first The parens in 3 reflect the expected behaviour (i think) and should be added by default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 22288] New: does not work in modifying items in batch
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 Bug ID: 22288 Summary: does not work in modifying items in batch Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: federicoantoniopaiz(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Target Milestone: --- Created attachment 84847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84847&action=ed… screen in going through txt the inventory ( Home › Tools › Batch item modification ), it gives me as a result : Can't use string ("0") as an ARRAY ref while "strict refs" in use at /usr/share/koha/intranet/cgi-bin/tools/batchMod.pl line 251, <$fh> line 69. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 18432] New: Most code comments assume male gender
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 Bug ID: 18432 Summary: Most code comments assume male gender Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Developer documentation Assignee: gmcharlt(a)gmail.com Reporter: ephetteplace(a)cca.edu QA Contact: testopia(a)bugs.koha-community.org Throughout the Koha codebase, the pronoun "he" is used to refer to a generic third person who could be of any gender. For instance, in C4/Suggestions.pm line #66: 'When a librarian manages the suggestion, he can set the status to "REJECTED" or "ACCEPTED".' That assumes all librarians are male. It's particularly problematic given that, in the US at least, the profession is heavily female. In other files, all borrowers are assumed to be male. In the interest of making the code base more inclusive, it'd be better to not assume a male gender. The patch—which touches *a lot* of disparate files but almost only comments—changes all instances of "he" or "him" I could find to "he or she" and "him or her" respectively. I'd also be in support of singular "they"/"their" in these situations if people prefer that. In a few cases, a non-human object was being referred to as "he", so I used "it" instead. FYI, the regex I used to find uses of the pronoun "he" and "him": - / (H|h)e (?!or she)/ - / (H|h)im (?!or her)/ I ignored "docs/history.txt" and "misc/release_notes" since those seem to refer to actual men who worked on Koha, and also the Maori translations. There were 3 "unimarc_framework_DEFAULT.sql" files also used "he" in a way that seemed to refer to a particular individual, though I'm not sure. Testing plan: - I can't really formulate a "testing plan" for this patch since it shouldn't impact actual executing code - The patch does touch strings in a few tests so at the very least these should continue to pass: M C4/SIP/t/06patron_enable.t M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt M t/db_dependent/Circulation.t M t/db_dependent/Koha/Patrons.t M t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes.

1 31

[Bug 21949] New: Error when searching for a patron
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21949 Bug ID: 21949 Summary: Error when searching for a patron Change sponsored?: --- Product: Koha Version: 18.11 Hardware: HP OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: sergeinik(a)tut.by QA Contact: testopia(a)bugs.koha-community.org When searching for a patrons, the page hangs, and the developer tool gives the following error on line 46: /** * http://www.openjs.com/scripts/events/keyboard_shortcuts/ * Version : 2.01.B * By Binny V A * License : BSD */ shortcut = { 'all_shortcuts':{},//All the shortcuts are stored in this array 'add': function(shortcut_combination,callback,opt) { //Provide a set of default options var default_options = { 'type':'keydown', 'propagate':false, 'disable_in_input':false, 'target':document, 'keycode':false } if(!opt) opt = default_options; else { for(var dfo in default_options) { if(typeof opt[dfo] == 'undefined') opt[dfo] = default_options[dfo]; } } var ele = opt.target; if(typeof opt.target == 'string') ele = document.getElementById(opt.target); var ths = this; shortcut_combination = shortcut_combination.toLowerCase(); //The function to be called at keypress var func = function(e) { e = e || window.event; if(opt['disable_in_input']) { //Don't enable shortcut keys in Input, Textarea fields var element; if(e.target) element=e.target; else if(e.srcElement) element=e.srcElement; if(element.nodeType==3) element=element.parentNode; if(element.tagName == 'INPUT' || element.tagName == 'TEXTAREA') return; } //Find Which key is pressed if (e.keyCode) code = e.keyCode; else if (e.which) code = e.which; //This ERROR!!! var character = String.fromCharCode(code).toLowerCase(); if(code == 188) character=","; //If the user presses , when the type is onkeydown if(code == 190) character="."; //If the user presses , when the type is onkeydown var keys = shortcut_combination.split("+"); //Key Pressed - counts the number of valid keypresses - if it is same as the number of keys, the shortcut function is invoked var kp = 0; //Work around for stupid Shift key bug created by using lowercase - as a result the shift+num combination was broken var shift_nums = { "`":"~", "1":"!", "2":"@", "3":"#", "4":"$", "5":"%", "6":"^", "7":"&", "8":"*", "9":"(", "0":")", "-":"_", "=":"+", ";":":", "'":"\"", ",":"<", ".":">", "/":"?", "\\":"|" } //Special Keys - and their codes var special_keys = { 'esc':27, 'escape':27, 'tab':9, 'space':32, 'return':13, 'enter':13, 'backspace':8, 'scrolllock':145, 'scroll_lock':145, 'scroll':145, 'capslock':20, 'caps_lock':20, 'caps':20, 'numlock':144, 'num_lock':144, 'num':144, 'pause':19, 'break':19, 'insert':45, 'home':36, 'delete':46, 'end':35, 'pageup':33, 'page_up':33, 'pu':33, 'pagedown':34, 'page_down':34, 'pd':34, 'left':37, 'up':38, 'right':39, 'down':40, 'f1':112, 'f2':113, 'f3':114, 'f4':115, 'f5':116, 'f6':117, 'f7':118, 'f8':119, 'f9':120, 'f10':121, 'f11':122, 'f12':123 } var modifiers = { shift: { wanted:false, pressed:false}, ctrl : { wanted:false, pressed:false}, alt : { wanted:false, pressed:false}, meta : { wanted:false, pressed:false} //Meta is Mac specific }; if(e.ctrlKey) modifiers.ctrl.pressed = true; if(e.shiftKey) modifiers.shift.pressed = true; if(e.altKey) modifiers.alt.pressed = true; if(e.metaKey) modifiers.meta.pressed = true; for(var i=0; k=keys[i],i<keys.length; i++) { //Modifiers if(k == 'ctrl' || k == 'control') { kp++; modifiers.ctrl.wanted = true; } else if(k == 'shift') { kp++; modifiers.shift.wanted = true; } else if(k == 'alt') { kp++; modifiers.alt.wanted = true; } else if(k == 'meta') { kp++; modifiers.meta.wanted = true; } else if(k.length > 1) { //If it is a special key if(special_keys[k] == code) kp++; } else if(opt['keycode']) { if(opt['keycode'] == code) kp++; } else { //The special keys did not match if(character == k) kp++; else { if(shift_nums[character] && e.shiftKey) { //Stupid Shift key bug created by using lowercase character = shift_nums[character]; if(character == k) kp++; } } } } if(kp == keys.length && modifiers.ctrl.pressed == modifiers.ctrl.wanted && modifiers.shift.pressed == modifiers.shift.wanted && modifiers.alt.pressed == modifiers.alt.wanted && modifiers.meta.pressed == modifiers.meta.wanted) { callback(e); if(!opt['propagate']) { //Stop the event //e.cancelBubble is supported by IE - this will kill the bubbling process. e.cancelBubble = true; e.returnValue = false; //e.stopPropagation works in Firefox. if (e.stopPropagation) { e.stopPropagation(); e.preventDefault(); } return false; } } } this.all_shortcuts[shortcut_combination] = { 'callback':func, 'target':ele, 'event': opt['type'] }; //Attach the function with the event if(ele.addEventListener) ele.addEventListener(opt['type'], func, false); else if(ele.attachEvent) ele.attachEvent('on'+opt['type'], func); else ele['on'+opt['type']] = func; }, //Remove the shortcut - just specify the shortcut and I will remove the binding 'remove':function(shortcut_combination) { shortcut_combination = shortcut_combination.toLowerCase(); var binding = this.all_shortcuts[shortcut_combination]; delete(this.all_shortcuts[shortcut_combination]) if(!binding) return; var type = binding['event']; var ele = binding['target']; var callback = binding['callback']; if(ele.detachEvent) ele.detachEvent('on'+type, callback); else if(ele.removeEventListener) ele.removeEventListener(type, callback, false); else ele['on'+type] = false; } } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 19630] New: "Hold is suspended" message appears in barcode field in holds table
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Bug ID: 19630 Summary: "Hold is suspended" message appears in barcode field in holds table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Created attachment 69169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69169&action=ed… Suspended hold message appears in barcode field In Intranet, when we suspend a hold, the message "hold is suspended" appears in a column titled "barcode". Even when the hold is not suspended, that column doesn't show the barcode. I'm guessing it's just a wording problem... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 21003] New: Don't show warning when editing a reserve item
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '19

15 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Bug ID: 21003 Summary: Don't show warning when editing a reserve item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Course reserves Assignee: kyle(a)bywatersolutions.com Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When editing an item in a course reserve, the following message always displays: This course already has this item on reserve. This appears out of place and should not display on edting. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 21018] New: OPAC Resource URL Broken if Tracklinks is enabled
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '19

15 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Bug ID: 21018 Summary: OPAC Resource URL Broken if Tracklinks is enabled Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: mkpelletier(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org With Tracklinks enabled in configuration (anonymous or otherwise), URI's in 952u return a koha 404 error. However, if the link is also recorded in 856u, the 952u link works. As soon as you turn off tracklinks, 952u URI's function normally. I tested the above only on https URI's. Perhaps this is related to #18714 earlier marked as invalid? -- You are receiving this mail because: You are watching all bug changes.

1 31