June 2019 - Koha-bugs - lists.koha-community.org

[Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '19

25 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 --- Comment #5 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 41551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41551 Bug 14680 - when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added. Review of attachment 41551: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=146…) ----------------------------------------------------------------- ::: acqui/addorderiso2709.pl @@ +178,5 @@ > my $c_quantity = shift( @quantities ) || GetMarcQuantity($marcrecord, C4::Context->preference('marcflavour') ) || 1; > my $c_budget_id = shift( @budgets_id ) || $input->param('all_budget_id') || $budget_id; > my $c_discount = shift ( @discount); > + if ($c_discount) { > + $c_discount =~ s/%//g; #This screws up number conversion badly If there is a % sign, then we know it is a percent. Is it possible to have a non-percent discount? If not, then this okay. If so, then this whole section of code is messed up. @@ +179,5 @@ > my $c_budget_id = shift( @budgets_id ) || $input->param('all_budget_id') || $budget_id; > my $c_discount = shift ( @discount); > + if ($c_discount) { > + $c_discount =~ s/%//g; #This screws up number conversion badly > + $c_discount =~ s/,/./g; #Make this an actual digit for Perl And what if they do something stupid like: 1,000,00? What if they include 1000's? 1,000,000,000.00? We need a nice function to guess at an unlocalized number. @@ +180,5 @@ > my $c_discount = shift ( @discount); > + if ($c_discount) { > + $c_discount =~ s/%//g; #This screws up number conversion badly > + $c_discount =~ s/,/./g; #Make this an actual digit for Perl > + $c_discount = $c_discount / 100 if $c_discount >= 1; This seems like duplicate and wrong code. @@ +186,1 @@ > $c_discount = $c_discount / 100 if $c_discount > 1; But as noted in the duplicate code above, I think the condition might need correcting ">= 1" or perhaps "> 0"? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23203] New: Add separate 'namespaces' for SCO and SCI for 'interface' columns
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '19

25 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23203 Bug ID: 23203 Summary: Add separate 'namespaces' for SCO and SCI for 'interface' columns Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- It would be nice if Koha's interface columns logged SCO and SCI actions in their own namespaces instead of just as 'opac' actions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 5287] Add floating toolbar to search results in OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '19

25 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #13 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- This breaks the selenium regression tests for removing items from your basket functionality. It only appears to break the tests however as I can't replicate the issue in real life. I've drawn a blank on the tests.. soliciting help from selenium gurus. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 23200] New: incorrect default mappings in pqf.properties means searching by item homebranch is impossible
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '19

25 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23200 Bug ID: 23200 Summary: incorrect default mappings in pqf.properties means searching by item homebranch is impossible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Defined indexes in pqf.properties must refer to a valid index in biblios/etc/bib1.att. Out of the box: * index.dc.branch is mapped to 1=1033 in pqf.properties * att 1033 is mapped to 'Host-item' in bib1.att * index.dc.branch should be mapped to 'homebranch' * att 8011 is mapped as 'homebranch' in bib1.att Given the above, pqf.properties should be updated to map index.dc.branch to 1=8011. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8451] Confusing and problematic double prompt for processing transfers
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #14 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- This has been address and corrected by https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15699] New: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Bug ID: 15699 Summary: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 5287] Add floating toolbar to search results in OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 --- Comment #12 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5287] Add floating toolbar to search results in OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 14228] fill in patron info by scanning an ID
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14228 Cheryl <clackman(a)fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman(a)fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I understand from comment 29 that Sonia disagrees with the behavior of this patch. -- You are receiving this mail because: You are watching all bug changes.

1 0