September 2019 - Koha-bugs - lists.koha-community.org

[Bug 17221] New: orphan comma in shelf browser
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Bug ID: 17221 Summary: orphan comma in shelf browser Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: ephetteplace(a)cca.edu QA Contact: testopia(a)bugs.koha-community.org Created attachment 54997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54997&action=ed… screenshot of bug Example screenshot attached, here's the bib record in our catalog: https://library.cca.edu/cgi-bin/koha/opac-detail.pl?biblionumber=21729&shel… Basically, since starting_homebranch is null in the template file, nothing is printed out, but the next IF condition wrongly assumes that the first must have been true and prints out a comma before it's text string. Steps to recreate: - in settings, set ShelfBrowserUsesHomeBranch to "Don't Use" - set ShelfBrowserUsesLocation to "Use" - visit an item, click the "Browse shelf" link in the Holdings' tab's Call Number column - note the extraneous comma in the <h5> tag that appears Patch coming shortly, it appears that simply adding an additional condition around the comma itself should resolve this problem. -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 18933] New: Unable to set SMS number in OPAC messaging preferences to empty
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933 Bug ID: 18933 Summary: Unable to set SMS number in OPAC messaging preferences to empty Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org This is inconsistent with the Staff Client side, where the SMS number can be set to empty. Also I think that since this is borrower information, it should be their choice whether they provide this info or not and should have the ability to remove it -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 18230] New: Generate Koha::Patron:: Modification verification_token in ->new
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18230 Bug ID: 18230 Summary: Generate Koha::Patron::Modification verification_token in ->new Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: lari.taskula(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org Currently verification_token is generated outside of the class. Move this logic into Koha::Patron::Modification->new. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 17424] New: REST API: Preference to control access to own objects without permission
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17424 Bug ID: 17424 Summary: REST API: Preference to control access to own objects without permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org Introduce a preference to enable/disable access to own objects for patron's without required permissions. Bug 14868 added "allow-owner" parameter that allows owner of the object to perform operations on themselves even if they do not have required permissions to otherwise do so (e.g. get own patron data or renew your own checkouts even if you don't have borrowers/circulating permissions). This means patrons can perform basic OPAC operations via REST API. However, there should be an option to disable this functionality; as Katrin pointed out in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895#c43 , > I can imagine both happening: > - libraries wanting to shut down any OPAC account functionality, but still > be able to renew in staff, so the circulation conditions are set up this > way. In this case, there should be a way to lock the API (opacuserlogin > might be a way) > - libraries shutting down the OPAC, because they use something else like an > external discovery layer. In this case they'd still want to use the API, but > might turn off the OPAC as far as possible. I propose a system preference for enabling/disabling access to own objects in REST API. This way libraries can disable opacuserlogin and any OPAC API functionality with the new preference. In the second case, libraries can disable opacuserlogin but still allow OPAC functionality via REST API. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 17479] New: REST API: Save information on owner access
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 Bug ID: 17479 Summary: REST API: Save information on owner access Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org There are two ways of accessing a resource via REST API; either: - you have the required permission - you do not have the permission but you are owner of the object, e.g. you want to GET your own patron information In many cases we want to perform additional operations if the user is accessing his own object. Usually this additional operation is checking a system preference. Example: Patron wants to update his own patron information via REST API. We have to check OPACPatronDetails system preference for this. If it is on, we should forward the changes for approval from a librarian. Currently, in controller, we can check this opac-like access by checking that the user does not have permissions and that the patron he is accessing is himself. This would require another haspermission() call. Instead, we could set a flag into $c->stash in Koha/REST/V1.pm in the case of ownership access. After this, in controller, we only need to check $c->stash for this flag. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22

[Bug 23427] New: Better sorting of previous checkouts
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Bug ID: 23427 Summary: Better sorting of previous checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In patron circulation or details page, previous checkouts are displayed sorted by due date. Actual sort order is not honoring system preference "previousIssuesDefaultSortOrder". Todays's checkouts is correct thanks to Bug 13908. Many checkouts may have same due date so it would be better to sort on timestamp as second sort criteria, like todays's checkouts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 21126] New: Vendor Physical address: Filels does not correspond to db colums
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21126 Bug ID: 21126 Summary: Vendor Physical address: Filels does not correspond to db colums Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: black23(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Interface at aqusition vendor details, fild Physical Address allow add unlimited number of lines. More that 4 lines are cutted. http://prntscr.com/kbnuan Only first 4 lines are linked into database columns Interface should be improved: Physical address offer 4 form fields that correcopnd to address1, address2, address3, address4 at table aqbooksellers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 21296] New: suspend hold ignores system preference on intranet
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '20

16 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Bug ID: 21296 Summary: suspend hold ignores system preference on intranet Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: bwsdonna(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Setting the system preference SuspendHoldsIntranet to Don't Allow has no impact. Staff can still suspend patron holds from the staff client. To test: 1. Set SuspendHoldsIntranet to Don't Allow 2. Set SuspendHoldsOPAC to Allow 3. Log in to OPAC and place hold 4. Log in to staff client and pull up patron's account 5. View holds and suspend hold. 6. Date picker window opens and allows suspension of hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 23306] New: fines amount showing zero
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '20

15 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23306 Bug ID: 23306 Summary: fines amount showing zero Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: sunitabarve(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 91480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91480&action=ed… circulation of the item does not show fine amount the circulation details of a borrower showing fines amount zero and amount is shown in price. why fines amount is not visible for every borrower. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 22798] New: Double quote included in Publisher search on tag 264
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '20

15 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22798 Bug ID: 22798 Summary: Double quote included in Publisher search on tag 264 Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbutosi(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 88989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88989&action=ed… Field 264 double-quotes On the OPAC, if a user clicks on the hyperlinked Publisher value in the bibliographic record, a double-quote is appended to the search url if the publication value is catalogued in field 264, thus breaking the search. For example: http://library.craigbutosi.ca/cgi-bin/koha/opac-search.pl?q=Provider:Verso%… instead of http://library.craigbutosi.ca/cgi-bin/koha/opac-search.pl?q=Provider:Verso%… The double-quote does not appear in records in which publication data is entered in field 260, thus search succeeds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3