January 2020 - Koha-bugs - lists.koha-community.org

[Bug 24468] New: C4::Reserves::_get_itype is no longer used
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Bug ID: 24468 Summary: C4::Reserves::_get_itype is no longer used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 21206 Since bug 21206, C4::Reserves::_get_itype is not longer used and should be removed. commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 [Bug 21206] C4::Items - Remove GetItem -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 21800] New: TransformKohaToMarc should respect non-repeatability of item subfields
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Bug ID: 21800 Summary: TransformKohaToMarc should respect non-repeatability of item subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org See the discussion on bug 21774 which refers back to adjustments by 10306. But actually Koha did never check if an item subfield is repeatable or not. Just put two barcodes and a pipe in the barcode field, save and open again and the barcode field is duplicated in the editor. This is before 18.05. And also after fix 21774 on 18.11 (if pushed which should). So how do we resolve the issue while 19096 removed the frameworkcode because it was no longer needed for Koha to Marc mappings? That is what we should solve here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 45

[Bug 24464] New: Add K::A::Basket->creator
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 Bug ID: 24464 Summary: Add K::A::Basket->creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com We need an accessor to fetch the Koha::Patron for the basket creator (a.k.a. authorisedby on the DB). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 24463] New: Consistent accessor-relationship naming for basket_group in Basket.pm
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Bug ID: 24463 Summary: Consistent accessor-relationship naming for basket_group in Basket.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We agreed there needs to be consistency. This will be a blocker for dealing with related data from the API (prefetching, filternig, etC). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 22025] New: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for /usr/share/koha/bin/import_patrons.pl
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025 Bug ID: 22025 Summary: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for /usr/share/koha/bin/import_patrons.pl Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: mjnkml(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Target Milestone: --- When running: > sudo koha-shell -v -c "/usr/share/koha/bin/import_patrons.pl --file /home/kohasync/incomingfile/borrowers.csv --matchpoint userid --confirm --overwrite --verbose" our_instance_name We get a bunch of: > Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle> line 490. per import row. When I add some say STDERR lines just before it, I get: > Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1019, <$handle> line 490. > OLD: 0, NEW: , COL: lost > > Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1019, <$handle> line 490. > OLD: 0, NEW: , COL: privacy_guarantor_checkouts > > Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1019, <$handle> line 490. > OLD: 0, NEW: , COL: lost > None of those fields (privacy_guarantor_checkouts, lost, etc.) are included in the CSV import. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 24436] New: Record if a transfer was triggered by a 'reserve'
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 Bug ID: 24436 Summary: Record if a transfer was triggered by a 'reserve' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, koha-bugs(a)lists.koha-community.org, kyle.m.hall(a)gmail.com, testopia(a)bugs.koha-community.org Depends on: 24297, 24299 Blocks: 4234, 23092 Using the new 'trigger' field in branchtransfers to record if a transfer was added by a reserve. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297 [Bug 24297] Record if a transfer was triggered 'manually' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 [Bug 24299] Record if a transfer was triggered by 'rotating collections' -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 22821] New: Patron notes about item email notification fallback order is incorrect
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Bug ID: 22821 Summary: Patron notes about item email notification fallback order is incorrect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- In bug 19496 a fallback order for the email addresses (both to and from) was added. This fallback order appears to be incorrect per my understanding of the system preferences. > my $to_address = $branch->branchemail || $branch->branchreplyto || C4::Context->ReplytoDefault || C4::Context->preference('KohaAdminEmailAddress'); My understanding is that branchemail is used for the 'from' address in emails from the branch, however it may not be an address which is accessible by the librarians (as to be allowed through spam filters for most popular email service the 'from' address domain has to match the domain of the sender server).. as such 'reply-to' address was added to allow for a library to send 'from' a proper domain but have 'replies' go to an email address they control. > my $from_address = $patron->email || $patron->emailpro || $patron->B_email; We cannot spoof send emails from the patrons email address for the same reasons as outlined above. The email must come from the koha system but may happily contain the above fallback in the reply-to header to achieve what I believe is wanted. -- You are receiving this mail because: You are watching all bug changes.

1 55

[Bug 24495] New: Reword change collection feature
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495 Bug ID: 24495 Summary: Reword change collection feature Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org We've had several libraries contact us with confusion over the new change collection feature. Apparently the wording on "Amount paid" and "Collect from patron" is not broadly intuitive. Opening this to consider alternate wording. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 17421] New: Missing dependency on CGI::Emulate::PSGI
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17421 Bug ID: 17421 Summary: Missing dependency on CGI::Emulate::PSGI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt(a)gmail.com Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org I just tried to do a plackup (the Plack utility not plackup.sh) and got an error that CGI::Emulate::PSGI wasn't installed. I'm thinking we should add that to Koha's Perl dependencies. Looking at Debian (https://packages.debian.org/sid/perl/libplack-perl) it looks like the package is recommended but not required. Actually, I don't notice it in https://github.com/Koha-Community/Koha/blob/master/debian/control either... I'm using Plack v1.0037 whereas Jessie is at v1.0033-1... It's required by Plack::App::WrapCGI, which uses it in v1.0033: https://metacpan.org/source/MIYAGAWA/Plack-1.0033/lib/Plack/App/WrapCGI.pm -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 24066] New: Koha::Patron->has_permission has no POD
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066 Bug ID: 24066 Summary: Koha::Patron->has_permission has no POD Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org As the title says, Missing POD for Koha::Patron object. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15