January 2020 - Koha-bugs - lists.koha-community.org

[Bug 19676] New: Debian 9 vs. Plack vs. / tmp -- attention to PrivateTmp for apache2
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '20

06 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19676 Bug ID: 19676 Summary: Debian 9 vs. Plack vs. /tmp -- attention to PrivateTmp for apache2 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: januszop(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Beware: in Debian 9 apache2 comes with PrivateTmp enabled by default. As a consequence, there are issues when Plack is enabled for an instance, but in Koha there is an interaction between Plack enabled and Plack blacklisted stuff through /tmp directory. Plack-ed scripts will write temporary files in "real" /tmp directory (as pointed by Koha::UploadedFile::temporary_directory, i.e. File::Spec->tmpdir) whereas Plack blacklisted scripts will understand /tmp as private tmp of apache2, i.e. /tmp/systemd-private-?????????-apache2.service-????/tmp. This happens for instance for stage-marc-import.pl -- in step 2 the script won't find the marc file uploaded in step 1. The simplest instant solution to this would be to disable PrivateTmp for apache2 (this article gives a clue: https://www.maxoberberger.net/blog/2017/10/debian-9-private-tmp.html) but maybe there is a better option? (When Plack is disabled everything seems to work fine apart of the fact that the private tmp of apache2 is being used.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 24477] New: No permissions check for POS feature
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477 Bug ID: 24477 Summary: No permissions check for POS feature Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org At the moment it appears that POS can be used without any permission - This means a patron with no permissions can access the page! my ( $template, $loggedinuser, $cookie, $user_flags ) = get_template_and_user( { template_name => 'pos/pay.tt', query => $q, type => 'intranet', authnotrequired => 0, } ); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 24093] New: Sorting indicators broken on list contents view
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Bug ID: 24093 Summary: Sorting indicators broken on list contents view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 23013 Bug 23013 removed some images files which were a dependency for the our previous implementation of DataTables. These image files were being used to indicate the (server-side) sorting direction of the lists contents view. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 [Bug 23013] Upgrade DataTables in the staff client -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 24169] New: Advanced editor: icons/buttons for sorting the search results are missing
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Bug ID: 24169 Summary: Advanced editor: icons/buttons for sorting the search results are missing Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: carnold(a)dgiinc.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl After 19.11 the sorting icons for the search results disappeared. The search still works if you click on the header of the column, but the icons are gone. 19.05: https://paste.pics/8694b71e22504d77439b877166ca5e77 19.11: https://paste.pics/301f28373f9fc57756e401855fcb063b -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 24255] New: Add totals methods Koha::Account::Lines
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255 Bug ID: 24255 Summary: Add totals methods Koha::Account::Lines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: kyle(a)bywatersolutions.com, testopia(a)bugs.koha-community.org, tomascohen(a)gmail.com Blocks: 23442 Add missing summation methods to the Koha::Account::Lines class. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 24554] New: Only embed relations from Koha::Biblio in to_api
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554 Bug ID: 24554 Summary: Only embed relations from Koha::Biblio in to_api Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com The current implemented behaviour of this method (fallback to the biblioitems relations) breaks using it with bug 24538. On fixing it, I noticed the method is quite over-engineered. As biblioitems is not a real entity on the API and we are not going to add related tables to bilbioitems (most probably get it merged into biblio) we don't need the pass-through of embeds into the biblioitem object. This makes counts work, and also makes sense :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 24366] New: Merging biblioitems should happen in Koha::Biblio->to_api
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 Bug ID: 24366 Summary: Merging biblioitems should happen in Koha::Biblio->to_api Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com Now we can embed objects, we need to make sure the JSON representation of a biblio object (which includes information from biblioitems) is generated in Koha::Biblio->to_api instead of the API controller. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 24482] New: Purchase Items broken by costs containing a comma
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Bug ID: 24482 Summary: Purchase Items broken by costs containing a comma Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com To test: - enable cash registers and point of sale - create a purchase item with a cost of $1000 - go to Point of Sale and attempt to sell one of your item - Note that Koha inserts a comma into the price and breaks its own math in calculating the amount due -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 22933] New: Support for FIDO WebAuthn (passwordless)
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '20

04 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22933 Bug ID: 22933 Summary: Support for FIDO WebAuthn (passwordless) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: black23(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Target Milestone: --- What do you mean about support for WebAuthn for staff? No Password, just USB token and touch. Nice demo and test: https://webauthn.me/ https://webauthn.io/ Demo code Javascript https://github.com/fido-alliance/webauthn-demo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 16758] New: Caching issues in scripts running in daemon mode
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Bug ID: 16758 Summary: Caching issues in scripts running in daemon mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: abl(a)biblos.pk.edu.pl QA Contact: testopia(a)bugs.koha-community.org As L1 cache does not have expiration mechanism, scripts running in daemon mode (rebuild_zebra.pl -daemon, sip server ?, ...) would not be aware of any possible changes in the data being cached in Koha::Cache. While adding expiration functionality to Koha::Cache would be pretty simple, I guess we don't really want to expire things by default after a given amount of seconds, that would not be good for overall performance; default expiration time for L2 = memcached is infinite (intentionally). Note that it's also infinite for L2 = Cache::Memory - probably not intentional, more likely that's because this code # Default cache time for memory is _always_ short unless it's specially # defined, to allow it to work reliably in a persistent environment. my $cache = Cache::Memory->new( 'namespace' => $self->{'namespace'}, 'default_expires' => "$self->{'timeout'} sec" || "10 sec", ); doesn't work as advertised. That might be a problem for plack + Cache::Memory setups - hopefully nobody uses such weird combos. Anyway, that belongs to the separate bug report. I wonder what would be a best approach for solving this issue for perpetually running scripts? Maybe just adding a function to Koha::Cache which flushes L1 cache (but not more often then each 10 | 20 | 30 seconds), and call it in rebuild_zebra.pl etc. daemon loop - ? -- You are receiving this mail because: You are watching all bug changes.

1 33