November 2020 - Koha-bugs - lists.koha-community.org

[Bug 25549] New: Install plugin script/method should remove broken plugins
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 Bug ID: 25549 Summary: Install plugin script/method should remove broken plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org bug 23191 added a script to allow installation of plugins from the command line. There can be an issue when a plugin no longer compiles after an upgrade, Koha will not load, the script will not run either. We should repair the script so that it can remove plugin methods that no longer function or have been deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 34

[Bug 26496] New: Budget Plan save button doesn't save plans
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 Bug ID: 26496 Summary: Budget Plan save button doesn't save plans Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org Bug 16754 removed the "op" input from the Budget Plan (ie /cgi-bin/koha/admin/aqplan.pl), so clicking "Save" doesn't do anything anymore. I'm actually surprised that no one else has noticed this over the last 4 years... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 29

[Bug 20804] New: Sanitize input of timeout syspref
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20804 Bug ID: 20804 Summary: Sanitize input of timeout syspref Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: pablo.bianchi(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com I naively change timeout syspref from default "1d" to "2h". I get logout immediatly, and after login again, at the first clic I was logged out again, with any user, even with koha_instance. plack-error.log Use of uninitialized value $lasttime in numeric lt (<) at /usr/share/koha/lib/C4/Auth.pm line 1425. Argument "2h" isn't numeric in subtraction (-) at /usr/share/koha/lib/C4/Auth.pm line 1425. Argument "2h" isn't numeric in subtraction (-) at /usr/share/koha/lib/C4/Auth.pm line 862. I was back again with via sql update (value='1d') and flushing memcached. I suggest: - Don't been possible to input an invalid input on timeout (well, on any, but for the moment on this one). m/^[0-9]*[dD]?$/ - This syspref (maybe others also) shouldn't apply to koha_instance user (God shouldn't be able to microwave a burrito so hot he himself couldn't eat it). Would be great 30m and 2h for minutes and hours, but that should be other bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 26589] New: t/db_dependent/OAI/Sets.t unit test fails due to OAI-PMH:AutoUpdateSets syspref
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26589 Bug ID: 26589 Summary: t/db_dependent/OAI/Sets.t unit test fails due to OAI-PMH:AutoUpdateSets syspref Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: alexbuckley(a)catalyst.net.nz Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org When the OAI-PMH:AutoUpdateSets syspref is disabled the t/db_dependent/OAI/Sets.t unit tests all pass successfully. But when the syspref is enabled then the unit test fail with this error: t/db_dependent/OAI/Sets.t .. 1/147 C4::OAI::Sets::AddOAISetsBiblios(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry '39-46' for key 'PRIMARY' [for Statement " INSERT INTO oai_sets_biblios (set_id, biblionumber) VALUES (?,?) " with ParamValues: 0='46', 1=39] at t/db_dependent/OAI/Sets.t line 372 # Looks like your test exited with 255 just after 100. t/db_dependent/OAI/Sets.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 47/147 subtests -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com QA Contact| |josef.moravec(a)gmail.com Status|Signed Off |Passed QA --- Comment #41 from Josef Moravec <josef.moravec(a)gmail.com> --- I do really like to see this bug fixed. - QA tools passed. - Behaviour is correct. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26604] New: "Generate next" button gives error on serials-collection.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 Bug ID: 26604 Summary: "Generate next" button gives error on serials-collection.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com In serials-collection.pl, the line $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity}); causes the error Can't use string ("13") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Serials.pm line 2198. This function call makes no sense, that subroutine always returns a list and doesn't take any parameters. I think it was meant to be GetSubscriptionFrequency which is in fact already called a few lines down. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 27

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113683|0 |1 is obsolete| | --- Comment #40 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 113692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113692&action=e… Bug 7607: (follow-up) Disable rather than remove inputs Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113682|0 |1 is obsolete| | --- Comment #39 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 113691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113691&action=e… Bug 7607: Remove empty inputs when submitting search form This patch surrounds the operator, index, and query fields on the advanced search page wtih a 'search_set' class. This allows us to process them as a group and confirm the query is populated before submitting the other parts to the form TO test: 1 - Go to advanced search 2 - Use search boxes to search like: Title: (leave blank) Author: clinton keyword: shuffle 3 - Perform search 4 - Note no results as you searched for title:clinton etc. 5 - apply patch 6 - refresh and repeat 7 - search is now correct 8 - Try vaeious searches with 'more options' and selecting different operators Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Cook <dcook(a)prosentient.com.au> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26191] New: Relocate track_login call in Auth.pm (see 22543)
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26191 Bug ID: 26191 Summary: Relocate track_login call in Auth.pm (see 22543) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org >From bug 22543 comment30: (In reply to Jonathan Druart from comment #29) > 2. This code has been put before track_login_daily, is that expected? No. The track call should be done before. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 25511] New: Add --force option to update_dbix_class_files.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25511 Bug ID: 25511 Summary: Add --force option to update_dbix_class_files.pl Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Sometimes, if you know what you are doing, you may want to force a schema overwrite regardless of whether the hashes report there are changes above the fold. In these cases, we should expose said functionality via a --force option on the script. WARNING: Use this at your own risk.. it's helpful if you are maintaining a fork or in other such cases. You should always attempt to run the script without force first and only resort to using force if that fails. It is also very much worthwhile checking the diff after running with force to ensure you have not resulted in any unexpected changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15