December 2020 - Koha-bugs - lists.koha-community.org

[Bug 23947] New: Phase out jquery.cookie.js: Authority merge
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '21

22 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947 Bug ID: 23947 Summary: Phase out jquery.cookie.js: Authority merge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 23944 The authority merge process sets cookes to track which records are being merged. This process should use the newer cookie library, js-cookie. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 26307] New: misc/cronjobs/update_patrons_category.pl --too_old acts a year too early
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '21

22 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 Bug ID: 26307 Summary: misc/cronjobs/update_patrons_category.pl --too_old acts a year too early Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz misc/cronjobs/update_patrons_category.pl --too_old must change category when the age of the patron is greater than (exclusive) limit age of the category. Actually it changes a year too early : he goes to a min 18 years category having reached 17 years. Looks like the test suite is wrong not strong enought on Koha::Patrons->search_patrons_to_update_category(). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 26943] New: Show not for loan descriptions in cataloging search (addbooks.pl)
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '21

21 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Bug ID: 26943 Summary: Show not for loan descriptions in cataloging search (addbooks.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl To recreate: - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column We should show the actual display values here, rather than collapsing all positive values into "not for loan" and all negative values into "on order." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 24

[Bug 25632] New: Update MARC21 frameworks to update Nr. 30 (May 2020)
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '21

21 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25632 Bug ID: 25632 Summary: Update MARC21 frameworks to update Nr. 30 (May 2020) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: bgkriegel(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org A few changes in bibliographic data format. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 27154] New: Koha/Util/SystemPreferences.pm must be removed
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '21

21 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154 Bug ID: 27154 Summary: Koha/Util/SystemPreferences.pm must be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: nick(a)bywatersolutions.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org On bug 15494, the same method "get_yaml_pref_hash" has been added to two modules, Koha/Config/SysPref.pm and Koha/Util/SystemPreferences.pm? Koha/Config/SysPref.pm:sub get_yaml_pref_hash { Koha/Util/SystemPreferences.pm:sub get_yaml_pref_hash { We should remove the whole Koha/Util/SystemPreferences.pm package. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 18146] New: C4:: Circulation CanBookBeRenewed lacks full test coverage.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18146 Bug ID: 18146 Summary: C4::Circulation CanBookBeRenewed lacks full test coverage. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com While testing bug 17941, I discovered two cases where test coverage was lacking from t/db_dependent/Circulation.t Around line 2725: if ( $restricted and $restrictionblockrenewing ) { return ( 0, 'restriction'); } elsif ( ($hasoverdues and $overduesblockrenewing eq 'block') || ($itemissue->{overdue} and $overduesblockrenewing eq 'blockitem') ) { return ( 0, 'overdue'); } The elseif is never triggered. Around line 2759: if ( $soonestrenewal > DateTime->now( time_zone => C4::Context->tz() ) ) { return ( 0, "auto_too_soon" ) if $itemissue->{auto_renew}; return ( 0, "too_soon" ); } elsif ( $itemissue->{auto_renew} ) { return ( 0, "auto_renew" ); } There is no else, but the code never attempts something that would trigger one. To reproduce add: print STDERR "CHECK!\n"; just before the return ( 0, 'overdue') in the first case, and after the elsif's curly brace in the second case. running t/db_dependent/Circulation should not generate the CHECK points. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 27289] New: Template tweaks for point of sale page
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '21

18 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Bug ID: 27289 Summary: Template tweaks for point of sale page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 23354 I have a couple of minor updates for the point of sale page: - buttons inside tables should use "btn-xs" to be a consistent size - required fields in the "Collect payment" form should be styled as required Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments -- You are receiving this mail because: You are watching all bug changes.

1 31

[Bug 27290] New: Cash register allows for 'amount tendered' less than amount being paid
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '21

18 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Bug ID: 27290 Summary: Cash register allows for 'amount tendered' less than amount being paid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It seems amount tendered is only used to calculate change - if there is a value for the change then there is a confirmation. If there isn't then the transaction simply goes through To test: 1 - Enable 'useCashRegisters' and 'EnablePointofSale' 2 - Add a cash register 3 - Add a debit type that can be sold 4 - Go to point of sale and sell the item multiple times 5 - Enter 'Amount tendered' less than amount being paid 6 - Click confirm 7 - Transaction is processed as if full funds received 8 - Try with a negative number - goes through again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 33

[Bug 22713] New: Replacement price removed when receiving if using MarcItemFieldstoOrder
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Bug ID: 22713 Summary: Replacement price removed when receiving if using MarcItemFieldstoOrder Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: nick(a)bywatersolutions.com Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 88048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88048&action=ed… replacement price in item record acq process In 18.11 the wording and functionality changed in Acquisitions with the field Replacement price. This allowed libraries to have their replacement price set in the Acquisitions order and also in the item record. However, if a library is using MarcItemFieldstoOrder system preference and setting their replacement price in the marc record upon Importing. The replacement price only stays on the Item Record and will not be included into the Acquisitions order and it won't populate into the receiving process- and therefore making it $0. It would be nice if the item record had the replacement price from the MarcItemFieldstoOrder, and this would follow it through the process and since it is there in the item, it be used in the Order. Process currently: 1. Set marcitemfieldstorder to have a $v replacement price (975$v) 2. Create a basket 3. Upload a marc file that has a replacement price in the record 4. Add this file to your basket. 5. The item record will display the replacement price. 6. The basket.pl will not display the replacement price of this item 7. CLose the basket 8. When receiving the item in Acquisitions, the replacement price is zeroed out 9. The item will not have a replacement price once it is received. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 25954] New: Header search forms should be labeled
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '21

16 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Bug ID: 25954 Summary: Header search forms should be labeled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The markup for the header search forms in the staff interface use a <p> tag to show descriptive text about the form. For instance: <p class="tip">Enter patron card number or partial name:</p> In most cases this can be replaced with a label: <label class="tip" for="findborrower">Enter patron card number or partial name:</label> This will improve accessibility and eliminate errors raised by WCAG checks. -- You are receiving this mail because: You are watching all bug changes.

1 45