February 2020 - Koha-bugs - lists.koha-community.org

[Bug 24093] New: Sorting indicators broken on list contents view
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Bug ID: 24093 Summary: Sorting indicators broken on list contents view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 23013 Bug 23013 removed some images files which were a dependency for the our previous implementation of DataTables. These image files were being used to indicate the (server-side) sorting direction of the lists contents view. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 [Bug 23013] Upgrade DataTables in the staff client -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 24169] New: Advanced editor: icons/buttons for sorting the search results are missing
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Bug ID: 24169 Summary: Advanced editor: icons/buttons for sorting the search results are missing Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: carnold(a)dgiinc.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl After 19.11 the sorting icons for the search results disappeared. The search still works if you click on the header of the column, but the icons are gone. 19.05: https://paste.pics/8694b71e22504d77439b877166ca5e77 19.11: https://paste.pics/301f28373f9fc57756e401855fcb063b -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 24255] New: Add totals methods Koha::Account::Lines
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255 Bug ID: 24255 Summary: Add totals methods Koha::Account::Lines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: kyle(a)bywatersolutions.com, testopia(a)bugs.koha-community.org, tomascohen(a)gmail.com Blocks: 23442 Add missing summation methods to the Koha::Account::Lines class. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 24647] New: PDF::API2::Simple is declared as a required dependency but it is not used
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 Bug ID: 24647 Summary: PDF::API2::Simple is declared as a required dependency but it is not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org `git grep PDF::API2::Simple` returns only one occurence, in cpanfile. `git log -S PDF::API2::Simple` returns a few commits that move around the declaration of dependencies, and the commit https://github.com/Koha-Community/Koha/commit/e418db57f9544983a004b6a7b7f79… that introduces this dependency without using it. So it looks like it has been a required dependency for 10 years, without ever being used. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 24592] New: Clarify LOST_RETURN process by using FOUND over RETURNED
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Bug ID: 24592 Summary: Clarify LOST_RETURN process by using FOUND over RETURNED Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org The phrasing of LOST_RETURN is confusing, the item is not always immediately returned, sometimes it is renewed for example.. I think it would be clearer to reword this to use 'FOUND' to more clearly reflect the states.. I intend to do this in the accounts handling as well as rename the _FixAccountForLostAndReturned method in C4::Circulation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 24611] New: wrong budget_id query parameter in /acquisitions/orders
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Bug ID: 24611 Summary: wrong budget_id query parameter in /acquisitions/orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com Between the writing time of the endpoint (2017) and the time it was refactored and pushed, attribute mappings were introduced, and the query parameters didn't get enough attention so it still refers to budget_id. We need to fix it! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 24554] New: Only embed relations from Koha::Biblio in to_api
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554 Bug ID: 24554 Summary: Only embed relations from Koha::Biblio in to_api Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com The current implemented behaviour of this method (fallback to the biblioitems relations) breaks using it with bug 24538. On fixing it, I noticed the method is quite over-engineered. As biblioitems is not a real entity on the API and we are not going to add related tables to bilbioitems (most probably get it merged into biblio) we don't need the pass-through of embeds into the biblioitem object. This makes counts work, and also makes sense :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 24366] New: Merging biblioitems should happen in Koha::Biblio->to_api
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 Bug ID: 24366 Summary: Merging biblioitems should happen in Koha::Biblio->to_api Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com Now we can embed objects, we need to make sure the JSON representation of a biblio object (which includes information from biblioitems) is generated in Koha::Biblio->to_api instead of the API controller. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 24482] New: Purchase Items broken by costs containing a comma
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Bug ID: 24482 Summary: Purchase Items broken by costs containing a comma Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com To test: - enable cash registers and point of sale - create a purchase item with a cost of $1000 - go to Point of Sale and attempt to sell one of your item - Note that Koha inserts a comma into the price and breaks its own math in calculating the amount due -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 24602] New: The fallback value for onshelfholds should be 0
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 Bug ID: 24602 Summary: The fallback value for onshelfholds should be 0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The onshelfholds circulation rules values are more of an ENUM type (as opposed to other rules with integers like max*qty). In the quantities cases, it makes sense to have undef mean unlimited. In the enum type it is clearer to just set a default value (0) as the code already expects (Note: undef and 0 both eval to false so there's no behaviour problem, but warnings or we get forced to check for defined when the rule is used. It seems trivial to just make the rule fallback to a chosen default value) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15