March 2020 - Koha-bugs - lists.koha-community.org

[Bug 23384] New: Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Bug ID: 23384 Summary: Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org After spending a while digging into this, I can't explain why it's a problem, but I know that it is and I know how to fix it. During the development of Bug 23112 I encountered a weird problem whereby adding "use Illrequests" to C4/Circulation.pm causes the whole of the app to break with the following error: Bareword "Koha::ArticleRequest::Status::Pending" not allowed while "strict subs" in use at /home/koha-koha/kohaclone/Koha/Patron.pm line 811. Bareword "Koha::ArticleRequest::Status::Processing" not allowed while "strict subs" in use at /home/koha-koha/kohaclone/Koha/Patron.pm line 811. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Illrequest.pm line 37. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Illrequest.pm line 37. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Illrequests.pm line 23. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Illrequests.pm line 23. Compilation failed in require at /home/koha-koha/kohaclone/C4/Circulation.pm line 49. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Circulation.pm line 49. Compilation failed in require at /home/koha-koha/kohaclone/C4/Overdues.pm line 31. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Overdues.pm line 31. Compilation failed in require at /home/koha-koha/kohaclone/C4/Members.pm line 32. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Members.pm line 32. Compilation failed in require at /home/koha-koha/kohaclone/C4/Letters.pm line 30. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Letters.pm line 30. Compilation failed in require at /home/koha-koha/kohaclone/C4/Suggestions.pm line 29. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Suggestions.pm line 29. Compilation failed in require at /home/koha-koha/kohaclone/C4/Acquisition.pm line 25. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Acquisition.pm line 25. Compilation failed in require at /home/koha-koha/kohaclone/C4/Budgets.pm line 27. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Budgets.pm line 27. Compilation failed in require at /home/koha-koha/kohaclone/C4/Biblio.pm line 94. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Biblio.pm line 94. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Biblio.pm line 27. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Biblio.pm line 27. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Biblios.pm line 26. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Biblios.pm line 26. Compilation failed in require at /home/koha-koha/kohaclone/Koha/ArticleRequest.pm line 26. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/ArticleRequest.pm line 26. Compilation failed in require at /home/koha-koha/kohaclone/Koha/ArticleRequests.pm line 26. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/ArticleRequests.pm line 26. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Patrons.pm line 28. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Patrons.pm line 28. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Item.pm line 33. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Item.pm line 33. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Items.pm line 26. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Items.pm line 26. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Checkout.pm line 28. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Checkout.pm line 28. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Checkouts.pm line 25. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Checkouts.pm line 25. Compilation failed in require at /home/koha-koha/kohaclone/C4/Auth.pm line 37. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Auth.pm line 37. Compilation failed in require at /home/koha-koha/kohaclone/admin/preferences.pl line 23. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/admin/preferences.pl line 23. The reference to "preferences.pl" is a red herring and just reflects the page you're on at the time. The rest of the error is the same regardless of the page. Poking around, I've not been able to determine why the usage of Illrequest in Circulation.pm would cause Patron.pm to suddenly complain about Koha::ArticleRequest::Status::* calls being barewords. With Modern::Perl the strict subs pragma should catch that sort of stuff. So I've really got no idea what's going on. Anyway, the obvious fix is to add "use Koha::ArticleRequest::Status;" to Patron.pm, which is what the patch for this bug is going to do. I just wish I understood why it's a problem in the first place! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 24788] New: Koha::Object->store calls column names as methods, relying on AUTOLOAD, with possibly surprising results
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788 Bug ID: 24788 Summary: Koha::Object->store calls column names as methods, relying on AUTOLOAD, with possibly surprising results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Koha::Object->store accesse sDBIx::Class::Row columns as $self->$col, using AUTOLOAD, which in effect makes column names and methods share the same namespace. I'm no security expert, but I think this should be considered bad practice and could be an attack vector. It also has huge potential for causing strange bugs, which happened in Bug 14957 where a column is named "delete", calling the "delete" method instead of fetching the column value as intended. Here is patch to fix this using a separate namespace for setting/getting columns through get_column/set_column instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 24798] New: smart-rules.tt has erroneous comments
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798 Bug ID: 24798 Summary: smart-rules.tt has erroneous comments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: pasi.kallinen(a)koha-suomi.fi QA Contact: testopia(a)bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: [#% Default branch %#] koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: [#% Branch-specific %#] but TT comments are [%# Go to admin/smart-rules.pl and search the page source, you'll find those strings in there. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 17464] New: Order deny, allow / Deny from all was deprecated in Apache 2.4 and is now a hard error
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Bug ID: 17464 Summary: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt(a)gmail.com Reporter: bob-ewart(a)bobsown.com QA Contact: testopia(a)bugs.koha-community.org The Allow, Deny and Order directives were deprecated in Apache 2.4 and are no longer recognized. Order deny,allow Deny from all Should be: Require all denied lines 36/37 and 169/170 in koha-httpd.conf should be changed This is in Koha compiled from source and appears in most of the versions I've tried. Also add: <Directory '/usr/share/koha'> Require all granted </Directory> or you will get an 'access forbidden' error If using plugins also add: <Directory '/var/lib/koha'> Require all granted </Directory> -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 23753] New: Background job JavaScript should not try to call humanMsg library
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753 Bug ID: 23753 Summary: Background job JavaScript should not try to call humanMsg library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org While trying to fix Bug 8645 I noticed that background-job-progressbar.js has error-handling code which tries to call the "humanMsg" function which is defined in the "HUMANIZED MESSAGES" plugin humanmsg.js. The plugin is currently loaded on the following pages: admin\preferences.tt cataloguing\editor.tt tools\stage-marc-import.tt Whereas background-job-progressbar.js is used on these pages: offline_circ\process_koc.tt tools\batch_record_modification.tt tools\batchMod-edit.tt tools\manage-marc-import.tt tools\stage-marc-import.tt tools\upload-images.tt The background job error handling doesn't do anything other than return the AJAX error message, so I don't think it's worth it to add the humanmsg plugin everywhere. Better, I think, to change it to an alert. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 24733] New: Cannot search for duplicate orders using 'Basket created by' field
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24733 Bug ID: 24733 Summary: Cannot search for duplicate orders using 'Basket created by' field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: nick(a)bywatersolutions.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: 1 - Have an open basket in acquisitions 2 - Add to basket - from an existing order (copy) 3 - Enter a name in the 'Basket created by' field and select a user 4 - Hit search 5 - ISE (Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/share/koha/lib/C4/Acquisition.pm line 2482.) -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 21879] New: Code cleaning in printinvoice.pl
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21879 Bug ID: 21879 Summary: Code cleaning in printinvoice.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: kohadevinim(a)devinim.com.tr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com While working on bug 19489, we realized that some lines are nor necessary anymore, hence we will clean those. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 24732] New: Make DumpTemplateVars more readable
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24732 Bug ID: 24732 Summary: Make DumpTemplateVars more readable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Currently we just use Dumper output directly, it would be helpful if we formatted things slightly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 24809] New: OAI PMH can fail on fetching deleted records
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809 Bug ID: 24809 Summary: OAI PMH can fail on fetching deleted records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org When calling GetRecord if we pass a deleted biblionumber that has a deleted item we can end up thinking a record that is deleted is not deleted and so fail on getting the record The problem is here: 48 UNION 49 SELECT timestamp from deleteditems 50 WHERE biblionumber=? If you delete an item from a record, then delete the record, the first query gets a timestamp and then attempts to get the record as if it is not deleted To recreate: 1 - Edit/create a file in the koha home dir '/var/lib/koha/{instance}/OAI.yaml 2 - Set sysprefs: OAI-PMH => Enable OAI-PMH:ConfFile => /var/lib/koha/{instace}/OAI.yaml 3 - View a record with items and confirm the items show: http://localhost:8080/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=mar… 4 - Delete the items, then delete the record 5 - Reload the URL from step 3 6 - Internal Server Error: Empty String at /kohadevbox/koha/Koha/OAI/Server/Record.pm line 58. at /usr/share/perl/5.24/Carp.pm line 167 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 29

[Bug 24114] New: modules must not warn
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bug ID: 24114 Summary: modules must not warn Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Bug 21336 introduced warn statements in Koha::Patrons. That should be avoided, the warn must be done in the cronjob script. -- You are receiving this mail because: You are watching all bug changes.

1 32