April 2020 - Koha-bugs - lists.koha-community.org

[Bug 25296] New: Add a way to force an empty Koha::Objects resultset
by bugzilla-daemon＠bugs.koha-community.org 09 May '20

09 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Bug ID: 25296 Summary: Add a way to force an empty Koha::Objects resultset Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org In some scenarios, it would be handy for consistency to just return an empty resultset (instead of undef, for example). Take the following example: sub current_item_level_holds { my ($self) = @_; my $items_rs = $self->_result->aqorders_items; my @item_numbers = $items_rs->get_column('itemnumber')->all; return unless @item_numbers; my $biblio = $self->biblio; return unless $biblio; return $biblio->current_holds->search( { itemnumber => { -in => \@item_numbers } } ); } if we wanted to always return a Koha::Holds iterator (as ->current_holds does) we could do: sub current_item_level_holds { my ($self) = @_; my $items_rs = $self->_result->aqorders_items; my @item_numbers = $items_rs->get_column('itemnumber')->all; my $biblio = $self->biblio; unless ( $biblio and @itemnumbers ) { return Koha::Holds->new->empty; } return $biblio->current_holds->search( { itemnumber => { -in => \@item_numbers } } ); } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 31

[Bug 25271] New: Add floating toolbar to OPAC cart
by bugzilla-daemon＠bugs.koha-community.org 09 May '20

09 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Bug ID: 25271 Summary: Add floating toolbar to OPAC cart Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I think it would be useful for the OPAC cart window's toolbar to float. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 25166] New: Add "aria-hidden = true" to Font Awesome icons in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 May '20

09 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Bug ID: 25166 Summary: Add "aria-hidden = true" to Font Awesome icons in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 23003 Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 25294] New: Don't show deletion button if user can't delete suggestions
by bugzilla-daemon＠bugs.koha-community.org 09 May '20

09 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25294 Bug ID: 25294 Summary: Don't show deletion button if user can't delete suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org If OPACViewOthersSuggestions is enabled the logged-in user might be viewing a list of suggestions none of which they have permission to delete. If this is the case the "Delete suggested" button should not appear. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 25110] New: Allow for Patrons to Add Star Ratings to Books on their Summary/Checkout Page
by bugzilla-daemon＠bugs.koha-community.org 09 May '20

09 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25110 Bug ID: 25110 Summary: Allow for Patrons to Add Star Ratings to Books on their Summary/Checkout Page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 30

[Bug 25281] New: Use modal confirmation when deleting a list in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 May '20

09 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25281 Bug ID: 25281 Summary: Use modal confirmation when deleting a list in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 25276 Blocks: 18117 Bug 21870 added a framework for using a Bootstrap modal to replace generic JavaScript confirm dialogs. I would like to implement this in the OPAC lists interface for the process of deleting a list. This will allow us to include more information in the confirmation: List title, number of titles on the list, and whether it is shared. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 [Bug 18117] Convert browser alerts to modals https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25276 [Bug 25276] Correct hover style of list share button in the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 25280] New: Use modal confirmation when removing share from a list in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 May '20

09 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25280 Bug ID: 25280 Summary: Use modal confirmation when removing share from a list in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 25276 Blocks: 18117 Bug 21870 added a framework for using a Bootstrap modal to replace generic JavaScript confirm dialogs. I would like to implement this in the OPAC lists interface for the process of removing a share. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 [Bug 18117] Convert browser alerts to modals https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25276 [Bug 25276] Correct hover style of list share button in the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 25234] New: Update OPAC search results pagination with aria labels
by bugzilla-daemon＠bugs.koha-community.org 09 May '20

09 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Bug ID: 25234 Summary: Update OPAC search results pagination with aria labels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 23003 For better accessibility I would like to add aria labels to the include file which generates OPAC search results pagination. See articles: https://a11y-style-guide.com/style-guide/section-navigation.html#kssref-nav… https://www.a11ymatters.com/pattern/pagination/ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 25048] New: Successful resource deletion should return 204
by bugzilla-daemon＠bugs.koha-community.org 09 May '20

09 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25048 Bug ID: 25048 Summary: Successful resource deletion should return 204 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com As stated in our coding guidelines for the API [1], when deleting a resource, the API should return a 204 instead of the 200 some do now. [1] https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER3.2.4_D… -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 25229] New: Elasticsearch should use the authid (record id) rather than the 001 when returning auth search results
by bugzilla-daemon＠bugs.koha-community.org 09 May '20

09 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Bug ID: 25229 Summary: Elasticsearch should use the authid (record id) rather than the 001 when returning auth search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: 0 - Have an environment with both ES and Zebra available 1 - Edit an authority record in the DB to force the 001 and the auth_id to be different update auth_header SET marcxml = REPLACE(marcxml,"1707","potato"); 2 - Reindex Zebra and ES 3 - View the record in zebra (commands below work on kohadevbox sample data) yaz-client unix:/var/run/koha/kohadev/authoritysocket base authorities find "computer program" show 1+14 Note that the relevant record has the auth id in the 001 even though the record doesn't 4 - View the record in Elasticsearch curl -X GET 'localhost:9200/koha_kohadev_authorities/data/1707?pretty' Note the 001 is indexed into local number, but the _id of the record matches authid 5 - Search authorities in the staff client for "Computer prorgram" using Zebra Note that you can find authid 1707 in the results and view it 6 - Switch search engine to ES and repeat Note that you have a result that links to authid=potato and it doesn't work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19