April 2020 - Koha-bugs - lists.koha-community.org

[Bug 25119] New: When paying a single account line, description and account type don't display correctly
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25119 Bug ID: 25119 Summary: When paying a single account line, description and account type don't display correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When paying a single fine, the description and account type are not displaying correctly on paycollect.tt in all cases. In my case it didn't work for RENT_RENEW with a description including the title of the the record. While it displays nicely in the list of charges, when paying it individually using the pay button in the line, the account type displays the code instead of the description and the description remains empty. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 25297] New: Consistent return value in K::A::Order->current_item_level_holds
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297 Bug ID: 25297 Summary: Consistent return value in K::A::Order->current_item_level_holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Right now it returns undef if there's no bilbio or items linked to the order. WE should rely on bug 25296 and return an empty Koha::Holds resultset. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 25303] New: Koha::Objects->delete should not skip overriden object class ->delete
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Bug ID: 25303 Summary: Koha::Objects->delete should not skip overriden object class ->delete Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org If we call Koha::Libraries->delete but Koha::Library->delete exists (ie. Koha::Object->delete is overriden), then we Koha::Objects->delete will be called and the overriden will not be executed. -- You are receiving this mail because: You are watching all bug changes.

1 39

[Bug 25296] New: Add a way to force an empty Koha::Objects resultset
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Bug ID: 25296 Summary: Add a way to force an empty Koha::Objects resultset Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org In some scenarios, it would be handy for consistency to just return an empty resultset (instead of undef, for example). Take the following example: sub current_item_level_holds { my ($self) = @_; my $items_rs = $self->_result->aqorders_items; my @item_numbers = $items_rs->get_column('itemnumber')->all; return unless @item_numbers; my $biblio = $self->biblio; return unless $biblio; return $biblio->current_holds->search( { itemnumber => { -in => \@item_numbers } } ); } if we wanted to always return a Koha::Holds iterator (as ->current_holds does) we could do: sub current_item_level_holds { my ($self) = @_; my $items_rs = $self->_result->aqorders_items; my @item_numbers = $items_rs->get_column('itemnumber')->all; my $biblio = $self->biblio; unless ( $biblio and @itemnumbers ) { return Koha::Holds->new->empty; } return $biblio->current_holds->search( { itemnumber => { -in => \@item_numbers } } ); } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 31

[Bug 25271] New: Add floating toolbar to OPAC cart
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Bug ID: 25271 Summary: Add floating toolbar to OPAC cart Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I think it would be useful for the OPAC cart window's toolbar to float. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 25166] New: Add "aria-hidden = true" to Font Awesome icons in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Bug ID: 25166 Summary: Add "aria-hidden = true" to Font Awesome icons in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 23003 Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 25294] New: Don't show deletion button if user can't delete suggestions
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25294 Bug ID: 25294 Summary: Don't show deletion button if user can't delete suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org If OPACViewOthersSuggestions is enabled the logged-in user might be viewing a list of suggestions none of which they have permission to delete. If this is the case the "Delete suggested" button should not appear. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 25110] New: Allow for Patrons to Add Star Ratings to Books on their Summary/Checkout Page
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25110 Bug ID: 25110 Summary: Allow for Patrons to Add Star Ratings to Books on their Summary/Checkout Page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 30

[Bug 25281] New: Use modal confirmation when deleting a list in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25281 Bug ID: 25281 Summary: Use modal confirmation when deleting a list in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 25276 Blocks: 18117 Bug 21870 added a framework for using a Bootstrap modal to replace generic JavaScript confirm dialogs. I would like to implement this in the OPAC lists interface for the process of deleting a list. This will allow us to include more information in the confirmation: List title, number of titles on the list, and whether it is shared. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 [Bug 18117] Convert browser alerts to modals https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25276 [Bug 25276] Correct hover style of list share button in the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 25280] New: Use modal confirmation when removing share from a list in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25280 Bug ID: 25280 Summary: Use modal confirmation when removing share from a list in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 25276 Blocks: 18117 Bug 21870 added a framework for using a Bootstrap modal to replace generic JavaScript confirm dialogs. I would like to implement this in the OPAC lists interface for the process of removing a share. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 [Bug 18117] Convert browser alerts to modals https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25276 [Bug 25276] Correct hover style of list share button in the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 14