April 2020 - Koha-bugs - lists.koha-community.org

[Bug 24840] New: Datetime issues in automatic_renewals / CanBookBeReserved
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24840 Bug ID: 24840 Summary: Datetime issues in automatic_renewals / CanBookBeReserved Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com I cannot recreate this, however, we have sites that experience automatic_renewals.pl crashing with: Invalid local time for date in time zone: America/New_York It seems to happen around the daylight savings change There is: DateTime->now( time_zone => C4::Context->tz() ) In C4::Circulation::CanBookBeRenewed but I can't purposely make that fail -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 24299] New: Record if a transfer was triggered by 'rotating collections'
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 Bug ID: 24299 Summary: Record if a transfer was triggered by 'rotating collections' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Use the new 'trigger' field in branchtransfers to record if a transfer was added by the 'rotating collection' tool. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 37

[Bug 24432] New: Request an endpoint with a date column in order by throws bad parameter exception
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432 Bug ID: 24432 Summary: Request an endpoint with a date column in order by throws bad parameter exception Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: agustinmoyano(a)theke.io CC: tomascohen(a)gmail.com Depends on: 23893 Blocks: 20936 When you request an endpoint in the API with a date as orderby, it throws Koha::Exceptions::BadParameter. Koha::REST::Plugin::Query in _build_order_atom, in order to get the model parameter for the order by, it requests {instance of Koha::Objects}->attributes_from_api({ <api parameter name> => 1 }); to get that hash translated, and use the resulting key as the model column to do the order by. This works ok for all datatypes except date types, because it's trying to transate the value of "1" as a date, throwig the mentioned exception. In my opinion, _build_order_atom should not use attributes_from_api, but should use the mapping in Koha::Object to get the column name. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 25044] New: No need to define koha_object[s]_çlass for standard object class names
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25044 Bug ID: 25044 Summary: No need to define koha_object[s]_çlass for standard object class names Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 24356 In Koha::Object[s]->prefetch_whitelist, there is a call to the koha_object[s]_class DBIC resultset class. We should not, otherwise those 2 methods will have to be defined all the time, even when we can guess it easily. Koha::Item <> Schema::Result::Item => standard Koha::Acquisition::Order <> Schema::Result::Aqorder => non-standard sub _get_object_class { my ( $type ) = @_; return unless $type; if( $type->can('koha_object_class') ) { return $type->koha_object_class; } $type =~ s|Schema::Result::||; return ${type}; } Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 [Bug 24356] objects.search prefetch -- You are receiving this mail because: You are watching all bug changes.

1 28

[Bug 25096] New: Patrons who have opted out of auto-renew should not be subject to No Renewal Before
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25096 Bug ID: 25096 Summary: Patrons who have opted out of auto-renew should not be subject to No Renewal Before Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 24476 adds the ability to opt out of auto-renewal. Auto-renewal is generally set up to use a No Renewal Before value. If a patron opts out of auto-renewal, their manual renewals are still subject to that No Renewal Before value. To recreate: - set a circ rule that uses auto-renew and sets a No Renewal Before value of 1. - find a patron and item subject to that circ rule - set the patron to opt out of auto-renewal - check the item out to the patron, making sure the due date is more than 1 day in the future - observe that while the checkout will not auto-renew, it cannot be manually renewed yet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 24559] New: Elasticsearch - add support for 'date' fields
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24559 Bug ID: 24559 Summary: Elasticsearch - add support for 'date' fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com There is a fixme in the code related to this. For dates like the 260c and 264c we need a way to parse p2014 into 2014 etc. This affects sorting on dates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 22134] New: Add account expiration information to patron details
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 Bug ID: 22134 Summary: Add account expiration information to patron details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- On the patron detail page in the staff client, expired patrons should show a message at the top like the checkout page does. -- You are receiving this mail because: You are watching all bug changes.

1 29

[Bug 25086] New: OPAC Self Registration - Field 'changed_fields' doesn't have a default value
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Bug ID: 25086 Summary: OPAC Self Registration - Field 'changed_fields' doesn't have a default value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: agustinmoyano(a)theke.io Reporter: agustinmoyano(a)theke.io QA Contact: testopia(a)bugs.koha-community.org CC: jonathan.druart(a)bugs.koha-community.org, tomascohen(a)gmail.com Depends on: 23579 In OPAC's self registration, if PatronSelfRegistrationVerifyByEmail is set to Require, OPAC dies with the following error DBD::mysql::st execute failed: Field 'changed_fields' doesn't have a default value [for Statement "INSERT INTO `borrower_modifications` ( `branchcode`, `categorycode`, `date_renewed`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `email`, `firstname`, `gdpr_proc_consent`, `password`, `surname`, `timestamp`, `verification_token`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ? )" with ParamValues: 0="CPL", 1="S", 2=undef, 3=undef, 4=undef, 5=undef, 6=undef, 7="prueba2(a)algo.com", 8="algo", 9=undef, 10='E<rcyc6h<p', 11="prueba2", 12='aa165f462c22f414a2cd1081bace0921'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Seems it's because changed_fields doesn't have a default value, and cannot be null. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23579 [Bug 23579] error during web install: 'changed_fields' can't have a default value -- You are receiving this mail because: You are watching all bug changes.

1 30

[Bug 25011] New: Add display of Production credits (MARC21 508) to staff detail page
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Bug ID: 25011 Summary: Add display of Production credits (MARC21 508) to staff detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 13385 Bug 13385 added 508 to the OPAC XSLT detail page, but missed staff. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385 [Bug 13385] RDA: 508 display in XSLT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 25136] New: PatronSelfRegistrationLibraryList controls both self-reg and self-modification
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Bug ID: 25136 Summary: PatronSelfRegistrationLibraryList controls both self-reg and self-modification Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The syspref PatronSelfRegistrationLibraryList describes itself as being about self-registration, but also limits the libraries available for patron self-modification. This presents a problem for libraries that want to corral their self-reg patrons into one library but allow full patrons to move between libraries. I've only confirmed this on 19.05. Master is currently doing something else weird on this syspref, which I'll file a bug for separately. This is part of a larger muddling of selfreg and selfmod that it'd be helpful to get untangled. See also bug 13188 for separating out the mandatory fields for the two pages. -- You are receiving this mail because: You are watching all bug changes.

1 14