May 2020 - Koha-bugs - lists.koha-community.org

[Bug 11994] Fix OpenSearch discovery in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry, yes, one patch was obsolete, fixed now! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11994] Fix OpenSearch discovery in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104132|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11994] Fix OpenSearch discovery in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #18 from David Nind <david(a)davidnind.com> --- I'm getting something weird when applying the patch and trying to sign off. There are four patches listed in the bug, bit git log only shows three. Does that mean patch 104132 - Bug 11994: Attempt to fix Content-Type can be obsoleted? This is what I get when applying the patch: root@b23fad95e500:koha(master)$ git bz apply 11994 Bug 11994 - Fix OpenSearch discovery in the OPAC 104132 - Bug 11994: Attempt to fix Content-Type 104133 - Bug 11994: Fix OpenSearch discovery in the OPAC 104134 - Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml 104135 - Bug 11994: (follow-up) Make things work when LibraryName is empty Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11994: Attempt to fix Content-Type Applying: Bug 11994: Fix OpenSearch discovery in the OPAC Applying: Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml Using index info to reconstruct a base tree... M C4/Output.pm M opac/opac-search.pl Falling back to patching base and 3-way merge... No changes -- Patch already applied. Applying: Bug 11994: (follow-up) Make things work when LibraryName is empty -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11994] Fix OpenSearch discovery in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #17 from David Nind <david(a)davidnind.com> --- That's awesome Katrin, thank you for your perseverance! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11994] Fix OpenSearch discovery in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11994] Fix OpenSearch discovery in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #16 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I couldn't let this go... and I finally figured it out! ... It would fial when LibraryName is not set. I also cleaned up the patch for Content-Type. While it seems to work without, I think we would be on the safer side to do it correctly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11994] Fix OpenSearch discovery in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 104135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104135&action=e… Bug 11994: (follow-up) Make things work when LibraryName is empty When LibraryName system preference was not set, the installation of the plugin would fail with: Firefox could not download the search plugin from: ... Now if the pref is empty, the description 'Library catalog' will be used instead. To test: - Empty your LibraryName pref - Verify the search plugin can still be installed (see first patch for further instructions) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11994] Fix OpenSearch discovery in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 104134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104134&action=e… Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml https://developer.mozilla.org/en-US/docs/Web/OpenSearch Your server should serve OpenSearch plugins using Content-Type: application/opensearchdescription+xml. To test: - Verify the Content-Type the file is delivered with is correct, for example using wget http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?format=opensearchdescript… -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11994] Fix OpenSearch discovery in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103866|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 104133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104133&action=e… Bug 11994: Fix OpenSearch discovery in the OPAC This patch corrects the markup for the OpenSearchDescription XML document and adds (back) the link in the OPAC header which points to it. This will enable compatible browsers to offer the addition of the OPAC's keyword search as a search engine option. I've found documentation suggesting this feature is available (or at least was at one time) in Chrome and Safari, but in my test it only works in Firefox. To test, apply the patch and make sure the OPACBaseURL preference is set correctly. - Open the OPAC in Firefox (these instructions assume the latest version, currently v.75). - On the right side of the address bar you should see ". . ." Click it to trigger the menu. - You should see an "Add search engine" entry with your OPAC's icon. - Click to add the search engine. - Type a keyword to search in the address bar - A box should pop up below the address bar showing icons at the bottom for performing a search in various search engines. One of these icons should be the icon for your Koha OPAC. - Click the Koha OPAC icon and confirm that it triggers a keyword search in your OPAC. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11994] Fix OpenSearch discovery in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #12 from David Nind <david(a)davidnind.com> --- Glad it just wasn't me. Found this resource useful, and it mentions the error as well: https://developer.mozilla.org/en-US/docs/Web/OpenSearch -- You are receiving this mail because: You are watching all bug changes.

1 0