July 2020 - Koha-bugs - lists.koha-community.org

[Bug 24819] New: Allow the librarian to choose a patron when entering a purchase suggestion
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819 Bug ID: 24819 Summary: Allow the librarian to choose a patron when entering a purchase suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: matthias.meusburger(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Sometimes librarians are creating purchase suggestions that came from patrons which didn't use the opac (but sent an email, or told the librarian verbally...) This patch allows the librarian to change the creator of the purchase suggestion when entering it. This way, the patron will be able to receive notifications during the purchase suggestion workflow. Test plan: - Apply the patch - Check that you can change the default creator of the purchase suggestion when creating a new suggestion by clicking on 'Set to patron' (Home > Acquisitions > Suggestions management > New purchase suggestion) - Check that you can also change the creator of the purchase suggestion when editing an existing suggestion This is a rewrite of Bug 14376. Since it has been rewritten from scratch, I thought it would be cleaner to create a new Bug, but let me know otherwise. This rewrite now uses the common way to select a patron, as requested in Bug 14376. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 31

[Bug 25469] New: Typo: Item does not belongs to your library
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 Bug ID: 25469 Summary: Typo: Item does not belongs to your library Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Found in translation, it appers in: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt:2 koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt:8 -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 25718] New: Correct typo in additem.tt
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25718 Bug ID: 25718 Summary: Correct typo in additem.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org In intranet-tmpl/prog/en/modules/cataloguing/additem.tt there is a sentence that says ": Last item for bibliographic record wich biblio-level hold on it." It should say ": Last item for bibliographic record with biblio-level hold on it." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 24185] New: 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Bug ID: 24185 Summary: 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: nugged(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest" called many times with hundred of items and "on shelf holds" parameter set to "If all unavailable" for these items+patron, it goes very slow. This happens because in subloop there are re-checking if all other item unavailable so it is O(n^2) and it re-checks each time a lot of the same info for each item with repeating DB/data requests, these three: - GetBranchItemRule (per item type) - IsItemOnHoldAndFound (per item) - notforloan (per item) Proposed fix: I created patch to have in-variable cache in upper-level subroutine before entering the first "items" loop and passing that hash reference down into subs to cache these three values by keys per-item and per-item-type. It is simplest way to make it fast without re-thinking pretty complicated whole algorithm and business logic, and, when tested by speed it gave big improvement in execution time. How to reproduce: 1) on fresh installed kohadevbox create/import one book, record that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", so that rule will match above book items/libary/patron, check that rule to have non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create direct link by yourself, for example in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time. I tested on my computer in VirtualBox for this page generation times, (stats below is for many runs and smallest value taken from similar in a repetition), last one block eith times with that in-var-cache solution I am proposing: "On shelf holds allowed" != "If all unavailable": for 100 items: 5 seconds, for 200 items: 10 seconds, for 300 items: 11 seconds, "On shelf holds allowed" == "If all unavailable": for 100 items: 50 seconds, for 200 items: 3.1 minutes, for 300 items: 7.0 minutes, "On shelf holds allowed" == "If all unavailable" with cache: for 100 items: 7 seconds, for 200 items: 20 seconds, for 300 items: 38 seconds, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 55

[Bug 25337] New: Export/import of Elasticsearch configuration is lacking information
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25337 Bug ID: 25337 Summary: Export/import of Elasticsearch configuration is lacking information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de Depends on: 23204 Trying to make a bug report out of bug 23204##40 Note : Since bug 20589, two fields have been added to 'search_field' table: staff_client and opac. Those fields are lacking in mappings.yaml. Its means that if this script is used to export and import (Reset mapping in Search engine configuration) indexing rules, the searchability (staff/opac) of fields will be lost. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 [Bug 23204] Script for exporting Elasticsearch mappings to YAML -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 23173] New: ILL should be able to search third party sources prior to request creation
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Bug ID: 23173 Summary: ILL should be able to search third party sources prior to request creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com Target Milestone: --- Currently, there is no integrated way of knowing if an item being requested is already available. If a user creating a request wants to know if the item they are requesting is already available, it is necessary to search the, possibly, multiple sources the library has available (catalogue, discovery interface, open access provider etc.) first. The problem is further compounded if the institution has the unmediated ILL workflow enabled where a request can be placed with no oversight, even though the institution may already have access to it. I propose a mechanism by which, during request creation, one or more "sources" are searched with the provided metadata to try and determine if the item being requested is already available and, if so, links to that item are provided. This behaviour will be optional, via a syspref. "Sources" will be provided as Koha plugins and will provide the ability to accept metadata conforming to the established ILL schema, search the source with which they're concerned, and return results in a prescribed format. This will be performed via an API common to all "source" plugins. All plugins performing this task will be in a common plugin category and therefore enumerable. The workflow for two backends: Freeform: - User fills in Freeform form, clicks submit button - User is taken to an "Availability" page - ILL enumerates source plugins that can service this type of request (mostly determined by material type) and makes search requests to each using provided metadata - Displays results from each source, with links to matching items - User can then either choose a result and be taken to it, or choose none and continue with the request as normal BLDSS: - Identical to above except the user will choose a BLDSS result rather than filling in the Freeform form As part of this work, a source plugin, which will serve as a reference, will be provided. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 75

[Bug 21443] New: Add ability to exclude holidays when calculating rentals fees by time period
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Bug ID: 21443 Summary: Add ability to exclude holidays when calculating rentals fees by time period Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It would be a nice addition if we could have the option to not count holidays when creating time period based rental fees. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 49

[Bug 26115] New: Remove leftover Carp::Always
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26115 Bug ID: 26115 Summary: Remove leftover Carp::Always Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org There's a leftover from bug 23112 on t/db_dependent/Illrequests.t -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 23185] New: Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Bug ID: 23185 Summary: Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P1 - high Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: dcook(a)prosentient.com.au, jonathan.druart(a)bugs.koha-community.org, koha-bugs(a)lists.koha-community.org, kyle(a)bywatersolutions.com, m.de.rooy(a)rijksmuseum.nl, martin.renvoize(a)ptfs-europe.com, testopia(a)bugs.koha-community.org, tomascohen(a)gmail.com Depends on: 21761 Target Milestone: --- +++ This bug was initially created as a clone of Bug #21761 +++ If we're adding triggers at the code level all over the place by overloading the store method we need to never ever let dbic handle it.. by allowing the 'update' method through we are exposing ourselves to places in the codebase skipping the store triggers. This would in effect bind us to the 'update_all' style of update call from dbic, which results in a loop over the affected rows so that in code triggers can be called per row rather than allowing any form of 'update all these rows to X' in one query. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.

1 70

[Bug 25992] New: SIP2 server doesn't start – Undefined subroutine set_logger
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Bug ID: 25992 Summary: SIP2 server doesn't start – Undefined subroutine set_logger Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com, kyle(a)bywatersolutions.com After the SIP2 server refactoring in Bug 15253 the sip2 server doesn't start anymore because of this error: > Undefined subroutine &C4::SIP::SIPServer::set_logger called at /kohadevbox/koha/C4/SIP/SIPServer.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16