October 2021 - Koha-bugs - lists.koha-community.org

[Bug 29176] New: Additional LOC Classifications Should Display on a Newline
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29176 Bug ID: 29176 Summary: Additional LOC Classifications Should Display on a Newline Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: eliana(a)flo.org QA Contact: testopia(a)bugs.koha-community.org Created attachment 125737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125737&action=e… LOC Classification in OPAC When a title has multiple LOC classifications they appear smooshed together with no spaces in both the staff client and OPAC. If there are multiple classifications then additional ones should appear on a newline for legibility's sake. Another option would be to use the pipe character to separate additional classifications, similar to how subject headings appear. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #383 from David Gustafsson <glasklas(a)gmail.com> --- > > 6. How does it interface with the marc modification templates when batch > > editing bibliographic records? > > Investigating.. I have a feeling his patchset predates it and I missed this > case ! :( Sorry, never got around to have a look at this yesterday, but now did. From what I can gather from the code I'm pretty sure that if no rules have been defined for the batchmod context, the incoming record simply overwrites the existing record. If there are rules, these are applied on the record after the record has been modified using the specified template. So if the modification template modifies some protected field for example, these changes will not be applied. This is expected behavior as far as I can tell? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8417] date acquired is shipping date
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 [Bug 29175] finishreceive: Replace , by ; -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #31 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Marcel de Rooy from comment #27) > (In reply to Jonathan Druart from comment #25) > > (In reply to Marcel de Rooy from comment #23) > > > + my @hold_not_allowed_itypes = Koha::CirculationRules->search( > > > + { > > > + rule_name => 'holdallowed', > > > + branchcode => undef, > > > + categorycode => undef, > > > + rule_value => 'not_allowed', > > > + } > > > + )->get_column('itemtype'); > > > > > > I have my doubts here btw. > > > This is too simple. You are looking at circ rules with exception for various > > > combinations of category, itemtype etc. > > > You cant just do a get_column here. This depends on context. > > > Please clarify and add tests. > > > > Which context? The logged in branch? > > Here we are not in C4::Reserves, we don't want to offer all the complexity > > of CanItemBeReserved. As said previously I am not adding new code of > > functionality (apart for the additional damaged check). > > Ok. If this is a reflection of what we did already, I cant justify to fail > it :) Koha never fails! > Back to SO lol I am feeling your sarcasms, Marcel :) I will be happy to improve anything you think that may be useful. But keep in mind that the point here is only to centralize things. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #30 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 125734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125734&action=e… Bug 3142: Add note about imprecision of filter_by_for_hold -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #29 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 125733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125733&action=e… Bug 3142: Add test for the circ rule -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs(a)lists.koha-commun |m.de.rooy(a)rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #28 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Will QA this one soon. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #27 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #25) > (In reply to Marcel de Rooy from comment #23) > > + my @hold_not_allowed_itypes = Koha::CirculationRules->search( > > + { > > + rule_name => 'holdallowed', > > + branchcode => undef, > > + categorycode => undef, > > + rule_value => 'not_allowed', > > + } > > + )->get_column('itemtype'); > > > > I have my doubts here btw. > > This is too simple. You are looking at circ rules with exception for various > > combinations of category, itemtype etc. > > You cant just do a get_column here. This depends on context. > > Please clarify and add tests. > > Which context? The logged in branch? > Here we are not in C4::Reserves, we don't want to offer all the complexity > of CanItemBeReserved. As said previously I am not adding new code of > functionality (apart for the additional damaged check). Ok. If this is a reflection of what we did already, I cant justify to fail it :) Koha never fails! Back to SO -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0