October 2021 - Koha-bugs - lists.koha-community.org

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #26 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 125732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125732&action=e… Bug 3142: Add tests And fix a bug! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #25 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Marcel de Rooy from comment #23) > + my @hold_not_allowed_itypes = Koha::CirculationRules->search( > + { > + rule_name => 'holdallowed', > + branchcode => undef, > + categorycode => undef, > + rule_value => 'not_allowed', > + } > + )->get_column('itemtype'); > > I have my doubts here btw. > This is too simple. You are looking at circ rules with exception for various > combinations of category, itemtype etc. > You cant just do a get_column here. This depends on context. > Please clarify and add tests. Which context? The logged in branch? Here we are not in C4::Reserves, we don't want to offer all the complexity of CanItemBeReserved. As said previously I am not adding new code of functionality (apart for the additional damaged check). Tests are definitely missing, agreed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #24 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Marcel de Rooy from comment #22) > (In reply to Martin Renvoize from comment #21) > > This works well and certainly clarifies the code.. it does need tests still > > though ;) > > If it does, we cant get it further from here? What do you suggest? I didn't get what suggested David in comment 9. The unique ambition of these patches is to reuse an existing method and avoid duplication of code. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- + my @hold_not_allowed_itypes = Koha::CirculationRules->search( + { + rule_name => 'holdallowed', + branchcode => undef, + categorycode => undef, + rule_value => 'not_allowed', + } + )->get_column('itemtype'); I have my doubts here btw. This is too simple. You are looking at circ rules with exception for various combinations of category, itemtype etc. You cant just do a get_column here. This depends on context. Please clarify and add tests. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #22 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #21) > This works well and certainly clarifies the code.. it does need tests still > though ;) If it does, we cant get it further from here? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #21 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- This works well and certainly clarifies the code.. it does need tests still though ;) Whilst I see David's point about on shelf holds, I think we can defer that piece to a next step in a follow-up bug. Signing off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122317|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 125730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125730&action=e… Bug 3142: Use filter_by_for_holds where holdability is calculated Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122316|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 125729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125729&action=e… Bug 3142: Add itype Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122315|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 125728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125728&action=e… Bug 3142: Exclude damaged items Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0