December 2021 - Koha-bugs - lists.koha-community.org

[Bug 28906] New: Koha::Items->filter_by_visible_in_opac doesn't honour list context
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '22

11 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Bug ID: 28906 Summary: Koha::Items->filter_by_visible_in_opac doesn't honour list context Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 28886] New: Remove uses of ->as_list from the codebase
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '22

11 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28886 Bug ID: 28886 Summary: Remove uses of ->as_list from the codebase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org It seems that instead of fixing it (bug 28883) we've been using Koha::Objects->as_list to workaround the wrong behavior. We should fix this, globally. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 29765] New: Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '22

11 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Bug ID: 29765 Summary: Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org With the purpose of highlighting the value of the Koha::Result::Boolean class, this bug will migrate the current implementation with string return values to one using Koha::Result::Boolean instead -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 29741] New: Add Koha::Patron->safe_to_delete
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '22

11 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Bug ID: 29741 Summary: Add Koha::Patron->safe_to_delete Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 29060] New: Use modal for suspending holds until a date from the holds page
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '22

10 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060 Bug ID: 29060 Summary: Use modal for suspending holds until a date from the holds page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com If you view the list of holds on a patron's checkout screen you can click the "Suspend" button to trigger a modal dialog where you can select a date after which the hold should resume. I'd like to make the controls work the same way when viewing the list of holds on a title, e.g. /cgi-bin/koha/reserve/request.pl?biblionumber=XXX -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 28883] New: Koha::Objects->_new_from_dbic doesn't work correctly in list context
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '22

10 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Bug ID: 28883 Summary: Koha::Objects->_new_from_dbic doesn't work correctly in list context Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org It will always return a resultset, it should return a list in list context. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 70

[Bug 29693] New: CodeMirror broken on additional_contents.tt
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '22

10 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Bug ID: 29693 Summary: CodeMirror broken on additional_contents.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: -Go to Tools and open either additional contents ( either News or HTML customization ) -Make sure you open it using CodeMirror and not TinyMCE -Code mirror is broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 29588] New: Yesterday and tomorrow in datepicker don't translate
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '22

10 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 Bug ID: 29588 Summary: Yesterday and tomorrow in datepicker don't translate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Depends on: 29478 Tomorrow, Yesterday and or in the new Flatpickr datepicker don't translate. Today does, I am not sure why. I think it should be either only one underscore in an .inc file or it's something else. I tried updating the po files locally, but the strings didn't show up. ++ b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc @@ -34,6 +34,7 @@  [% Asset.js("js/calendar.js") | $raw %] [% Asset.js("lib/flatpickr/flatpickr.min.js") | $raw %] +[% Asset.js("lib/flatpickr/shortcut-buttons-flatpickr.min.js") | $raw %] <script> flatpickr.l10ns.default.weekdays = flatpickr_weekdays; flatpickr.l10ns.default.months = flatpickr_months; @@ -84,6 +85,38 @@ $(on_close_focus).focus(); } }, + plugins: [ + ShortcutButtonsPlugin({ + button: [ + { + label: __("Yesterday") + }, + { + label: __("Today") + }, + { + label: __("Tomorrow") + } + ], + label: "or", Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 [Bug 29478] flatpickr misses quick shortcut to "Today" date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 23149] New: Unsuspend button in staff interface is confusing
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '22

10 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23149 Bug ID: 23149 Summary: Unsuspend button in staff interface is confusing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- When viewing the holds page for biblio in the staff client it initially says: 'Suspend' until [date] - where suspend is a button and date is a datepicker if you choose a date and hit 'suspend' it then says 'Unsuspend' on [date] - where unsuspend is a button and the date is the date set above, but offers a date picker I read 'Unsuspend on date' as an option to set the date the hold will be unsuspended - not as 'Unsuspend now' with an irrelevant date displayed afterwards, which is how it seemingly functions. Does this make sense to others in its current state? I would propose: 'Suspend' until [date] - and if you set a date and click suspend it becomes Suspended until [date] then a new column with 'Unsuspend' as a button -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 21051] New: CGI::param called in list context when editing a patron card layout
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '22

10 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21051 Bug ID: 21051 Summary: CGI::param called in list context when editing a patron card layout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org To test: - Edit a patron card layout - Save or cancel editing CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_patroncards_edit_2dlayout_2epl line 186, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_patroncards_edit_2dlayout_2epl line 186, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_patroncards_edit_2dlayout_2epl line 186, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 57, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. -- You are receiving this mail because: You are watching all bug changes.

1 3