February 2021 - Koha-bugs - lists.koha-community.org

[Bug 27650] New: Wrong variable passed to the template in opac-main
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '21

23 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650 Bug ID: 27650 Summary: Wrong variable passed to the template in opac-main Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 14272 From: commit acb455f151ac737613857c58e64a600d760a59e0 Bug 14272: Show single news item [alternative patch] $template->param( + koha_news => @all_koha_news, We must not pass an array, the number of elements of the hash passed to the template may be inconsistent. It's working because of an error earlier in the script: + @all_koha_news = &GetNewsToDisplay($news_lang,$homebranch); GetNewsToDisplay returns an arrayref Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 [Bug 14272] Allow OPAC to show a single news entry -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 27795] New: Misalignment of TOTAL value in lateorders page
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '21

23 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Bug ID: 27795 Summary: Misalignment of TOTAL value in lateorders page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: severine.queune(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org Created attachment 117323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117323&action=e… Bad alignment of Total cost sum On /cgi-bin/koha/acqui/lateorders.pl page, the "Total cost" sum is align with the quantity column. It should be shift by a column to the right (sees screenshot attached). Maybe the occasion to add a total for "Quantity" column ? -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 27751] New: Phase out jquery.cookie.js: Batch item modifications
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '21

23 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27751 Bug ID: 27751 Summary: Phase out jquery.cookie.js: Batch item modifications Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 23944 Blocks: 27750 The batch item modification and deletion interfaces use a cookie to remember which columns in the table are shown or hidden. These templates should be modified to use the newer cookie plugin, js-cookie. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750 [Bug 27750] Remove jquery.cookie.js plugin -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 27752] New: Correct eslint errors in batchMod.js
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '21

23 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 Bug ID: 27752 Summary: Correct eslint errors in batchMod.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 23833, 27751 Following coding guideline JS8: "Follow guidelines set by ESLint," some errors should be corrected in batchMod.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23833 [Bug 23833] [Omnibus] JavaScript should conform to coding guidelines recommended by ESLint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27751 [Bug 27751] Phase out jquery.cookie.js: Batch item modifications -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 27703] New: Can't navigate in Authorized values
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '21

23 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27703 Bug ID: 27703 Summary: Can't navigate in Authorized values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: severine.queune(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com When you are seeing a specific authorized value, it's no longer possible to go to another authorized value using the drop-down menu "Show category". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 27029] New: Detail page missing Javascript accessible biblionumber value
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '21

22 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27029 Bug ID: 27029 Summary: Detail page missing Javascript accessible biblionumber value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org Bug 26890 raises the point that there's no biblionumber on the detail page that is easily Javascript accessible. We really should be publishing the biblionumber in a feature-independent way, so that different features can leverage the same biblionumber. Here's my ideas so far: 1. data-biblionumber attribute in the body element 2. A RDFa schema.org identifier put in a child of the div.record element 3. Use Template::Toolkit to create a Javascript object that contains the biblionumber as a property 4. HTML element like "<span class="label">Catalogue ID</span>: <span id="biblionumber">1234</span>" I'm actually kind of inclined towards #4, since I have occasionally had people ask for the biblionumber to be published on the HTML to make it easier to see and reference... (although more so for the Staff Interface than the OPAC admittedly) -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 27806] New: Exceptions thrown during a call to ->render are not caught and passed to ->unhandled_exception
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '21

22 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27806 Bug ID: 27806 Summary: Exceptions thrown during a call to ->render are not caught and passed to ->unhandled_exception Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com Depends on: 27680 Whilst working on 27680 I discovered that we do not catch exceptions that are thrown at the point of render. I failed to resolve the problem there so have moved this piece to it's own bug. The tests added catch the 500 responses and those responses are the HTML rendered Mojo::Exception templates.. I'll attach the patches I came up with that are not working as expected :(. I've also tried using $self->helper( 'reply.exception' => sub { my ($page, $c, $e) = @_; # Custom error page handling here } ); and $self->before_render => sub { my ($c, $args) = @_; # Make sure we are rendering the exception template return unless my $template = $args->{template}; return unless $template eq 'exception'; # Switch to JSON rendering if content negotiation allows it return unless $c->accepts('json'); $args->{json} = {exception => $c->stash('exception')}; }; and neither appeared to work :( Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 26209] New: BlockReturnofLostItems does not prevent lost items being found
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '21

22 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26209 Bug ID: 26209 Summary: BlockReturnofLostItems does not prevent lost items being found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: andrew(a)bywatersolutions.com, fridolin.somers(a)biblibre.com, gmcharlt(a)gmail.com, katrin.fischer(a)bsz-bw.de, kyle.m.hall(a)gmail.com, kyle(a)bywatersolutions.com, martin.renvoize(a)ptfs-europe.com, nick(a)bywatersolutions.com, testopia(a)bugs.koha-community.org, tomascohen(a)gmail.com Depends on: 21231 +++ This bug was initially created as a clone of Bug #21231 +++ >When the syspref BlockReturnOfLostItems is set to Block, the item is blocked from being returned, but is still >considered found -- it's set to lost=0 and a refund is applied to the patron (if circ rules allow). The item can >then be checked in a second time and returned as it is no longer lost. There are still a number of logical holes in the code. ModDateLastSeen is called in a number of places without a flag being passed to prevent the itemlost update. I must admit, I find it confusing to be able to update the last seen timestamp when the item is still 'lost'.. it feels like a logical flaw. Should we not alert the user performing the action that the item was lost and get feedback on what to do? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21231 [Bug 21231] BlockReturnofLostItems does not prevent lost items being found -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 27794] New: Add link to biblio in lateorders page
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '21

22 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27794 Bug ID: 27794 Summary: Add link to biblio in lateorders page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: severine.queune(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org On /cgi-bin/koha/acqui/lateorders.pl page, it could be helpful if the title in "Information" cell was a link to the bibliographic record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 27680] New: API DataTables Wrapper fails for ordering on multi-data-field columns
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '21

22 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Bug ID: 27680 Summary: API DataTables Wrapper fails for ordering on multi-data-field columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org We can make a single column contain data from multiple 'data' points in the ajax response using a mixture of a render function and concatenating the data points with ':' in the data field. This allows for a nice display and searching to work.. but the ordering call fails :( The final patch on bug 26273 highlights this: { "data": "manager.firstname:manager.surname", "searchable": true, "orderable": true, "render": function(data, type, row, meta) { var fullname = row.manager.firstname + " " + row.manager.surname; return fullname; } }, Assuming manager.firstname = 'Bob' and manager.surname = 'Geldoff'.. we will display "Bob Geldoff". Searching for 'Bob' will add a suitable search header searching for 'Bob' in both 'manager.firstname' and 'manager.surname' fields.. but hitting order by on this column will result in a 500 error as we add '_order_by: +manager.firstname:manager.surname' to the query parameters. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 68