April 2021 - Koha-bugs - lists.koha-community.org

[Bug 27895] New: Internal server error when trying to change picup location for a hold with no valid locations
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '23

04 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27895 Bug ID: 27895 Summary: Internal server error when trying to change picup location for a hold with no valid locations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com If 'AllowHoldPolicyOverride' is set to 'Allow' staff can place a hold that has no allowed pickup locations. If staff try to alter the pickup location from the patron's record there is an internal server error To test: 1 - Set 'Default checkout, hold and return policy' on Admin->Circ rules to Hold policy: From home library Hold pickup library match: Item's home library 2 - Set AllowHoldPolicyOverride to Allow 3 - Place an item level hold for a patron on an item from another branch - there should be a warn while placing, but hold is allowed 4 - Bring up the patron details or checkout page 5 - Click the holds tab 6 - Try to change the hold pickup location 7 - You get an error: There was an error:error Internal Server Error 8 - In logs: The method Koha::Libraries->branchcode is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Objects.pm line 592 Koha::Objects::AUTOLOAD('Koha::Libraries=HASH(0x5631e45dc298)') called at /kohadevbox/koha/Koha/Hold.pm line 252 Koha::Hold::__ANON__ at /kohadevbox/koha/Koha/Hold.pm line 252 Koha::Hold::is_pickup_location_valid('Koha::Hold=HASH(0x5631e448ae48)', 'HASH(0x5631e45cf638)') called at t/db_dependent/Koha/Hold.t line 203 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 17620] New: Fix format of date/data-times in Swagger definition
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '23

04 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17620 Bug ID: 17620 Summary: Fix format of date/data-times in Swagger definition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: hector.hecaxmmx(a)gmail.com, jonathan.druart(a)bugs.koha-community.org, lari.taskula(a)jns.fi, martin.renvoize(a)ptfs-europe.com, tomascohen(a)gmail.com Depends on: 16276, 17607 Bug #17607 highlighted the lack of a defined format for date and date-time fields in our api responses. We should settle on a response form and validate it to ensure it's consistently given across the codebase. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17607 [Bug 17607] Fix patron definition in Swagger -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 28184] New: Terminology: Edit or Modify on forms for changing information in Koha
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '23

04 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28184 Bug ID: 28184 Summary: Terminology: Edit or Modify on forms for changing information in Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: david(a)davidnind.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In the OPAC staff interface we use a mix of 'Edit' and 'Modify' on forms for changing information in Koha. Should we be using Edit or Modify for editing forms? Do we have a preferred term or does it not matter? Should we be more consistent? Some examples: - Cataloging for a record: Edit > Edit record, Edit items, Edit items in batch; form is labelled 'Editing [title]', 'Edit Item #XXX', 'Edit items' - Administration > Z39.50/SRU servers administration: Edit for action menu, on the form 'Modify Z39.50 server' - Administration > Libraries: Edit for the action menu, on the form we use 'Modify library' - Tools > Patron lists: Edit for action menu, on the form 'Modify patron list' - Tools > News: Edit for action menu, 'Edit news item' for the form - Patrons: Edit for the action, 'Modify patron [name...]' - Acquisitions > Vendor edit: 'Edit vendor' button, 'Update: [vendor name]' - Acquisitions > Baskets: 'Edit basket' button, 'Edit basket [basket name]' - Tools > CSV profiles: Edit for the action menu, 'Modify a CSV profile' Whatever way is decided (if anything) we should al least be consistent in the future, both from a user interface point of view and to help with translation. (Raised following comment 8 for bug 28037) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 28150] New: Don't include Koha::Object-base modules
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '23

04 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28150 Bug ID: 28150 Summary: Don't include Koha::Object-base modules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org We should use Koha::Objects-based modules, not the Koha::Object -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 25758] New: Items scheduled for automatic renewal do not show that they will not renew due to a hold
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '23

04 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758 Bug ID: 25758 Summary: Items scheduled for automatic renewal do not show that they will not renew due to a hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In the issues table on circulation.pl, we're no longer showing a message of "On Hold" when an item is scheduled for automatic renewal, is outside of the No Renewal Before window, but has a hold that will block renewal. This is a regression, most likely caused by bug 19014. To recreate: 1- set NoRenewalBeforePrecision to date only 2- set a circ rule to auto-renewal=yes, no renewal before=0, checkout period to 7 days 3- check item out 4- confirm item shows Scheduled For Automatic Renewal in issues table 5- place a hold on the item for another patron 6- reload issues table for patron 1, confirm checkout still shows "scheduled for automatic renewal" rather than "on hold" 7- change No Renewal Before value to 7 8- reload issues table for patron 1, confirm checkout now shows "on hold" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 81

[Bug 27892] New: api/v1/acquisitions_vendors.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '23

04 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27892 Bug ID: 27892 Summary: api/v1/acquisitions_vendors.t is failing randomly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org 10:51:09 koha_1 | # Failed test 'No tests run for subtest "list() and delete() tests | authorized user"' 10:51:09 koha_1 | # at t/db_dependent/api/v1/acquisitions_vendors.t line 112. 10:51:09 koha_1 | DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_kohadev`.`vendor_edi_accounts`, CONSTRAINT `vfk_vendor_id` FOREIGN KEY (`vendor_id`) REFERENCES `aqbooksellers` (`id`)) [for Statement "DELETE FROM `aqbooksellers`"] at /kohadevbox/koha/Koha/Objects.pm line 208 10:51:09 koha_1 | # Looks like your test exited with 255 just after 1. Master_D9 (#1590) Looks like we are missing a "on delete cascade" on vendor_edi_accounts -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 17596] New: Simplify accounting UI in staff client
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '23

03 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Bug ID: 17596 Summary: Simplify accounting UI in staff client Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com This bug is omnibus for our effort on simplifying accounting UI and workflow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 33

[Bug 20944] New: Add routes to add credits and debits to a patron's account
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '23

03 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Bug ID: 20944 Summary: Add routes to add credits and debits to a patron's account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 31

[Bug 21043] New: Add routes to add debits to a patron's account
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '23

03 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Bug ID: 21043 Summary: Add routes to add debits to a patron's account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 51

[Bug 27141] New: QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '23

03 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 Bug ID: 27141 Summary: QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Since QueryAutoTruncate automatically disables QueryWeightFields, it does not make sense that both are set to 1 in "./installer/data/mysql/sysprefs.sql" I think that we should have QueryWeightFields set to 0 for new installations. It would even be tempting to set QueryWeightFields to 0 where QueryAutoTruncate is set to 1 on existing installs, except that someone might be (unwisely) trialling different Query* settings before/during a Koha upgrade. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7