August 2021 - Koha-bugs - lists.koha-community.org

[Bug 27463] New: OAI-PMH date handling in ListBase.pm
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '22

12 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27463 Bug ID: 27463 Summary: OAI-PMH date handling in ListBase.pm Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: rudolfbyker(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Currently in Koha/OAI/Server/ListBase.pm two different criteria are used for querying dates and displaying dates. When displaying the "Last Modified" date, this is used: SELECT MAX(timestamp) FROM ( SELECT timestamp FROM biblio_metadata WHERE biblionumber = ? UNION SELECT timestamp FROM deleteditems WHERE biblionumber = ? UNION SELECT timestamp FROM items WHERE biblionumber = ? ) bi But when querying, only biblio_metadata.timestamp is used. This should be made consistent. We could use a query like this (using a join, but removing the need to do a separate query for each record, so it might actually be faster than what we have now): select bm.biblionumber, greatest(bm.timestamp, i.timestamp) as t from biblio_metadata bm inner join items i on bm.biblionumber=i.biblionumber having t >= '2020-07-14' and t <= '2020-07-15' limit 10; Furthermore, we should only use items.timestamp and deleteditems.timestamp when the user has the "include_items" option set in their OAI-PMH config. It does not make sense to query item timestamps if you are only sending data about the records, and not the items. Therefore, if "include_items" is disabled, we can do a simpler query: select biblionumber, timestamp from biblio_metadata where timestamp >= '2020-07-14' and timestamp <= '2020-07-15' limit 10; See full discussion on IRC: http://irc.koha-community.org/koha/2021-01-18#i_2324076 Definition of "datestamp" for reference: https://www.openarchives.org/OAI/openarchivesprotocol.html#Datestamp -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 19064] New: OAI-PMH Records appearing in OAI that can' t be found in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '22

12 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19064 Bug ID: 19064 Summary: OAI-PMH Records appearing in OAI that can't be found in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: marrone.patricio(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Hello, While harvesting Koha records from the OAI-PMH interface, I found a series of records that can't be accessed using the OPAC interface. That is, the harvester finds a record with an identifier, say http://example.com/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=oai_dc… that shows the complete record. Trying to link to the OPAC using the biblionumber in the last part of the identifier, say http://example.com/cgi-bin/koha/opac-detail.pl?biblionumber=572 I get a 404 error. I have yet to confirm this, but this might be related to the records being hidden in the OPAC view being leaked into OAI. In that case, I would expect the record to have a deleted status in OAI so that in can be removed from the harvesting results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 28287] New: reports execution should stop on execute_query errors
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '22

06 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28287 Bug ID: 28287 Summary: reports execution should stop on execute_query errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: didier.gautheron(a)biblibre.com Reporter: didier.gautheron(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org nbe_rows is computed even if execute_query return an error. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 28804] New: 500 Error when running report with bad syntax
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '22

06 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Bug ID: 28804 Summary: 500 Error when running report with bad syntax Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: jstallings(a)tsas.org QA Contact: testopia(a)bugs.koha-community.org In previous versions, running an SQL report with an error (typo, bad syntax) would yield an error page with the problem syntax highlighted. 21.05 returns only a 500 error. Excerpt from plack-intranet-error.log here: https://pastebin.com/0UCYkU46 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 20627] New: Prevent leakages of user permissions to api access tokens
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '22

06 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20627 Bug ID: 20627 Summary: Prevent leakages of user permissions to api access tokens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: dcook(a)prosentient.com.au, dpavlin(a)rot13.org, julian.maurice(a)biblibre.com, katrin.fischer(a)bsz-bw.de, oleonard(a)myacpl.org, tomascohen(a)gmail.com Depends on: 20568 Blocks: 20612, 20624 Bug #20568 allow users to create API access tokens, but it always associates all a users permissions with that access token and additionally if that user comes to have more permissions down the line those additional permissions are automagically added to the access token as well. This is generally bad practice for access tokens as in general, they should be of a definite scope and any time additional privileges are required the client application should have to ask for them and receive a new token with the additional privileges assigned to it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 [Bug 20568] Add API key management interface for patrons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 [Bug 20612] Make OAuth2 use patron's client_id/secret pairs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624 [Bug 20624] Allow switching off the OAuth2 client credentials grant -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 19556] New: Added Content ISBN Does Not Match MARC 020
by bugzilla-daemon＠bugs.koha-community.org 04 Oct '22

04 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19556 Bug ID: 19556 Summary: Added Content ISBN Does Not Match MARC 020 Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: jyorio(a)esilibrary.com QA Contact: testopia(a)bugs.koha-community.org This came to my attention with Novelist Select, but it does not appear to only relate to that. Here's what I'm seeing: Issue 1: A MARC record shows the 020 $a as "9780345813602 (hardcover) :" (minus quotes). The Novelist Select section of detail shows as blank. Novelist support reports seeing that they're getting a 9-digit ISBN 034581360. When I inspect the Novelist Select section, Koha appears to be passing 034581360X. <div data-novelist-novelistselect="034581360X"> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15772 mentions that Novelist can't interpret 10-digit ISBNs ending in X and this seems to be consistent with that. Issue 2 (less problematic from a patron perspective): A MARC record shows the 020 $a as "9781408810552" (minus quotes). The Novelist Select section shows the expected results. Novelist support reports getting ISBN 1408810557 This is a valid ISBN for the title, but not the one on the record. When I inspect the Novelist Select section of the details page, Koha appears to be passing 1408810557. <div data-novelist-novelistselect="1408810557"> In both cases above, ISBNs used for Novelist Select are the same as used for gbs-thumbnail-preview, however the cover image is returned in both cases. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 19309] New: Add ReservesMaxPickUpDelay to the Circulation Matrix
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '22

03 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19309 Bug ID: 19309 Summary: Add ReservesMaxPickUpDelay to the Circulation Matrix Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: jzairo(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Some libraries would love to have the option to specify the ReservesMaxPickUpDelay by itemtype, rather than specify the ReservesMaxPickUpDelay for all items via the system preference. There are times when specific item types like popular or new items, DVD's or even Museum passes may not want to sit on a shelf for 7 days waiting for the patron to pick it up. Versus a non popular item that can wait for 7 days for the patron to pick the item up. Moving ReservesMaxPickUpDelay to the circ matrix would allow the library to choose the patron category and item type providing more flexibility for items waiting to be picked up by the patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 19318] New: Add ability to use custom file upload paths
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '22

02 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 Bug ID: 19318 Summary: Add ability to use custom file upload paths Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Some libraries don't like the hard coded way uploaded files are all put in the same directory with the hash prefixing the file. We should allow uploaded files to retain their original name, and optionally specify a path to upload to I'm imagining we could accomplish this with something along these lines: 1) Add option on file upload page to not add file checksum to the uploaded filename, modify Koha::Upload 2) Modify Koha::Upload to support this option 3) Create new Authorised Value UPLOAD_PATH to define a set of upload paths 4) Add new 'upload path' option to file upload form as a pulldown of defined upload paths 5) Add new column 'file_path' to uploaded_files table 6) Modify Koha::Upload to support the automatic creation and use of custom file upload paths -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 48

[Bug 28353] New: regression: Batch Item Deletion no longer shows which items were not removed
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '22

30 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Bug ID: 28353 Summary: regression: Batch Item Deletion no longer shows which items were not removed Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: bwsdonna(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org In 19.11 when using the batch item deletion tool, the confirmation screen included the total number of items and bibs deleted, and listed the items that could not be deleted, such as if they were checked out, etc. In 20.05 the user only sees the number of items and bibs deleted and no message that items in the batch were not deleted. The results page should show a list of items in the batch that were not able to be deleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27

[Bug 27051] New: opac-library.tt should include email
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '22

27 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27051 Bug ID: 27051 Summary: opac-library.tt should include email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org opac-library.tt omits the branch email address. This information would be nice to show on the page as a 'mailto:' link. -- You are receiving this mail because: You are watching all bug changes.

1 12