February 2022 - Koha-bugs - lists.koha-community.org

[Bug 29877] New: MaxReserves should be enforced consistently between staff interface and API
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '22

21 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Bug ID: 29877 Summary: MaxReserves should be enforced consistently between staff interface and API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com To test: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron via staff interface, but the second is blocked 4 - confirm you can place 1 for a patron via API, but the second is blocked 5 - set maxreserves to 0 6 - confirm you can place any number of holds for the patron via the staff interface 7 - confirm you can place 0 holds for your patron via the API 8 - set maxreserves to blank 9 - confirm you can place any number of holds for the patron 10 - confirm you can place 0 holds for your patron via the API We should make the API treat zero and blank as un-set, as the staff interface does. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 30

[Bug 29754] New: Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '22

21 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 Bug ID: 29754 Summary: Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The check for fines amount when using this pref fetches the patrons fines, then adds the total fines with guarantors, including this borrowers fines. This means the patrons own fines are doubled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 26269] New: "Download file of displayed overdues" in Circulation->Overdues produces .csv with fewer results than the displayed list under certain circumstances
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '22

21 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 Bug ID: 26269 Summary: "Download file of displayed overdues" in Circulation->Overdues produces .csv with fewer results than the displayed list under certain circumstances Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: theod(a)lib.auth.gr QA Contact: testopia(a)bugs.koha-community.org in Circulation->Overdues, when requesting the overdues for: - a FUTURE DATE (Date Due TO is > today ) AND - Show any items currently checked out IS checked, we get a list with several of results, as expected. However, when we click on the "Download file of displayed overdues", the overdue.pl script produces a .csv file with FEWER results and contains ONLY results that have "Date due TO < today". This was first discovered in our previous production Koha version (18.11.04), but is also valid in our current 18.11.11 version AND current master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22

[Bug 29220] New: Minor fixes and improved code readability in circulation.pl
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '22

21 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29220 Bug ID: 29220 Summary: Minor fixes and improved code readability in circulation.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com While debugging another issue I found myself severely confused by some parts of the code in circulation.pl. By reviewing some earlier commits I worked out what is most likely the intent of the code and refactored it to clearer communicate that intent. The culprit of my confusion was this: https://github.com/Koha-Community/Koha/commit/1a8ca21875f86f25c72baf38e29d2… While the previous version was straight forward, this change is confusing since trying to do at least two things at once. What we want to do as far as I understand is to check for some serious errors (in this case UNKNOWN_BARCODE, but theoretically could be others as well) and allow forced onsite checkouts for all errors except for those ones. Since the display of all non blocking errors are hidden in the staff client for forced onsite checkouts, for consistency, these errors should also be hidden if some blocking error occurs. The alternative behavior would be very confusing. Now, only by chance, UNKNOWN_BARCODE is the first error in CanBookBeIssued to be checked for and retursn immediately after, so no other errors are ever registered in that case. But this could change in the future, and would cause a behavior where all errors are shown if a blocking error occur, but no errors are shown if not (for forced on site checkouts). I refactored this part to fix this issue and more clearly communicate the intended behavior. I also discovered some minor bugs introduced in various commits: https://github.com/Koha-Community/Koha/commit/2e72eb888016f60ce15958ecb37e0… "delete $question->{'DEBT'} if ($debt_confirmed);" is accidentally moved inside an if condition, when it should really always be performed as far as I can tell. https://github.com/Koha-Community/Koha/commit/7a7a0a2474c958e85b96db55bba04… Here an explicit check for DEBT_GUARANTORS is added, as a blocking error (an error that will not be ignored for on site checkouts with OnSiteCheckoutsForce enabled. That seems inconsistent with the settings description "Enable/Disable the on-site for all cases (Even if a user is debarred, etc." and the fact that all other errors returned by CanBookBeIssued UNKNOWN_BARCODE are ignored. This includes DEBT_GUARANTEES, DEBT, RESTRICTED etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 29886] New: Add Koha::Suggestions->search_limited
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '22

21 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Bug ID: 29886 Summary: Add Koha::Suggestions->search_limited Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org SearchSuggestion does filtering on IndependentBranches, etc. We need to implement Koha::Suggestions->search_limited that does that as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 28

[Bug 30164] New: Header filter not taken into account on the cities view
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '22

21 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30164 Bug ID: 30164 Summary: Header filter not taken into account on the cities view Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff Client Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The "Search cities" filter in the header is not taken into account and all the cities are displayed. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 30153] New: FindDuplicate ElasticSearch should not use lowercase 'and'
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '22

21 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Bug ID: 30153 Summary: FindDuplicate ElasticSearch should not use lowercase 'and' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: domm(a)plix.at C4::Search->FindDuplicate joins title and author using 'and' (lowercase). When this query is passed on to ElasticSearch, it interprets the lowercase 'and' as a term to search for, because the operator has to be in uppercases ('AND'). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 28663] New: One should not be able to apply a discount to a VOID accountline
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '22

21 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 Bug ID: 28663 Summary: One should not be able to apply a discount to a VOID accountline Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 27971 Blocks: 13985 When adding the VOID account line type in bug 27971 I neglected to update the logic for the display of the 'Apply discount' button on the patron transactions page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27971 [Bug 27971] The VOID method should be updated to respect double-entry accounting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26

[Bug 30147] New: OpacBrowseResults causing error on detail page
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '22

20 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 Bug ID: 30147 Summary: OpacBrowseResults causing error on detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org On the ktd sample database when trying to go to the detail page from the result list: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_opac_opac_2ddetail_2epl::searchResults called at /kohadevbox/koha/opac/opac-detail.pl line 260 Turning off OpacBrowseResults makes the error disappear. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 29826] New: Remove warning in t/db_dependent/Template/Plugin/Branches.t
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '22

20 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Bug ID: 29826 Summary: Remove warning in t/db_dependent/Template/Plugin/Branches.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Bug 26587 added a concatenation that sends a warning if var is undef : $ prove t/db_dependent/Template/Plugin/Branches.t Use of uninitialized value $branchcode in concatenation (.) or string at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 35. -- You are receiving this mail because: You are watching all bug changes.

1 24