April 2022 - Koha-bugs - lists.koha-community.org

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #142 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133987&action=e… Bug 14242: (follow-up) Hide autofil when syspref disabled, clear ISBN Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #141 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133986&action=e… Bug 14242: (follow-up) Format copyright date before plugged into form This patch formats the copyright date so that only the year shows before plugging the formatted version into the form. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131219|0 |1 is obsolete| | Attachment #131220|0 |1 is obsolete| | Attachment #131221|0 |1 is obsolete| | Attachment #131222|0 |1 is obsolete| | --- Comment #140 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133985&action=e… Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACSuggestionAutoFill" 3. Log into OPAC and go to purchase suggestions page 4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into the ISBN field and click the 'search google books' button, or unfocus the field. 5. Title, Author, Publisher, publication year and Item Type fields should now be filled automatically. 6. Press "clear form" to undo - should restore all fields that the API pull filled to empty Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #187 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133957&action=e… Bug 12446: Fixing QA tool's tests This patch fixes tests that fails by the QA test tool. I removed the debug variable, since it is not used. I also got a few spelling check errors when I ran the QA test tool. I corrected them too. To test: 1) Create an Adult AND Child category in Administration/Patron categories 2) Create a child AND adult patron. 3) Go in your child patron's page. 4) Click on "Edit". 5) Notice that you can add a guarantor with "Add guarantor" button. 6) Go in your adult patron's page. 7) Click on "Edit". 8) Notice that there is no "Add guarantor" button. Therefore, you can't add a guarantor for this patron. 9) Apply patch and run updatedatabase.pl 10) Go in Administration/Patron categories and edit one of them. 12) Notice that you can see the new "Can be guarantee" field. 13) Set "Yes" on the "Can be guarantee" field for your Child AND Adult category. 14) Repeat steps 6 to 7. 15) Notice that your adult patron can now add guarantors with the "Add guarantor" button. 16) prove t/db_dependent/Patrons.t => All tests should still pass 17) Run the QA test tool. All tests should say OK Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #186 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133956&action=e… Bug 12446: Any patron categories can have guarantors Rebase of previous patches This patch allows adult patrons to have guarantors. It adds the field "Can be guarantee" to patron categories, so it becomes possible for any category type to have a guarantor. NOTE: Attachment "Bug 12446: Adult can now have guarantors" created a sha1 error. I marked it as obsolete and put it's content into a new commit. To test: 1) Create an Adult AND Child category in Administration/Patron categories 2) Create a child AND adult patron. 3) Go in your child patron's page. 4) Click on "Edit". 5) Notice that you can add a guarantor with "Add guarantor" button. 6) Go in your adult patron's page. 7) Click on "Edit". 8) Notice that there is no "Add guarantor" button. Therefore, you can't add a guarantor for this patron. 9) Apply patch and run updatedatabase.pl 10) Go in Administration/Patron categories and edit one of them. 12) Notice that you can see the new "Can be guarantee" field. 13) Set "Yes" gor the "Can be guarantee" field for your Child AND Adult category. 14) Repeat steps 6 to 7. 15) Notice that your adult patron can now add guarantors with the "Add guarantor" button. 16) prove t/db_dependent/Patrons.t => All tests should still pass Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #185 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133955&action=e… Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #184 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133954&action=e… Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #183 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133953&action=e… Bug 12446: Schema update Category.pm Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131965|0 |1 is obsolete| | Attachment #131966|0 |1 is obsolete| | Attachment #131967|0 |1 is obsolete| | Attachment #131968|0 |1 is obsolete| | Attachment #131969|0 |1 is obsolete| | Attachment #133691|0 |1 is obsolete| | --- Comment #182 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133952&action=e… Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0