April 2022 - Koha-bugs - lists.koha-community.org

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '22

27 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113100|0 |1 is obsolete| | --- Comment #23 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- Created attachment 134015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134015&action=e… Bug 12133: Enforce guarantor restrictions on Koha::Patron->store() This patch adds checks for new guarantor requirements to Koha::Patron->store(). If requirements aren't met exception is raised. To test prove t/db_dependent/Koha/Patron.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '22

27 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113099|0 |1 is obsolete| | --- Comment #22 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- Created attachment 134014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134014&action=e… Bug 12133: Fix issues with modifying child patron and adding guarantors Child patrons couldn't be modified when guarantor was patron due missing guarantor_id value. Also if multiple guarantors were added one could easily add child patron as a guarantor. This patch adds Instead of one guarantor id all new and existing guarantor ids are checked in case of child patron. To test: 1. Add child patron with syspref ChildNeedsGuarantor and GuarantorNeedsToBePatron on. 2. Add two guarantors for the patron, first one should be an adult patron and second a child. 3. Save patron. => Error "A guarantor cannot be a guarantee." should be raised but isn't. 4. Modify patron and save. => Error "Child needs guarantor" is raised even if (valid) guarantor exists. 5. Apply patch. 6. Repeat steps 1 to 4. => This time while saving a new patron error "A guarantor cannot be a guarantee." is raised but modifying is successful. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '22

27 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94544|0 |1 is obsolete| | --- Comment #21 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- Created attachment 134013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134013&action=e… Bug 12133: Add requirements for guarantor and guarantee Add three requirements when registering a new patron: - A child patron must have a guarantor. This is controlled by a new syspref ChildNeedsGuarantor. - A guarantor has to be a patron. This is controlled by a new syspref GuarantorHasToBePatron. - A guarantor cannot be a guarantee. Test plan: -Add child patron without guarantor or child patron with guarantee as guarantor succesfully. - Apply this patch. - Add a child patron with a guarantee as guarantor. Error is raised. - Turn syspref "ChildNeedsGuarantor" ON. - Add a child patron without a guarantor and error "Child needs a guarantor" is raised. - Add guarantor. Guarantor can either be existing patron or added with "Contact" section. Save without errors. - Turn syspref "GuarantorNeedsToBePatron" ON. - Form fields for "Contact" section aren't displayed and only existing patron can be added as guarantor. Signed-off-by: Johanna Raisa <johanna.raisa(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30535] New: Add "Tool plugins" to the main tools screen
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '22

27 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30535 Bug ID: 30535 Summary: Add "Tool plugins" to the main tools screen Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: fred.king(a)medstar.net QA Contact: testopia(a)bugs.koha-community.org On the main Tools page in 21.05, "Tool plugins" is missing from "Additional tools." If you select any one of the tools, it appears in the column of tools on the left side of the screen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 5316] Limit Z39.50 targets to specific users
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '22

27 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5316 Holly <hc(a)interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc(a)interleaf.ie -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '22

27 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 [Bug 30568] Make patron name fields more flexible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '22

27 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Bug 7680 depends on bug 22279, which changed state. Bug 22279 Summary: Unify patron name display https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22279 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 22279] New: Unify patron name display
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '22

27 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22279 Bug ID: 22279 Summary: Unify patron name display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: pasi.kallinen(a)koha-suomi.fi QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- The way patron's name is displayed should be unified into a single place. There's template code in patron-title.inc for it, but it's not used in enough places. Using that would make the patron name display consistent, and if change is needed (eg. for GDPR), it would be easy to change. For example: koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc: <li><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber | uri %]&findborrower=[% holdfor_cardnumber | uri %]">Place hold for [% holdfor_firstname | html %] [% holdfor_surname | html %] ([% holdfor_cardnumber | html %])</a></li> koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc: .append( "<a>" + item.surname + ", " + item.firstname + " (" + item.cardnumber + ") <small>" + item.dateofbirth + " " + item.address + " " + item.city + " " + item.zipcode + " " + item.country + "</small></a>" ) koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc: <td><a href="[% data_url | url %]">[% borrower.surname | html %], [% borrower.firstname | html %]</a></td> koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt: <title>Summary for [% patron.firstname | html %] [% patron.surname | html %] ([% patron.cardnumber | html %])</title> koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt: <a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% patron.borrowernumber | uri %]">Pay fines for [% patron.firstname | html %] [% patron.surname | html %]</a> &rsaquo; and many, many more. -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 30072] New: Add more holds hooks
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '22

27 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Bug ID: 30072 Summary: Add more holds hooks Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We should add more plugin hooks. At least: - after_hold_fill - after_hold_cancel -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 48

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #143 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133988&action=e… Bug 14242: (follow-up) Clear all text input fields Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0