April 2022 - Koha-bugs - lists.koha-community.org

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131723|0 |1 is obsolete| | --- Comment #185 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 133093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133093&action=e… Bug 8367: (follow-up) Remove pickup delay message from OPAC It adds unnecessary complexity and information. Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131722|0 |1 is obsolete| | --- Comment #184 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 133092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133092&action=e… Bug 8367: (follow-up) Fix pickup delay text on OPAC and other bits Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131720|0 |1 is obsolete| | --- Comment #183 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 133091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133091&action=e… Bug 8367: Make database update idempotent (across different MariaDB versions) The previous query seemed to work on MariaDB 10.1.48 (used by koha-testing-docker), but it didn't work on MariaDB 10.3.29 (default in Debian 10 as of this writing), but this patched query works on both indempotently. Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131719|0 |1 is obsolete| | --- Comment #182 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 133090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133090&action=e… Bug 8367: Make database update idempotent Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131718|0 |1 is obsolete| | --- Comment #181 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 133089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133089&action=e… Bug 8367: Add holds_pickup_period circulation rule So that pickup delay can have a different value per patron category, item type or branch. To test: 1) Update database, restart services 2) Set ReservesMaxPickUpDelay syspref (if not already set) 3) Edit your circulation rules and set a value under 'Holds pickup period (day) that is DIFFERENT from ReservesMaxPickUpDelay. Set a few different numbers for different branches as well. 4) Place a hold on a biblio from the staff client. 5) Check in an item from that biblio and confirm the hold as waiting 6) Confirm the expiration date is calculated using the 'Holds pickup period' value instead of the ReservesMaxPickUpDelay syspref 7) Revert the waiting status and delete the hold 8) Re-place the hold on the biblio on the OPAC. Notice that when you change the pick up location, the number of days in the pickup message below the dropdown changes based on the circ rules. 9) Create a holiday with a date that will overlap with the 'Holds pickup period' 10) Check in an item from that biblio and confirm the hold as waiting 11) Confirm the expiration date is calculated using the 'Holds pickup period' value AND considers the special holiday 12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t 13) Test Talking Tech: 13a) Enable TalkingTechItivaPhoneNotification 13b) Go to Tools -> Notices & slips. Add content to the HOLD phone (itiva) notice. 13c) In your terminal, run perl /path/to/koha/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl -o ~/itiva.tmp -w 0 --type=RESERVE Sponsored-by: Catalyst IT Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 28264] New: Transaction type is empty is cash register statistics wizard report
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264 Bug ID: 28264 Summary: Transaction type is empty is cash register statistics wizard report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org Hi all! When I do a report using the statistics wizard, the transaction type doesn't appear. I think maybe this has something to do with the "new" structure for accounttypes which are now separated in credit_type_code and debit_type_code... To test: 1) Go into a patron file and add some manual fees and pay them 2) Go to Reports > Statistics wizards > Cash register 3) In the form, choose Transaction type: All transactions 4) Click "Submit" 5) Note that the Transaction type column is empty 6) In the form, choose Output: To a file 7) Click "Submit" 8) Open the file in a spreadsheet software (I use LibreOffice) 9) The Transaction type column is empty A client reported this to me after we upgraded them from 19.05.04 to 20.05.08. In 20.05 (in the client's db), the Transaction type column is filled when viewing the report in the browser, but when we export the report, it's empty. In my master (default db), the transaction types don't appear in either cases. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30414] New: Inconsistent (duplicated) FK constraint name: aqbudgets.aqbudgetperiods_ibfk_1
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30414 Bug ID: 30414 Summary: Inconsistent (duplicated) FK constraint name: aqbudgets.aqbudgetperiods_ibfk_1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CREATE TABLE `aqbudgets` ( [etc] CONSTRAINT `aqbudgetperiods_ibfk_1` FOREIGN KEY (`budget_period_id`) REFERENCES `aqbudgetperiods` (`budget_period_id`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; Normally, our constraints have the prefix showing the source table not the destination (aqbudgetperiods) like here. DBrev20.06.00.055 contained this: if ( !foreign_key_exists( 'aqbudgets', 'aqbudgetperiods_ibfk_1' ) ) { $dbh->do(q| ALTER TABLE aqbudgets ADD CONSTRAINT `aqbudgetperiods_ibfk_1` FOREIGN KEY (`budget_period_id`) REFERENCES `aqbudgetperiods` (`budget_period_id`) ON UPDATE CASCADE ON DELETE CASCADE |); This created aqbudgetperiods_ibfk_1 next to aqbudgets_ifbk_1 that we already had in our production table. Note that DBrev 3.01.00.077 already contained that one: ALTER TABLE `aqbudgets` ADD CONSTRAINT `aqbudgets_ifbk_1` FOREIGN KEY (`budget_period_id`) REFERENCES `aqbudgetperiods` (`budget_period_id`) ON DELETE CASCADE ON UPDATE CASCADE Conclusion: Older Koha database may contain a duplicated FK constraint. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 26381] New: Koha should provide Koha plugins with a template to use with Template::Toolkit WRAPPER
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26381 Bug ID: 26381 Summary: Koha should provide Koha plugins with a template to use with Template::Toolkit WRAPPER Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org At the moment, Koha plugins have to built their own templates from scratch. I'm proposing that Koha provides a BLOCK or a template file that Koha plugins can then use with the Template::Toolkit WRAPPER directive to minimize the amount of boiler plate they have to use. Here is an example of a very simple "plugin_wrapper" [% BLOCK plugin_wrapper %] [% INCLUDE 'doc-head-open.inc' %] <title>Koha: [% name %]</title> [% INCLUDE 'doc-head-close.inc' %] </head> <body> [% INCLUDE 'header.inc' %] [% INCLUDE 'cat-search.inc' %] <div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/plugins/plugins-home.pl">Plugins</a> &rsaquo; [% breadcrumb %]</div> <div id="doc3"> [% content %] [% INCLUDE 'intranet-bottom.inc' %] [% END %] Then, in my report-step1.tt file, all I need to include is the following: [% WRAPPER plugin_wrapper name = 'My Plugin' breadcrumb = 'My Plugin' %] <div>Plugin content</div> [% END %] I've already tested this a little bit, and it's beautiful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8