July 2022 - Koha-bugs - lists.koha-community.org

[Bug 18315] New: authentication and authorization refactoring
by bugzilla-daemon＠bugs.koha-community.org 07 May '25

07 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18315 Bug ID: 18315 Summary: authentication and authorization refactoring Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt(a)gmail.com Reporter: oha(a)oha.it QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Currently, C4::Auth is responsible to do session management, authentication and authorization. There is no clear separations between them, and the authentication is not modular, making it increasingly harder to maintain and/or introduce no authentication integrations. I was experimenting on this for a while, and I managed to put together few commits in a branch. It started as a proposal, but turned out to be working in _most_ of my tests. here more details: I completely removed any need for CGI and CGI::Session while maintaining a fork-exec aproach to the scripts. (This made it easier to implement Koha::Middleware::Session, Koha::Session::DB and ::KohaCache) Koha::Middleware::Session inject a session object in the Plack request, and invoke Koha::Auth if any authentication tokens are available. Koha::Auth has a list of modules which will be invoked in turn and could be enabled/disabled plack.psgi is changed as well, it has enabled the new Middleware and the applications used are no longer Plack::App::CGIBin but Koha::Middleware::App. here few of the things i want to do to simplify the interaction with the current "legacy" code: I didn't change the scripts or any other module at all, instead I tried to hijack C4::Auth methods to rely on Koha::Session and Koha::Auth. This make it simple to switch back to the previous plack.psgi OR using apache and the normal cgi-bin. authentication should happen upfront, before the script is even started. script will have to verify authorization. authentication MUST be modular, possibly having different systems cooperate. (Some serious discussions must be around this point, especially about accounting and authority) what needs to be done: permissions should be reintroduced. right now permissions are read for the user and set in the template, but no checks are perform on requests. (should be fairly simple to do) reintroduce the code related to shib, cas and any other. more testing, especially for the installer (there is lots of code regarding the web installer which isn't there anymore) -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 28760] New: Granular restrictions
by bugzilla-daemon＠bugs.koha-community.org 05 May '25

05 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28760 Bug ID: 28760 Summary: Granular restrictions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com It would be great if restrictions has more options. It would be great if we could restrict specific item checkouts or holds on a patron, if needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 18298] New: Enforce password complexity
by bugzilla-daemon＠bugs.koha-community.org 05 May '25

05 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Bug ID: 18298 Summary: Enforce password complexity Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Some libraries would want to add the option to Koha to enforce a strong password policy. That policy would mean that passwords should include both upper and lower case characters one or more numbers. -- You are receiving this mail because: You are watching all bug changes.

1 91

[Bug 17406] New: Simplify pay.pl interface - pt.1
by bugzilla-daemon＠bugs.koha-community.org 02 May '25

02 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406 Bug ID: 17406 Summary: Simplify pay.pl interface - pt.1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com I think we can simplify the payment screen. 1) Remove the Pay Amount button. By default, all items are selected, so the Pay selected will do the job. 2) Remove the cancel link. A) It's a link, not a button. B) All it does is change tabs. There isn't anything to really cancel. Changing tabs or navigating elsewhere does the same thing. 3) Remove Write off all button and replace with Write off selected button. 4) Remove the individual Pay and Write off buttons. They are redundant. #4 is my opinion, but they really convolute the flow. The checkboxes and two buttons are sufficient and straight forward. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 19442] New: add patron attributes into the patron card creator
by bugzilla-daemon＠bugs.koha-community.org 01 May '25

01 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19442 Bug ID: 19442 Summary: add patron attributes into the patron card creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Work to be done: 1 - Add the ability to define fields as attribute.CODE in the card creator template 2 - When these codes are found replace them with the correct value for the patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 18292] New: t/db_dependent/Circulation.t Dubious, test returned 1 even if test ok
by bugzilla-daemon＠bugs.koha-community.org 01 May '25

01 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 Bug ID: 18292 Summary: t/db_dependent/Circulation.t Dubious, test returned 1 even if test ok Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 40

[Bug 31207] New: The OPAC Shelf browser fails to display local cover images
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '25

30 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207 Bug ID: 31207 Summary: The OPAC Shelf browser fails to display local cover images Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: a.roussos(a)dataly.gr QA Contact: testopia(a)bugs.koha-community.org In the OPAC Details page for a biblio, opening the Shelf browser will display adjacent items next to each other based on their call number and also display any cover images found. It's a very useful OPAC feature that allows librarians to have a "virtual" look at their library shelves. This is currently broken *when local covers are exclusively in use*, as it fails to fetch the related local cover images from the DB. Steps to reproduce: TL;DR: Just visit the sandbox URL below and see for yourself ;-) https://opac-shlfbrwsr.sandboxes.biblibre.eu/cgi-bin/koha/opac-detail.pl?bi… Go to Home > Administration > System preferences in the Staff interface: - in section 'OPAC -> Shelf browser', make sure OPACShelfBrowser is enabled (i.e. set to 'Show') - in section 'Enhanced content -> Local or remote cover images', make sure both LocalCoverImages and OPACLocalCoverImages are enabled (i.e. set to 'Display') - make sure no other cover image provider is enabled - make sure OpacSeparateHoldings and OpacSeparateHoldingsBranch are set to 'Don't separate' and 'home library', respectively Next, in the Staff interface, find a record without any local cover images (either at the biblio or at the item level), having at least one item attached to it that has a Call number (the call number value can be anything -- it's only needed to trigger the display of the 'Browse shelf' hyperlink). Use the 'Images' tab in the Details page of the record to upload a local cover image at the biblio level (do *not* upload any item-level cover image). Finally, in the OPAC, visit the Details page of the record you just added the cover image to, and click on the 'Browse shelf' link found in the 'Call number' column. When the Shelf browser expands, you'll notice that there is no cover image displayed for the item(s) that belong to your test biblio. -- You are receiving this mail because: You are watching all bug changes.

1 38

[Bug 29730] New: Register text should be consistent in OPAC
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '25

29 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29730 Bug ID: 29730 Summary: Register text should be consistent in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org In OPAC when you are not logged in you can see a text telling to register : > git grep -i 'register here' -- koha-tmpl/ koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc: <p>Don't have an account? <a href="/cgi-bin/koha/opac-memberentry.pl">Register here.</a></p> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt: <a href="/cgi-bin/koha/opac-memberentry.pl">You may register here.</a> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt: <p>Don't have an account? <a href="/cgi-bin/koha/opac-memberentry.pl">Register here.</a></p> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt: [% IF PatronSelfRegistration && PatronSelfRegistrationDefaultCategory %]<div id="patronregistration"><p>Don't have an account? <a href="/cgi-bin/koha/opac-memberentry.pl">Register here.</a></p></div>[% END %] We see that opac-auth.tt text is not consistant with other ones. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 30951] New: Duplicate entry 'ar' for key 'PRIMARY'
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '25

29 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951 Bug ID: 30951 Summary: Duplicate entry 'ar' for key 'PRIMARY' Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: vbovictor(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org In Ubuntu 20.04.4 LTS mysql Ver 15.1 Distrib 10.4.14-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 ERROR koha-upgrade-schema library Upgrade to 21.12.00.013 [19:25:20]: Bug 29605 - Resync DB structure for existing installations ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'ar' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 28171] New: Serial enumeration / chronology sorting is broken in biblio page
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '25

28 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 Bug ID: 28171 Summary: Serial enumeration / chronology sorting is broken in biblio page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl, nugged(a)gmail.com, oleonard(a)myacpl.org Depends on: 27980 In catalogue/detail.pl page the "Serial enumeration / chronology" column sorting is broken after the changes in bug 27980. To reproduce problem add 2 items, one with "A" and one with "B" value in "h - Serial Enumeration / chronology item" field. Then go to catalogue/detail.pl and try to sort by clicking on the "Serial enumeration / chronology" column. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27980 [Bug 27980] Replace obsolete title-string sorting: Catalog templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 48