July 2022 - Koha-bugs - lists.koha-community.org

[Bug 30806] New: Use patron-title.inc in member-flags template
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '22

12 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30806 Bug ID: 30806 Summary: Use patron-title.inc in member-flags template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 30617 We should use the patron-title include everwhere we display a patron title instead of templates mixing up formats. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617 [Bug 30617] [OMNIBUS] We should consistently use includes for patron name display -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 12225] SIP does not respect the "no block" flag
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '22

12 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137622|0 |1 is obsolete| | --- Comment #13 from David Nind <david(a)davidnind.com> --- Created attachment 137656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137656&action=e… Bug 12225: Re-implement no block flag for checkouts Test Plan ( assuming Koha Testing Docker or kohadevbox ): 1) Check out master 2) Start the SIP server ( edit the SIP config koha instutution to be "CPL" instead of "kohalibrary" ) 3) Telnet to 6001 4) Send 9300CNkoha|COkoha|CPCPL| 5) Send 11YY20220711 16350220250711 163502AOCPL|AA23529000035676|AB39999000001396|ACkoha|BON|BIN| 6) Note the due date for the checkout in Koha is not in the year 2025: Henry Acevedo (23529000035676) checked out Philippics. by Cicero, Marcus Tullius. 39999000001396 7) Apply this patch set 8) Restart all the things! 9) Check in the checkout 10) Repeat steps 3 through 5 11) Note the due date is now in 2025! Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12225] SIP does not respect the "no block" flag
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '22

12 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137578|0 |1 is obsolete| | --- Comment #12 from David Nind <david(a)davidnind.com> --- Created attachment 137655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137655&action=e… Bug 12225: Fix SIP message templates If a renewal via SIP would produce an error due to being on reserve, or exceeding maximum renewals, Koha's SIP2 implementation will refuse to renew the item even if the "no block" flag is set to Y. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12225] SIP does not respect the "no block" flag
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '22

12 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '22

12 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Kelly McElligott <kelly(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly(a)bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '22

12 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137649|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 137650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137650&action=e… Bug 14680: Always subtract discoutn form price to calculate estimated cost This patch simply removes a discrepancty where when a discount is provided on the order form we add the discount to the price, and when it comes form the vendor we subtract the discount. Discounts should always descrease the estimated cost To test: 0 - Have a vendor with a discount of 10% specified 1 - Export a record from your Koha 2 - Stage the record for import and match on biblionumber 3 - Add to a basket in acq from the staged file 4 - Select the title, and set order price to $10 and do not fill the discount field 5 - Add the order - note $10 RRP and $9 actual/budgeted cost 6 - Repeat 2&3 7 - Select the tile, set price $10 and discount 50% 8 - Add the order - note $20 RRP and $10 actual/budgeted cost! FAIL 9 - Apply patch, restart all 10 - Repeat 2-7 11 - Add the order, note $10 RRP and $5 actual.budgeted cost Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '22

12 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29607 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '22

12 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #47 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- Looks good to me as well. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '22

12 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|olli-antti.kivilahti(a)jns.fi |nick(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '22

12 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41551|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 137649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137649&action=e… Bug 14680: Always subtract discoutn form price to calculate estimated cost This patch simply removes a discrepancty where when a discount is provided on the order form we add the discount to the price, and when it comes form the vendor we subtract the discount. Discounts should always descrease the estimated cost To test: 0 - Have a vendor with a discount of 10% specified 1 - Export a record from your Koha 2 - Stage the record for import and match on biblionumber 3 - Add to a basket in acq from the staged file 4 - Select the title, and set order price to $10 and do not fill the discount field 5 - Add the order - note $10 RRP and $9 actual/budgeted cost 6 - Repeat 2&3 7 - Select the tile, set price $10 and discount 50% 8 - Add the order - note $20 RRP and $10 actual/budgeted cost! FAIL 9 - Apply patch, restart all 10 - Repeat 2-7 11 - Add the order, note $10 RRP and $5 actual.budgeted cost -- You are receiving this mail because: You are watching all bug changes.

1 0