July 2022 - Koha-bugs - lists.koha-community.org

[Bug 14680] When creating orders from a staged file discounts supplied in the form are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137650|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] When creating orders from a staged file discounts supplied in the form are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 137753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137753&action=e… Bug 14680: Always subtract discount from price to calculate estimated cost This patch simply removes a discrepancty where when a discount is provided on the order form we add the discount to the price, and when it comes form the vendor we subtract the discount. Discounts should always descrease the estimated cost To test: 0 - Have a vendor with a discount of 10% specified 1 - Export a record from your Koha 2 - Stage the record for import and match on biblionumber 3 - Add to a basket in acq from the staged file 4 - Select the title, and set order price to $10 and do not fill the discount field 5 - Add the order - note $10 RRP and $9 actual/budgeted cost 6 - Repeat 2&3 7 - Select the tile, set price $10 and discount 50% 8 - Add the order - note $20 RRP and $10 actual/budgeted cost! FAIL 9 - Apply patch, restart all 10 - Repeat 2-7 11 - Add the order, note $10 RRP and $5 actual.budgeted cost Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] When creating orders from a staged file discounts supplied in the form are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] When creating orders from a staged file discounts supplied in the form are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I'd like to add that $c is really not a nice name for a variable, but that was there 'before patch': my $c = $c_discount ? $c_discount : $bookseller->discount; -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] When creating orders from a staged file discounts supplied in the form are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |katrin.fischer(a)bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] When creating orders from a staged file discounts supplied in the form are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When creating orders from a |When creating orders from a |staged file defined |staged file discounts |discounts are added |supplied in the form are | |added -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] When creating orders from a staged file defined discounts are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

1 0

[Bug 14680] When creating orders from a staged file, MarcFieldsToOrder syspref defined discounts are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 --- Comment #10 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Katrin Fischer from comment #9) > Hi Nick, > > the original bug description and the patch test plan don't match up. > > The original bug is about when the discount is pulled from the record, not > the vendor. > > Should the patch be moved or the bug description be adjusted? It's the same - when discount populated from file or entered manually it gets subtracted, will adjust title -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24001] New: Cannot edit card template
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Bug ID: 24001 Summary: Cannot edit card template Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org To recreate: - Go to Home › Tools › Patron card creator › Templates - New > Card template - Save - Edit - Save => Can't bless non-reference value at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 C4::Creators::Profile::retrieve('C4::Patroncards::Profile', 'profile_id', 22, 'creator', 'Patroncards') called at /home/vagrant/kohaclone/C4/Patroncards/Profile.pm line 29 C4::Patroncards::Profile::retrieve('profile_id', 22, 'creator', 'Patroncards') called at /home/vagrant/kohaclone/patroncards/edit-template.pl line 78 -- You are receiving this mail because: You are watching all bug changes.

1 79

[Bug 14680] When creating orders from a staged file, MarcFieldsToOrder syspref defined discounts are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Nick, the original bug description and the patch test plan don't match up. The original bug is about when the discount is pulled from the record, not the vendor. Should the patch be moved or the bug description be adjusted? -- You are receiving this mail because: You are watching all bug changes.

1 0