July 2022 - Koha-bugs - lists.koha-community.org

[Bug 30780] New: Librarians with only "place_holds" permissions can not update holds data via REST API
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '22

13 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780 Bug ID: 30780 Summary: Librarians with only "place_holds" permissions can not update holds data via REST API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: johanna.raisa(a)koha-suomi.fi CC: tomascohen(a)gmail.com Cancel hold, suspend the hold and resume the hold endpoints have too high permissions for librarians with only "place_holds" permissions. As this was changed in the views, then the change should be added to the REST API also. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 30798] New: Columns Home library and Checked out from in wrong order on table settings for account_fines table
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '22

13 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30798 Bug ID: 30798 Summary: Columns Home library and Checked out from in wrong order on table settings for account_fines table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: emmi.takkinen(a)koha-suomi.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com As title reads, columns Home library and Checked out from are in wrong order on table settings. Because of this hiding Home library actually hides Checkout out from column and vice versa. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 30924] New: Recalls workflow - errors and issues: log viewer, patron details, transfers, cancelling once checked in (waiting for pickup)
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '22

13 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Bug ID: 30924 Summary: Recalls workflow - errors and issues: log viewer, patron details, transfers, cancelling once checked in (waiting for pickup) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: david(a)davidnind.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com I am getting several errors and issues when testing bug 30823 - BEFORE applying the patch. I thought these were fixed with some of the recent recalls bugs that were pushed to master. I'm not sure whether separate bugs are required, or just one to look at what is causing these. In the interim, I've created this bug. Scenario/settings using koha-testing-docker (up-to-date with master): - UseRecalls system preference: set to 'Use'. - RecallsLog system preference: set to 'Log'. - Circulation and fines rules: . Recalls allowed (total) = 5 . Recalls per record (count) = 2 . On shelf recalls allowed = 'If any unavailable' . Recall due date interval (day) = 3 . Recall overdue fine amount = 5 . Recall pickup period (day) = 2 - Patron B: Mary Burton (Midway) - Patron A: Henry Acevedo (Midway) - Record used to place recalls on: Programming Perl (biblionumber = 262, one item = 39999000011418, home library = Centerville) TLDR: - Log viewer: Error on log viewer for recalls once there is are logged recalls transactions - Transfers for recalls: error on transfers to receive - After check in and waiting for pickup: actions to cancel recall on several pages do not work Error 1: Setup and place a recall - log viewer error ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I get this error using the log viewer limited to the recalls module - recall placed, no other actions. Template process failed: undef error - The method Koha::Recall->item_level_recall is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x55d076a68a48)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 379 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 379 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 409 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 18 Template::Provider::__ANON__('Template::Context=HASH(0x55d074a2b5f0)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 161 .... Error 2: Viewing the check out page > checkouts tab for Mary - after recall placed ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ No checkouts are listed, sits on "Loading... you may continue scanning" in a floating box at the bottom of the page, with "Loading..." showing in the center of the table. Does not show other items checked out. The details page > checkouts tab is the same. Error 3: If a transfer is required ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Step 1: Check in the item (39999000011418) > Transfer to Midway required > Confirm recall and transfer. - Mary: checkouts list is now displaying - Henry: recalls tab showing "In transit to Midway" - Circulation > Recalls > Recalls queue: showing "In transit to Midway" - Circulation > Recalls > Recalls to pull: listed with button to "Cancel recall and return to: Centerville Step 2: Transfer to Midway - Change library to Midway - Ciculation > Transfers > Transfers to receive: get this error: Template process failed: undef error - The method Koha::Recall->borrowernumber is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x559d07b59d00)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 93 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 93 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 108 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 112 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 18 .... Step 3: Check in item (with library set to Midway) - Modal window with "Recall at Midway + Confirm recall" - Circulation > Recalls > Recalls awaiting pickup: listed - Circulation > Transfers > Transfers to receive: no errors - Record detail page in staff interface: showing as "Waiting at Midway since..." - Henry: recalls tab on patron page for check out and details sections - shows as "Ready for pickup" - Mary: nothing shown (as expected) Step 4: Checkout item - works as expected, But wait, there's more! 1. Once a recall is made, and checked in: a. On the staff interface item details page > recalls section - selecting from the Actions drop down list/button "Cancel recall and return to Centerville" does nothing. b. However, selecting the tick box and selecting "Cancel selected recalls" works. c. In addition, after you press "Cancel...": - the URL changes to http://127.0.0.1:8081/cgi-bin/koha/recalls/request.pl - clicking on normal (or any other tab gives you the message "The record you requested does not exist ()." - URL is http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber= 2. Once a recall is made, and checked in: . From Circulation > Recalls > Recalls queue: same as 1a and 1b. 3. Once a recall is made, and checked in: . From Circulation > Recalls > Recalls to pull: select "Cancel recall and return to: Centerville: generates this error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data truncated for column 'reason' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 ..... 4. On the patron details > recalls tab page for Henry, selecting Actions > "Cancel recall and return to: Cenetrville" does nothing (same as 1a). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27

[Bug 30399] New: Patron.t fails when there is a patron attribute that is mandatory
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '22

13 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Bug ID: 30399 Summary: Patron.t fails when there is a patron attribute that is mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org I noticed this while testing another bug and this is happening to me while using koha-testing-docker. To recreate: 1. sudo koha-shell kohadev 2. prove t/db_dependent/Koha/Patron.t 3. Tests pass. 4. Add a new patron attribute type and make it Mandatory by clicking the checkbox. 5. prove t/db_dependent/Koha/Patron.t # Failed test 'extended_attributes' # at t/db_dependent/Koha/Patron.t line 686. Missing mandatory extended attribute (type=TEST)# Looks like your test exited with 255 just after 7. t/db_dependent/Koha/Patron.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 10/16 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patron.t (Wstat: 65280 Tests: 7 Failed: 1) Failed test: 7 Non-zero exit status: 255 Parse errors: Bad plan. You planned 16 tests but ran 7. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 7021] Add patron category to the statistics table
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '22

13 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 koha-US bug tracker <bugzilla(a)koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla(a)koha-us.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7021] Add patron category to the statistics table
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '22

13 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #45 from Sally <sally.healey(a)cheshiresharedservices.gov.uk> --- We'd really love to see this feature in Koha. We don't use pseudonymization as there are statistics that we pull together where we reference date of birth. Pseudonymization definitely has a place, but we've developed policies to ensure that we're processing our collected data in line with GDPR and with consent granted by our patrons. The statistics table is the heart of our performance statistics, and having a permanent record of which category a patron was in would be a major step forward for us. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12225] SIP does not respect the "no block" flag
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '22

13 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- David, can you test again with the latest patch? It switches to using the offline circ checkout code. The idea behind "no block" is the patron already has it. It's basically SIP offline circ ( aka store and forward ) where the patron already has it so we'd better check it out to them! It makes sense to use the same code for both. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12225] SIP does not respect the "no block" flag
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '22

13 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 --- Comment #15 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 137683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137683&action=e… Bug 12225: Use ProcessOfflineIssue -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '22

13 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #69 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- The current patch is quite different than the previous one so I marked the previous tests as obsolete. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10086] No way to go back to the basket on uncertain prices page
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '22

13 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136505|0 |1 is obsolete| | Attachment #136506|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 137681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137681&action=e… Bug 10086: Link to go to basket from uncertain prices page This patch moves the Edit button into an Edit column, styled with bootstrap button and font awesome icon, and adds a link on the basket name to go to the basket. To test: 1) Add an item with uncertain prices to a basket 2) Go to the vendor of the basket 3) Click Uncertain prices on the left 4) Notice 'edit' button does not look like a button, and basket name is not a link 5) Apply patch and refresh page 6) Basket name is now a link. Click to confirm it takes you to the right page 7) Edit button is now in edit column. Confirm it works as expected 8) Confirm you cannot sort on Edit column and the button does not wrap on a narrower browser 9) Check that the correct information is displayed for the order column (title, author, publisher code, publication year, copyright date, isbn) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0