July 2022 - Koha-bugs - lists.koha-community.org

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '22

11 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #41 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- All appears to work as designed.. signing off, ready for QA :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '22

11 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137520|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137523&action=e… Bug 12029: DBIC Schema Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '22

11 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137519|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137522&action=e… Bug 12029: (follow-up) Adhering to coding guidelines This is a follow-up patch which (based on comment #19) does the following: 1) Removes newline from top of Koha/Patron/Messages.pm 2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread 3) Removes method Koha::Patron::Messages->unread_count 4) (Will address tests in separate patch) 5) Removes changes to Koha/Schema/Result/Message.pm 6) Changes atomicupdate from qq{} to q{} 7) (Left for RM) 8) Removes extra copyright statement in opac/dismiss_message.pl 9) Removes extra comments from opac/dismiss_message.pl 10) (Left for now) 11) (Left for now) Sponsored-by: Horowhenua Library Trust Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '22

11 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137518|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137521&action=e… Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '22

11 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #37 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I've added the Schema patch here to make this easier to test on sandboxes... However.. please note when you see an error like this you can actually build the schema's yourself from the sandbox action menu 'Refresh schema' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '22

11 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #36 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137520&action=e… Bug 12029: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '22

11 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137435|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137519&action=e… Bug 12029: (follow-up) Adhering to coding guidelines This is a follow-up patch which (based on comment #19) does the following: 1) Removes newline from top of Koha/Patron/Messages.pm 2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread 3) Removes method Koha::Patron::Messages->unread_count 4) (Will address tests in separate patch) 5) Removes changes to Koha/Schema/Result/Message.pm 6) Changes atomicupdate from qq{} to q{} 7) (Left for RM) 8) Removes extra copyright statement in opac/dismiss_message.pl 9) Removes extra comments from opac/dismiss_message.pl 10) (Left for now) 11) (Left for now) Sponsored-by: Horowhenua Library Trust -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '22

11 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137434|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137518&action=e… Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31125] New: Fix warnings from register.tt
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '22

11 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31125 Bug ID: 31125 Summary: Fix warnings from register.tt Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, martin.renvoize(a)ptfs-europe.com Blocks: 25790 When running the QA tools on register.tt (tt?) there are some warnings we should fix: Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 87. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 87. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 88. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 158. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 288. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '22

11 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #210 from David Cook <dcook(a)prosentient.com.au> --- It looks like there's no way to set a default for this field... -- You are receiving this mail because: You are watching all bug changes.

1 0